Do not check object references for equality after hot reload by buyaa-n · Pull Request #73009 · dotnet/runtime

buyaa-n · 2022-07-28T16:29:26Z

RuntimeType member's cache is purged after hot reload, therefore same member references are not equal after hotreload which causing issue like mentioned in Hot Reload breaks MethodInfo equality

Updated/added Object.Equals overloads to compare metadata token and module in case hot reload taken place instead of comparing object references.

Fixes#69427

ghost · 2022-07-28T16:29:48Z

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

RuntimeType member's cache is purged after hot reload, therefore same member references are not equal after hotreload which causing issue like mentioned in Hot Reload breaks MethodInfo equality

Updated/added Object.Equals overloads to compare metadata token and module in case hot reload taken place instead of comparing object references.

Fixes #69427

Author:	buyaa-n
Assignees:	-
Labels:	`area-System.Reflection`
Milestone:	-

…HashCode

buyaa-n · 2022-08-04T00:18:16Z

Do you understand why? Have you been able to create a small standalone repro using just the reflection APIs?

No, I could not understood why, a typical failure log looks like this:

Dynamic.Operator.Tests.PlusEqualTypeTests.Byte [FAIL]
System.ArgumentException : ParameterExpression of type 'System.String' cannot be used for delegate parameter of type 'System.Object'
Stack Trace:
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(954,0): at System.Linq.Expressions.Expression.ValidateLambdaArgs(Type delegateType, Expres
sion& body, ReadOnlyCollection`1 parameters, String paramName)
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(717,0): at System.Linq.Expressions.Expression.Lambda[TDelegate](Expression body, String na
me, Boolean tailCall, IEnumerable`1 parameters)
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Runtime\CompilerServices\CallSiteBinder.cs(192,0): at System.Runtime.CompilerServices.CallSiteBinder.Stitch[T](Expression bindi
ng, LambdaSignature`1 signature)
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Runtime\CompilerServices\CallSiteBinder.cs(132,0): at System.Runtime.CompilerServices.CallSiteBinder.BindCore[T](CallSite`1 sit
e, Object[] args)
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Dynamic\UpdateDelegates.Generated.cs(157,0): at System.Dynamic.UpdateDelegates.UpdateAndExecute2[T0,T1,TRet](CallSite site, T0
arg0, T1 arg1)
D:\dotnet\pr2\src\libraries\System.Dynamic.Runtime\tests\Dynamic.Context\Conformance.dynamic.context.operator.compound.type.PlusEqual.cs(76,0): at Dynamic.Operator.Tests.PlusEqualTypeTests.B
yte()
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
D:\dotnet\pr2\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(69,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

just know reverting back the Equals logic fixes those failures, will dig more

buyaa-n · 2022-08-04T00:22:09Z

Another log

System.Text.Tests.EncodingTests.GetEncoding_FromProvider_ByCodePage_WithDisallowedEncoding_Throws(encodingName: "utf-7", codePage: 65000) [FAIL]
System.ArgumentException : ParameterExpression of type 'System.Text.EncodingProvider' cannot be used for delegate parameter of type 'System.Reflection.Binder'
Stack Trace:
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(954,0): at System.Linq.Expressions.Expression.ValidateLambdaArgs(Type delegateType, Expres
sion& body, ReadOnlyCollection`1 parameters, String paramName)
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(717,0): at System.Linq.Expressions.Expression.Lambda[TDelegate](Expression body, String na
me, Boolean tailCall, IEnumerable`1 parameters)
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(689,0): at System.Linq.Expressions.Expression.Lambda[TDelegate](Expression body, Boolean t
ailCall, IEnumerable`1 parameters)
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(651,0): at System.Linq.Expressions.Expression.Lambda[TDelegate](Expression body, Parameter
Expression[] parameters)
D:\dotnet\pr2\src\libraries\System.Runtime\tests\System\Text\EncodingTests.cs(43,0): at System.Text.Tests.EncodingTests.GetEncoding_FromProvider_ByCodePage_WithDisallowedEncoding_Throws(Stri
ng encodingName, Int32 codePage)
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
D:\dotnet\pr2\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(64,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
System.ArgumentException : ParameterExpression of type 'System.Text.EncodingProvider' cannot be used for delegate parameter of type 'System.Reflection.Binder'
Stack Trace:
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(954,0): at System.Linq.Expressions.Expression.ValidateLambdaArgs(Type delegateType, Expres
sion& body, ReadOnlyCollection`1 parameters, String paramName)
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(717,0): at System.Linq.Expressions.Expression.Lambda[TDelegate](Expression body, String na
me, Boolean tailCall, IEnumerable`1 parameters)
System.Text.Tests.EncodingTests.GetEncoding_FromProvider_ByEncodingName_WithDisallowedEncoding_Throws(encodingName: "utf-7", codePage: 65000) [FAIL]
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(689,0): at System.Linq.Expressions.Expression.Lambda[TDelegate](Expression body, Boolean t
ailCall, IEnumerable`1 parameters)
D:\dotnet\pr2\src\libraries\System.Linq.Expressions\src\System\Linq\Expressions\LambdaExpression.cs(651,0): at System.Linq.Expressions.Expression.Lambda[TDelegate](Expression body, Parameter
Expression[] parameters)
D:\dotnet\pr2\src\libraries\System.Runtime\tests\System\Text\EncodingTests.cs(71,0): at System.Text.Tests.EncodingTests.GetEncoding_FromProvider_ByEncodingName_WithDisallowedEncoding_Throws(
String encodingName, Int32 codePage)
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
D:\dotnet\pr2\src\libraries\System.Private.CoreLib\src\System\Reflection\MethodInvoker.cs(64,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

… test failures" This reverts commit d4d961c.

jkotas · 2022-08-05T00:49:52Z

Looking at the test failures - the reflected type needs to be also included in Equals method.

…GetHashCode

- No need to use GetHashCodeOfPtr when we are wrapping the hashcode using HashCode.Combine that takes care of the randomization - Use underlying type handle for type hashcodes. It is faster than the default object hashcode. - Delete special casing for MetadataUpdater.IsSupported from RuntimeMethodInfo.GetHashCode. It is actually a de-optimization for RuntimeMethodInfo with the two changes above, and about neutral for the rest. - Avoid virtual call for ReflectedType comparison - Restore comment for RuntimeMethodInfo

jkotas · 2022-08-06T13:48:43Z

@buyaa-n I have pushed a commit with a bunch of perf tweaks and simplifications. The commit description has the details. Let me know if it looks good to you or if you have any questions.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

buyaa-n · 2022-08-06T17:14:42Z

@buyaa-n I have pushed a commit with a bunch of perf tweaks and simplifications. The commit description has the details. Let me know if it looks good to you or if you have any questions.

Thanks for the description, makes sense to me

jkotas · 2022-08-08T00:35:44Z

Looks good to me, modulo the last two comments

buyaa-n · 2022-08-08T17:55:51Z

Failures unrelated and known issue, merging

Equality check of type members after hot reload
560e4cb

buyaa-n requested review from jkotas and steveharter July 28, 2022 16:29

ghost added the area-System.Reflection label Jul 28, 2022

ghost assigned buyaa-n Jul 28, 2022

buyaa-n commented Jul 28, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs Outdated

jkotas reviewed Jul 28, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeFieldInfo.cs Outdated

jkotas reviewed Jul 28, 2022
View reviewed changes

Comment thread...lr/System.Private.CoreLib/src/System/Reflection/Metadata/RuntimeTypeMetadataUpdateHandler.cs Outdated

jkotas reviewed Jul 28, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/Reflection/ReflectionCacheTests.cs Outdated

AaronRobinsonMSFT reviewed Jul 28, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/Reflection/ReflectionCacheTests.cs Outdated

Apply comments
bfe943b

stephentoub reviewed Aug 1, 2022
View reviewed changes

Comment thread...lr/System.Private.CoreLib/src/System/Reflection/Metadata/RuntimeTypeMetadataUpdateHandler.cs Outdated

stephentoub reviewed Aug 1, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeEventInfo.cs Outdated

runfoappBot mentioned this pull request Aug 1, 2022
Methodical_others test JIT/Methodical/Coverage/copy_prop_byref_to_native_int crashing #69832
Open

Apply feedback
76e2b02

buyaa-n commented Aug 1, 2022
View reviewed changes

Comment threadsrc/libraries/System.Runtime/tests/System/Reflection/ReflectionCacheTests.cs

Renamed the propertyName in test
71e176d

jkotas reviewed Aug 1, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeEventInfo.cs Outdated

buyaa-n added 2 commits August 1, 2022 18:08

Compare type instead of module, check MetadataUpdater.IsSupported in …
1b0d414
…HashCode

Update and use CacheEquals
621d6f7

buyaa-n force-pushed the hot-reload branch from a38c0bb to 621d6f7Compare August 2, 2022 01:37

stephentoub reviewed Aug 2, 2022
View reviewed changes

Comment thread...lr/System.Private.CoreLib/src/System/Reflection/Metadata/RuntimeTypeMetadataUpdateHandler.cs Outdated

jkotas reviewed Aug 2, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs Outdated

steveharter reviewed Aug 2, 2022
View reviewed changes

buyaa-n added 2 commits August 2, 2022 10:12

Apply feedbacks
97bde09

Use ReferenceEquals
11355a4

IDisposable reviewed Aug 2, 2022
View reviewed changes

jkotas reviewed Aug 2, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/MdFieldInfo.cs Outdated

jkotas reviewed Aug 2, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.CoreCLR.cs Outdated

ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 4, 2022

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 4, 2022

jkotasand others added 3 commits August 4, 2022 13:26

Revert "Update RMethodInfo RConstructorInfo Equals override to fix CI…
b9dc388
… test failures" This reverts commit d4d961c.

Fix tests
ea07c6f

Update RuntimeConstructorInfo Equals, HashCode similarly
06681a8

buyaa-n force-pushed the hot-reload branch from a438a23 to 06681a8Compare August 4, 2022 21:42

jkotas reviewed Aug 4, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeFieldInfo.cs Outdated

jkotas approved these changes Aug 4, 2022
View reviewed changes

IDisposable reviewed Aug 4, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.CoreCLR.cs Outdated

IDisposable reviewed Aug 4, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs Outdated

runfoappBot mentioned this pull request Aug 5, 2022
GC/API/GC/GetGCMemoryInfo/GetGCMemoryInfo.sh test failing intermittently on CoreCLR Linux ARM32 #73247
Closed

buyaa-nand others added 2 commits August 5, 2022 17:54

Add reflected type into Equals, check MetadataUpdater.IsSupported in …
eb9d197
…GetHashCode

jkotas reviewed Aug 6, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.CoreCLR.cs Outdated

buyaa-n commented Aug 6, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.CoreCLR.cs Outdated

Apply suggestions from code review
cbeb099
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

IDisposable approved these changes Aug 8, 2022
View reviewed changes

jkotas reviewed Aug 8, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeFieldInfo.cs Outdated

jkotas reviewed Aug 8, 2022
View reviewed changes

Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.CoreCLR.cs

Apply feedback
4730c9f

buyaa-n merged commit 7e0f0b7 into dotnet:mainAug 8, 2022

buyaa-n deleted the hot-reload branch August 8, 2022 17:57

ghost locked as resolved and limited conversation to collaborators Sep 7, 2022

Uh oh!

Conversation

buyaa-n commented Jul 28, 2022

Uh oh!

ghost commented Jul 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buyaa-n commented Aug 4, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

buyaa-n commented Aug 4, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Aug 5, 2022

Uh oh!

jkotas commented Aug 6, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buyaa-n commented Aug 6, 2022

Uh oh!

Uh oh!

Uh oh!

jkotas commented Aug 8, 2022

Uh oh!

buyaa-n commented Aug 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

buyaa-n commented Aug 4, 2022•
edited
Loading

jkotas commented Aug 6, 2022•
edited
Loading