Skip to content

Disable NJulianRuleTest on Android - #73030

Merged
tarekgh merged 3 commits into
dotnet:mainfrom
tarekgh:DiableNJulianRuleTestForAndroid
Jul 29, 2022
Merged

Disable NJulianRuleTest on Android#73030
tarekgh merged 3 commits into
dotnet:mainfrom
tarekgh:DiableNJulianRuleTestForAndroid

Conversation

@tarekgh

@tarekghtarekgh commented Jul 28, 2022

Copy link
Copy Markdown
Member

Fixes#72995

@ghost

ghost commented Jul 28, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned tarekghJul 28, 2022
@tarekgh
tarekgh requested a review from eerhardtJuly 28, 2022 23:07
@tarekghtarekgh added this to the 7.0.0 milestone Jul 28, 2022
@ghost

ghost commented Jul 28, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #72995

Author:tarekgh
Assignees:tarekgh
Labels:

area-System.Runtime

Milestone:7.0.0

@tarekghtarekgh mentioned this pull request Jul 28, 2022
Closed
eerhardt
eerhardt reviewed Jul 28, 2022
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs Outdated
@tarekghtarekgh mentioned this pull request Jul 28, 2022
Open
ilonatommy
ilonatommy previously requested changes Jul 29, 2022
View reviewed changes

@ilonatommyilonatommy left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR still fails with the same error, so disabling was not effective:
image
see: runtime-staging, inside the Tests. Green tick is misleading, it does not guarantee passing tests, only indicates that the build passed.

@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 29, 2022
ilonatommy
ilonatommy reviewed Jul 29, 2022
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs Outdated
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 29, 2022
@tarekgh@ilonatommy
Update src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
e4989fa
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
@tarekgh

tarekgh commented Jul 29, 2022

Copy link
Copy Markdown
MemberAuthor

Looks @ilonatommy using PlatformDetection.IsLinuxBionic did the trick. Now the test is not failing in the staging build.

@tarekghtarekgh closed this Jul 29, 2022
@tarekghtarekgh reopened this Jul 29, 2022
@tarekgh

tarekgh commented Jul 29, 2022

Copy link
Copy Markdown
MemberAuthor

@ilonatommy can you remove the change request and merge. The PR is blocked by that.

@eerhardt
eerhardt requested a review from ilonatommyJuly 29, 2022 19:06
@eerhardt
eerhardt dismissed ilonatommy’s stale reviewJuly 29, 2022 19:07

Issue was addressed.

@tarekgh
tarekgh merged commit d30ab11 into dotnet:mainJul 29, 2022
@ghostghost locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MattGalMattGalMattGal left review comments
@eerhardteerhardteerhardt left review comments
@ilonatommyilonatommyAwaiting requested review from ilonatommy
+1 more reviewer
@dakersnardakersnardakersnar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tarekghtarekgh

Labels

area-System.Runtime

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

[LinuxBionic][CI] System.Tests.TimeZoneInfoTests.NJulianRuleTest failing

5 participants

@tarekgh@MattGal@eerhardt@dakersnar@ilonatommy