Skip to content

Bring back live host change - #73095

Merged
agocke merged 12 commits into
dotnet:mainfrom
agocke:live-host
Aug 2, 2022
Merged

Bring back live host change#73095
agocke merged 12 commits into
dotnet:mainfrom
agocke:live-host

Conversation

@agocke

Copy link
Copy Markdown
Member

The previous problem seems to be the usage of RuntimeFiles as the ItemGroup for the host files instead of NativeRuntimeAsset, and the lack of PackOnly, which prevents hostfxr from being included in the shared framework package.

@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned agockeJul 29, 2022
@agocke
agocke marked this pull request as ready for review July 31, 2022 00:50
Comment threadsrc/libraries/externals.csproj
@agocke

Copy link
Copy Markdown
MemberAuthor

also @jkoritzinsky

@ViktorHofer

Copy link
Copy Markdown
Member

@agocke in general looks good but can you please point me to the fix (in this change) for the previous regression?

Comment threadeng/liveBuilds.targets Outdated
</ItemGroup>

<!-- Host files. Mobile uses a different hosting model, so we don't include the .NET host components there. -->
<ItemGroup Condition="'$(TargetsMobile)' != 'true' and Exists('$(DotNetHostBinDir)')">

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViktorHofer This is the problematic part. By moving the host files to RuntimeFiles they ended up getting copied into the shared framework pack, when they were only supposed to be in the runtime pack. Keeping this in the Microsoft.NetCore.App package fixed the problem.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the changes in externals.proj basically replicate the behavior that was intended with the above change.

@ViktorHoferViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, awesome 👍

@vitek-karas do you know if the host packages (Microsoft.NETCore.DotNetHost and Microsoft.NETCore.DotNetHostPolicy) are still consumed by anyone? Asking as this PR removes our own dependency on them.

@agocke

Copy link
Copy Markdown
MemberAuthor

@elinor-fung Mentioned that the host packages aren't directly depended on at the moment, but they're our vehicle for symbols for the hosting components. I'd want to bring the change through to stop building them separately, and confirm we still have symbols.

@hoyosjshoyosjs mentioned this pull request Aug 24, 2022
@ghostghost locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@agocke@ViktorHofer@am11