Skip to content

Fix missing symbols for singlefilehost - #73269

Merged
elinor-fung merged 3 commits into
dotnet:mainfrom
elinor-fung:singlefilehostSymbols
Aug 3, 2022
Merged

Fix missing symbols for singlefilehost#73269
elinor-fung merged 3 commits into
dotnet:mainfrom
elinor-fung:singlefilehostSymbols

Conversation

@elinor-fung

Copy link
Copy Markdown
Member

The symbol packages were missing symbols for singlefilehost because they weren't being copied to the expected location, resulting in singlefilehost.dbg/pdb not being published. This updates the PrepareSingleFileHostWithEmbeddedDacCore target to copy the symbol file from and to the expected locations (PDB sudbirectory for Windows, next to the binary for non-Windows).

Fixes#71735

@ghost

ghost commented Aug 2, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

The symbol packages were missing symbols for singlefilehost because they weren't being copied to the expected location, resulting in singlefilehost.dbg/pdb not being published. This updates the PrepareSingleFileHostWithEmbeddedDacCore target to copy the symbol file from and to the expected locations (PDB sudbirectory for Windows, next to the binary for non-Windows).

Fixes #71735

Author:elinor-fung
Assignees:-
Labels:

area-Single-File

Milestone:-

@ghostghost assigned elinor-fungAug 2, 2022
Comment threadsrc/native/corehost/corehost.proj

@agockeagocke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@VSadovVSadov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

@elinor-fung
elinor-fung merged commit 687a353 into dotnet:mainAug 3, 2022
@elinor-fung
elinor-fung deleted the singlefilehostSymbols branch August 3, 2022 19:42
@ghostghost locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing preview and daily build symbols

5 participants

@elinor-fung@agocke@jkoritzinsky@am11@VSadov