[wasm] Unmanaged structs are considered blittable if module has `DisableRuntimeMarshallingAttribute` by maraf · Pull Request #73310 · dotnet/runtime

maraf · 2022-08-03T16:03:21Z

Consider all types in pinvokes from assembly marked with DisableRuntimeMarshallingAttribute as blittable.
Based on API proposal in #60639.

PInvokeTableGenerator: Avoid crash when processing unmanaged callbacks with function pointers.

Fixes#61146.

maraf · 2022-08-03T16:03:36Z

/azp run runtime-wasm

azure-pipelines · 2022-08-03T16:03:49Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2022-08-03T16:03:53Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Consider all types from assembly marked with DisableRuntimeMarshallingAttribute as blittable.
Based on #60639.

Fixes #61146.

Author:	maraf
Assignees:	maraf
Labels:	`arch-wasm`, `area-Interop-mono`
Milestone:	7.0.0

jkoritzinsky · 2022-08-03T17:00:39Z

This is not entirely true. An unmanaged struct defined in an assembly with DisableRuntimeMarshalling isn't necessarily blittable if it is used in a P/Invoke in an assembly without DisableRuntimeMarshallingAttribute.

…leRuntimeMarshallingAttribute.

maraf · 2022-08-04T10:32:47Z

This is not entirely true. An unmanaged struct defined in an assembly with DisableRuntimeMarshalling isn't necessarily blittable if it is used in a P/Invoke in an assembly without DisableRuntimeMarshallingAttribute.

Thanks!
Must both struct and p/invoke assemblies be marked with DisableRuntimeMarshallingAttribute?

jkoritzinsky · 2022-08-04T17:00:43Z

Only the P/Invoke assembly must be marked with the attribute.

maraf

~~Look for the DisableRuntimeMarshallingAttribute on the assembly where pinvoke method is declared.~~
Mistake...

… pinvoke method is declared.

maraf · 2022-08-05T15:53:39Z

/azp run runtime-wasm

azure-pipelines · 2022-08-05T15:53:48Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-08-05T16:06:37Z

/azp run runtime-wasm

azure-pipelines · 2022-08-05T16:06:46Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-08-09T07:54:43Z

/azp run runtime-wasm

azure-pipelines · 2022-08-09T07:54:58Z

Azure Pipelines successfully started running 1 pipeline(s).

…rDisableRuntimeMarshalling

maraf · 2022-08-09T12:59:54Z

/azp run runtime-wasm

azure-pipelines · 2022-08-09T13:00:09Z

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Ankit Jain <radical@gmail.com>

maraf · 2022-08-12T07:22:59Z

/azp run runtime-wasm

azure-pipelines · 2022-08-12T07:23:08Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-08-12T12:37:08Z

Failures don't seem relevant.

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-73310-merge-6827ac8318034a2eb2/Workloads-.WasmTemplateTests/1/console.88ad2f22.log?helixlogtype=result

…isableRuntimeMarshalling

radical · 2022-08-14T13:40:08Z

/azp run runtime-wasm

azure-pipelines · 2022-08-14T13:40:24Z

Azure Pipelines successfully started running 1 pipeline(s).

.. callbacks with function pointers.

…isableRuntimeMarshalling

radical · 2022-08-15T04:32:20Z

/azp run runtime-wasm

azure-pipelines · 2022-08-15T04:32:30Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-08-15T08:40:53Z

The wasm EAT/AOT test failures are #73932 .
The Perftracing build failure is #73933 .

radical · 2022-08-15T08:45:19Z

The Linux_musl x64 coreclr failure is #73930 .

kasperk81 · 2022-08-15T11:44:39Z

+ {
+ _assemblyDisableRuntimeMarshallingAttributeCache[assembly] = value = assembly
+ .GetCustomAttributesData()
+ .Any(d => d.AttributeType.Name == "DisableRuntimeMarshallingAttribute");


can use nameof(DisableRuntimeMarshallingAttribute) with using System.Runtime.CompilerServices;

The assembly is also compiled for net47 and the attribute is not available there.

maraf added arch-wasm WebAssembly architecture area-Interop-mono labels Aug 3, 2022

maraf added this to the 7.0.0 milestone Aug 3, 2022

maraf self-assigned this Aug 3, 2022

[wasm] Unmanaged structs are considered blittable if module has Disab…
4e044cf
…leRuntimeMarshallingAttribute.

maraf force-pushed the WasmPInvokeGeneratorDisableRuntimeMarshalling branch from e32a7b8 to 4e044cfCompare August 4, 2022 07:51

Fix WBT.
1ebaceb

maraf commented Aug 5, 2022
View reviewed changes

Look for the DisableRuntimeMarshallingAttribute on the assembly where…
a251e07
… pinvoke method is declared.

maraf requested review from lambdageek and radical August 5, 2022 15:54

maraf marked this pull request as ready for review August 5, 2022 15:54

Fix
3098462

This was referenced Aug 5, 2022
Infra improvements for Helix #68176
Closed
GC/API/GC/GetGCMemoryInfo/GetGCMemoryInfo.sh test failing intermittently on CoreCLR Linux ARM32 #73247
Closed

Merge remote-tracking branch 'upstream/main' into WasmPInvokeGenerato…
26c257e
…rDisableRuntimeMarshalling

radical reviewed Aug 11, 2022
View reviewed changes

Comment threadsrc/tasks/WasmAppBuilder/PInvokeTableGenerator.cs Outdated

Update src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs
2b148dd
Co-authored-by: Ankit Jain <radical@gmail.com>

maraf requested a review from radical August 12, 2022 12:37

Merge remote-tracking branch 'origin/main' into WasmPInvokeGeneratorD…
1a04df7
…isableRuntimeMarshalling

radical reviewed Aug 13, 2022
View reviewed changes

Comment threadsrc/tests/BuildWasmApps/Wasm.Build.Tests/PInvokeTableGeneratorTests.cs

radical reviewed Aug 13, 2022
View reviewed changes

Comment threadsrc/tests/BuildWasmApps/Wasm.Build.Tests/PInvokeTableGeneratorTests.cs Outdated

radical reviewed Aug 13, 2022
View reviewed changes

Comment threadsrc/tests/BuildWasmApps/Wasm.Build.Tests/PInvokeTableGeneratorTests.cs Outdated

radical reviewed Aug 13, 2022
View reviewed changes

Comment threadsrc/tests/BuildWasmApps/Wasm.Build.Tests/PInvokeTableGeneratorTests.cs Outdated

radical reviewed Aug 13, 2022
View reviewed changes

Comment threadsrc/tests/BuildWasmApps/Wasm.Build.Tests/PInvokeTableGeneratorTests.cs Outdated

radical added 2 commits August 14, 2022 02:14

Merge remote-tracking branch 'origin/main' into WasmPInvokeGeneratorD…
5fd9450
…isableRuntimeMarshalling

Update, and add some additional tests
2c6c1a6

radical reviewed Aug 14, 2022
View reviewed changes

Comment threadsrc/tests/BuildWasmApps/Wasm.Build.Tests/PInvokeTableGeneratorTests.cs Outdated

radical reviewed Aug 14, 2022
View reviewed changes

Comment threadsrc/tests/BuildWasmApps/Wasm.Build.Tests/PInvokeTableGeneratorTests.cs Outdated

Apply suggestions from code review
af89fb7

radical added 2 commits August 15, 2022 04:27

[wasm] PInvokeTableGenerator: Avoid crash when processing unmanaged
7e8558c
.. callbacks with function pointers.

Merge remote-tracking branch 'origin/main' into WasmPInvokeGeneratorD…
88cfad2
…isableRuntimeMarshalling

radical approved these changes Aug 15, 2022
View reviewed changes

radical merged commit 058bed7 into dotnet:mainAug 15, 2022

maraf deleted the WasmPInvokeGeneratorDisableRuntimeMarshalling branch August 15, 2022 08:55

kasperk81 reviewed Aug 15, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Sep 14, 2022

Uh oh!

Conversation

maraf commented Aug 3, 2022• edited by radical Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maraf commented Aug 3, 2022

Uh oh!

azure-pipelinesBot commented Aug 3, 2022

Uh oh!

ghost commented Aug 3, 2022

Uh oh!

jkoritzinsky commented Aug 3, 2022

Uh oh!

maraf commented Aug 4, 2022

Uh oh!

jkoritzinsky commented Aug 4, 2022

Uh oh!

maraf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maraf commented Aug 5, 2022

Uh oh!

azure-pipelinesBot commented Aug 5, 2022

Uh oh!

maraf commented Aug 5, 2022

Uh oh!

azure-pipelinesBot commented Aug 5, 2022

Uh oh!

maraf commented Aug 9, 2022

Uh oh!

azure-pipelinesBot commented Aug 9, 2022

Uh oh!

maraf commented Aug 9, 2022

Uh oh!

azure-pipelinesBot commented Aug 9, 2022

Uh oh!

Uh oh!

maraf commented Aug 12, 2022

Uh oh!

azure-pipelinesBot commented Aug 12, 2022

Uh oh!

maraf commented Aug 12, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

radical commented Aug 14, 2022

Uh oh!

azure-pipelinesBot commented Aug 14, 2022

Uh oh!

radical commented Aug 15, 2022

Uh oh!

azure-pipelinesBot commented Aug 15, 2022

Uh oh!

radical commented Aug 15, 2022

Uh oh!

radical commented Aug 15, 2022

Uh oh!

kasperk81Aug 15, 2022

Choose a reason for hiding this comment

Uh oh!

marafAug 15, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

maraf commented Aug 3, 2022•
edited by radical
Loading

maraf left a comment •
edited
Loading

maraf commented Aug 12, 2022•
edited
Loading