Skip to content

runtime-staging: Enable failed tests on stable jobs to fail the job - #73400

Merged
radical merged 4 commits into
dotnet:mainfrom
radical:ci-fixes
Aug 8, 2022
Merged

runtime-staging: Enable failed tests on stable jobs to fail the job#73400
radical merged 4 commits into
dotnet:mainfrom
radical:ci-fixes

Conversation

@radical

@radicalradical commented Aug 4, 2022

Copy link
Copy Markdown
Member

xplat-setup.yml: Add support for setting shouldContinueOnError to
.. false.

Currently, xplat-setup.yml passes on shouldContinueOnError to the
template with true if the parameter was true, else it sets the value
based on whether this is for runtime-staging, on a PR.

Which essentially means that runtime-staging defaults to
shouldContinueOnError: true for PRs, or we can set it explcitly to
true which would affect the rolling builds.

But this does not allow making a runtime-staging job fail when tests
fail
. To support that this change adds a check for a special value
forceFalse (thanks to @akoeplinger for the suggestion), which causes
the param to explicitly set to false. Thus allowing runtime-staging
builds to be marked as such.

  • These jobs will now fail when their tests fail:

    • windows - library tests, and AOT
    • windows - WasmBuildTests
    • debugger tests for chrome
  • This will prevent errors getting missed, and merged because runtime-staging wasn't looked at

  • Also, add more paths to trigger tests on CI

Related: #73166

@radicalradical added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Aug 4, 2022
@ghostghost assigned radicalAug 4, 2022
@ghost

ghost commented Aug 4, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. false.

Currently, xplat-setup.yml passes on shouldContinueOnError to the
template with true if the parameter was true, else it sets the value
based on whether this is for runtime-staging, on a PR.

Which essentially means that runtime-staging defaults to
shouldContinueOnError: true for PRs, or we can set it explcitly to
true which would affect the rolling builds.

But this does not allow making a runtime-staging job fail when tests
fail
. To support that this change adds a check for a special value
forceFalse (thanks to @akoeplinger for the suggestion), which causes
the param to explicitly set to false. Thus allowing runtime-staging
builds to be marked as such.

  • Also, add more paths to trigger tests on CI
Author:radical
Assignees:-
Labels:

arch-wasm, area-Infrastructure-mono

Milestone:-

@radical
radical marked this pull request as draft August 4, 2022 20:46
.. `false`.
Currently, xplat-setup.yml passes on `shouldContinueOnError` to the
template with `true` if the parameter was `true`, else it sets the value
based on whether this is for runtime-staging, on a PR.
Which essentially means that runtime-staging defaults to
`shouldContinueOnError: true` for PRs, or we can set it explcitly to
`true` which would affect the rolling builds.
But this does not allow making a runtime-staging job *fail* when *tests
fail*. To support that this change adds a check for a special value
`forceFalse`, which causes the param to explicitly set to `false`. Thus
allowing `runtime-staging` builds to be marked as such.
@radical
radical marked this pull request as ready for review August 5, 2022 02:57
@radicalradical changed the title xplat-setup.yml: Add support for setting shouldContinueOnError toruntime-staging: Enable failed tests on stable jobs to fail the jobAug 5, 2022
@radicalradical added this to the 7.0.0 milestone Aug 5, 2022

@akoeplingerakoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after making the changes we discussed on Discord

@radical

Copy link
Copy Markdown
MemberAuthor

LGTM after making the changes we discussed on Discord

As discussed, I'll move the stable wasm jobs from runtime-staging to runtime, in a follow up PR. And am merging this one.

@radical
radical merged commit 11f162a into dotnet:mainAug 8, 2022
@radical
radical deleted the ci-fixes branch August 8, 2022 19:24
@ghostghost locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@radical@akoeplinger