Skip to content

Simplify initialization of CILJit singleton - #73471

Merged
jkotas merged 2 commits into
dotnet:mainfrom
jkotas:simpler-fix
Aug 5, 2022
Merged

Simplify initialization of CILJit singleton#73471
jkotas merged 2 commits into
dotnet:mainfrom
jkotas:simpler-fix

Conversation

@jkotas

Copy link
Copy Markdown
Member

No description provided.

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 5, 2022
@ghostghost assigned jkotasAug 5, 2022
@ghost

ghost commented Aug 5, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:jkotas
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@jakobbotschjakobbotsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided CI is green

@jkotas

Copy link
Copy Markdown
MemberAuthor

System.Net.WebSockets.Client.Tests crashed on Libraries Test Run checked coreclr Linux_musl x64 Debug. Stacktrace:

Call Site
libcoreclr!Object::GetGCSafeMethodTable [/__w/1/s/src/coreclr/vm/object.h @ 446] libcoreclr!Object::ValidateInner+0x1b0
libcoreclr!Object::Validate+0x8a [/__w/1/s/src/coreclr/vm/object.cpp @ 1124] libcoreclr!OBJECTREF::OBJECTREF+0xfa [/__w/1/s/src/coreclr/vm/object.cpp @ 1124] libcoreclr!ObjectFromHandle+0x2c [/__w/1/s/src/coreclr/vm/gchandleutilities.h @ 44] libcoreclr!MarshalNative::GCHandleInternalGet+0x50

Tracked by #69125

@jkotas
jkotas merged commit a231aa7 into dotnet:mainAug 5, 2022
@jkotas
jkotas deleted the simpler-fix branch August 5, 2022 23:00
@ghostghost locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jkotas@jakobbotsch