Uh oh!
There was an error while loading. Please reload this page.
[mini] Fix the bounds check in GET_BBLOCK - #73493
Merged
Merged
Conversation
If the target IP is out of bounds, but `cfg->cil_offset_to_bb` has some non-zero data before or after it, then `tblock` will be some non-NULL pointer that we will treat as a good basic block. Related to dotnet#73474 (but doesn't fix the underlying issue there - it will just make the whole offending method throw a BadImageFormatException when it's called) This may have some performance overhead for the mono JIT.
BrzVlad
approved these changes
Aug 5, 2022
lambdageek
commented
Aug 5, 2022
MemberAuthor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the target IP is out of bounds, but
cfg->cil_offset_to_bbhas some non-zero data before or after it, thentblockwill be some non-NULL pointer that we will treat as a good basic block.Related to #73474 (but doesn't fix the underlying issue there - it will just make the whole offending method throw a BadImageFormatException when it's called)
This may have some performance overhead for the mono JIT.