Skip to content

Update heap hard limit for large pages - #73508

Merged
cshung merged 1 commit into
dotnet:mainfrom
cshung:public/update-hard-limit
Sep 20, 2022
Merged

Update heap hard limit for large pages#73508
cshung merged 1 commit into
dotnet:mainfrom
cshung:public/update-hard-limit

Conversation

@cshung

Copy link
Copy Markdown
Contributor

Fixes#54616

This bug is for segments only, some of the segment size calculations may increase the total size allocated. To make sure all allocated memory can be used (without being limited by the heap hard limit), the heap hard limit should be increased to match the allocated memory.

@ghostghost added the area-GC-coreclr label Aug 6, 2022
@cshungcshung self-assigned this Aug 6, 2022
@ghost

ghost commented Aug 6, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #54616

This bug is for segments only, some of the segment size calculations may increase the total size allocated. To make sure all allocated memory can be used (without being limited by the heap hard limit), the heap hard limit should be increased to match the allocated memory.

Author:cshung
Assignees:-
Labels:

area-GC-coreclr

Milestone:-

@cshungcshung added this to the 7.0.0 milestone Aug 6, 2022
@mangod9

Copy link
Copy Markdown
Member

since this only affects certain platforms now, is it worth taking for 7?

@cshung

Copy link
Copy Markdown
ContributorAuthor

since this only affects certain platforms now, is it worth taking for 7?

One way or the other, we need to get this bug out of 7.0.0. We can either fix it, won't fix it, or move the bug to 8. Here are some info helpful for the decision:

  • This is a corner case, it is unexpected for workloads to run under segments and using large pages and specified a hard limit that is not aligned.
  • But this is fatal, if it is not specified correctly, the startup or subsequent virtual commit calls will fail.

Let me know what we want to do with this bug.

@mangod9

Copy link
Copy Markdown
Member

lets move to 8 for now and then we can determine what to do then.

@mangod9mangod9 modified the milestones: 7.0.0, 8.0.0Aug 12, 2022
@cshung
cshungforce-pushed the public/update-hard-limit branch from 4e9866e to 2e0f5b9CompareAugust 16, 2022 20:05

@Maoni0Maoni0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cshung
cshung merged commit d7d6354 into dotnet:mainSep 20, 2022
@cshung
cshung deleted the public/update-hard-limit branch September 20, 2022 22:36
@ghostghost locked as resolved and limited conversation to collaborators Oct 21, 2022
@cshung

Copy link
Copy Markdown
ContributorAuthor

/backport to release/7.0

@github-actionsgithub-actionsBot unlocked this conversation Jan 27, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4027925993

@github-actionsgithub-actionsBot locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure hard limit and large pages work together when the hard limits are not page aligned.

3 participants

@cshung@mangod9@Maoni0