Skip to content

JIT: Fix alignment insertion assuming only emitForceNewIG can create new IGs - #73518

Closed
jakobbotsch wants to merge 1 commit into
dotnet:mainfrom
jakobbotsch:fix-alignment-insertion
Closed

JIT: Fix alignment insertion assuming only emitForceNewIG can create new IGs#73518
jakobbotsch wants to merge 1 commit into
dotnet:mainfrom
jakobbotsch:fix-alignment-insertion

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

Issue I noticed over in #73365.
emitNewInstrAlign can create new IGs for other reasons than emitForceNewIG, e.g. if the current IG cannot fit another instrDesc or if we have reached the limit on the number of instructions in the current IG (255).

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 6, 2022
@jakobbotschjakobbotsch changed the title Fix alignment insertion assuming only emitForceNewIG can create new IGsJIT: Fix alignment insertion assuming only emitForceNewIG can create new IGsAug 6, 2022
@ghostghost assigned jakobbotschAug 6, 2022
@ghost

ghost commented Aug 6, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Issue I noticed over in #73365.
emitNewInstrAlign can create new IGs for other reasons than emitForceNewIG, e.g. if the current IG cannot fit another instrDesc or if we have reached the limit on the number of instructions in the current IG (255).

Author:jakobbotsch
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@jakobbotschjakobbotsch added this to the 7.0.0 milestone Aug 6, 2022
@jakobbotsch

Copy link
Copy Markdown
MemberAuthor

I realize there is emitCheckAlignFitInCurIG now, but it does not handle the 255 case (but maybe this is unreachable as we will reach the size limit before?). I'll just close this.

@ghostghost locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@jakobbotsch