Skip to content

Improve NullabilityInfoContext behavior for ByRef types. - #73520

Merged
buyaa-n merged 7 commits into
dotnet:mainfrom
madelson:fix-72320
Aug 12, 2022
Merged

Improve NullabilityInfoContext behavior for ByRef types.#73520
buyaa-n merged 7 commits into
dotnet:mainfrom
madelson:fix-72320

Conversation

@madelson

@madelsonmadelson commented Aug 6, 2022

Copy link
Copy Markdown
Contributor

@ghostghost added area-System.Reflection community-contribution Indicates that the PR has been added by a community member labels Aug 6, 2022
@ghost

ghost commented Aug 6, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

fix #72320

Author:madelson
Assignees:-
Labels:

area-System.Reflection

Milestone:-

This was referenced Aug 8, 2022
Closed
Closed
Closed
buyaa-n
buyaa-n approved these changes Aug 11, 2022
View reviewed changes

@buyaa-nbuyaa-n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you for adding a broad range of testing @madelson!

buyaa-n
buyaa-n reviewed Aug 11, 2022
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs Outdated
@jkotasjkotas mentioned this pull request Aug 12, 2022
Closed
buyaa-n
buyaa-n reviewed Aug 12, 2022
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs Outdated
@buyaa-n

buyaa-n commented Aug 12, 2022

Copy link
Copy Markdown
Contributor

Failures unrelated, one of the failures related to nuget package availability, filed an issue for other

@buyaa-n
buyaa-n merged commit ec0662c into dotnet:mainAug 12, 2022
@ghostghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky left review comments
+1 more reviewer
@buyaa-nbuyaa-nbuyaa-n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Reflectioncommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can not get NullabilityInfo of out/ref parameters

3 participants

@madelson@buyaa-n@MichalStrehovsky