Uh oh!
There was an error while loading. Please reload this page.
Update MsQuic and use ConnectionCloseStatus in StreamShutdown - #73563
Conversation
ghost
commented
Aug 8, 2022
Tagging subscribers to this area: @dotnet/ncl |
rzikm
commented
Aug 9, 2022
Interestingly enough, the current version when building main already reports 2.1.0, and since CI does not crash, it seems to be recent enough version. |
rzikm
commented
Aug 9, 2022
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Uh oh!
There was an error while loading. Please reload this page.
| // It's local shutdown by app, this side called QuicConnection.CloseAsync, throw QuicError.OperationAborted. | ||
| (shutdownByApp: true, closedRemotely: false) => ThrowHelper.GetOperationAbortedException(), | ||
| // It's remote shutdown by transport, (TODO: we should propagate transport error code), throw QuicError.InternalError. | ||
| // TODO: we should propagate transport error code |
There was a problem hiding this comment.
Is the removal of the description // It's remote shutdown by transport, in the comment intentional? I don't mind it since the named variables are pretty self-explanatory. But if we're doing it, could you do it for all the cases?
There was a problem hiding this comment.
I added the comments back, with very brief explanation when the two transport shutdown cases occur.
rzikm
commented
Aug 10, 2022
Test failures are unrelated |
Fixes#73229.
This PR consumes latest MsQuic changes (2.1.0).
Opening as Draft until dependencies updates are merged (#72934). Unit tests pass with locally built MsQuic release/2.1 branch.