Cleanup to lsra inspired by #73424

[markples]

Inspired by comments (here and here)

• Remove RefPosition* currentRefPosition = &reverseIterator as it creates two variables that are essentially the same, especially since the iterator has operators like ->. In fact, I had to spend a bit of time verifying that there weren't any updates to one but not the other in the code. (And actually Fix undefined behavior found with g++-12 ubsan #73424 did slightly impact this relationship since it moved the assignment from the loop iteration step to the loop body, but I don't believe that this mattered.)
  I renamed the "iterator" variable to the "position" name to reduce textual churn in the code. This didn't work as well for the range-based loops since they yield -references- to the underlying object so a bunch of C++ punctuation changes.
• Break apart two complicated for conditions and remove duplication between the condition and the loop body. Search for continueLoop to see them.
• Delete list's operator& on each iterator since they are no longer used and not part of normal iterators.

[dnfadmin]

All CLA requirements met.

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Inspired by comments (here and here)

• Remove RefPosition* currentRefPosition = &reverseIterator as it creates two variables that are essentially the same, especially since the iterator has operators like ->. In fact, I had to spend a bit of time verifying that there weren't any updates to one but not the other in the code. (And actually Fix undefined behavior found with g++-12 ubsan #73424 did slightly impact this relationship since it moved the assignment from the loop iteration step to the loop body, but I don't believe that this mattered.)
  I renamed the "iterator" variable to the "position" name to reduce textual churn in the code. This didn't work as well for the range-based loops since they yield -references- to the underlying object so a bunch of C++ punctuation changes.
• Break apart two complicated for conditions and remove duplication between the condition and the loop body. Search for continueLoop to see them.

Author:	markples
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[jakobbotsch]

It might be nice to remove the operator& overloads on the various iterator classes as part of this cleanup (I don't know why we have this, it is not part of iterators in the STL). I think you can mark them deleted as an intermediate step to make sure there are no remaining uses of them.

[markples]

It might be nice to remove the operator& overloads [...]

It built fine on the first try - thanks for the recommendation.

[ghost]

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.