Skip to content

Revert "Disable GetGCMemoryInfo on arm (#73477)" - #73595

Merged
hoyosjs merged 1 commit into
dotnet:mainfrom
noahfalk:renable_gc_test
Aug 9, 2022
Merged

Revert "Disable GetGCMemoryInfo on arm (#73477)"#73595
hoyosjs merged 1 commit into
dotnet:mainfrom
noahfalk:renable_gc_test

Conversation

@noahfalk

@noahfalknoahfalk commented Aug 8, 2022•
edited by karelz
Loading

Copy link
Copy Markdown
Member

Fixes#73247

This reverts commit 9865cc7.
We believe the problematic change has been reverted so the test can be re-enabled.

@noahfalk
Revert "Disable GetGCMemoryInfo on arm (dotnet#73477)"
8694661
This reverts commit 9865cc7.
We believe the problematic change has been reverted so the test can be re-enabled.
@ghost

ghost commented Aug 8, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned noahfalkAug 8, 2022
@noahfalk

noahfalk commented Aug 8, 2022

Copy link
Copy Markdown
MemberAuthor

@am11@filipnavara@janvorli@jkoritzinsky@karelz

@noahfalk

noahfalk commented Aug 8, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 8, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@noahfalknoahfalk mentioned this pull request Aug 8, 2022
Merged
@noahfalk

noahfalk commented Aug 8, 2022

Copy link
Copy Markdown
MemberAuthor

@karelz - as new test-monitor can I hand this PR over to you to decide whether or not to merge it? I think the PR that reverted the pinvoke inlining did its ARM validation before this test got disabled and passed so I am reasonably confident that issue is solved. This PR just gets the test turned on again and confirms everything is still in good shape.

@noahfalknoahfalk assigned karelz and akoeplinger and unassigned noahfalk and karelzAug 8, 2022
@filipnavara

filipnavara commented Aug 9, 2022

Copy link
Copy Markdown
Member

Some of the pipelines unfortunately failed on the dotnet-install.sh script where HTML was received from the server instead of expected binary data...

@noahfalknoahfalk assigned karelz and unassigned akoeplingerAug 9, 2022
@akoeplinger

akoeplinger commented Aug 9, 2022

Copy link
Copy Markdown
Member

I retried the failing jobs, let's see.

@hoyosjshoyosjs linked an issue Aug 9, 2022 that may be closed by this pull request
GC/API/GC/GetGCMemoryInfo/GetGCMemoryInfo.sh test failing intermittently on CoreCLR Linux ARM32 #73247
Closed
@hoyosjs

hoyosjs commented Aug 9, 2022

Copy link
Copy Markdown
Member

The Android JIT.Directed failures are tracked in #73539

@hoyosjs
hoyosjs merged commit d0aa175 into dotnet:mainAug 9, 2022
@karelzkarelz mentioned this pull request Aug 10, 2022
Closed
@karelz

karelz commented Aug 10, 2022

Copy link
Copy Markdown
Member

@noahfalk sorry for late response, I didn't notice it until now.
I was a bit lost what reverted what and fixed what -- I updated the top post.

@ghostghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@karelzkarelz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GC/API/GC/GetGCMemoryInfo/GetGCMemoryInfo.sh test failing intermittently on CoreCLR Linux ARM32

6 participants

@noahfalk@filipnavara@akoeplinger@hoyosjs@karelz@kunalspathak