') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix ABI for Int128 by davidwrighton · Pull Request #73601 · dotnet/runtime · GitHub
Skip to content

Fix ABI for Int128 - #73601

Closed
davidwrighton wants to merge 12 commits into
dotnet:mainfrom
davidwrighton:fix_72206
Closed

Fix ABI for Int128#73601
davidwrighton wants to merge 12 commits into
dotnet:mainfrom
davidwrighton:fix_72206

Conversation

@davidwrighton

@davidwrightondavidwrighton commented Aug 9, 2022•
edited
Loading

Copy link
Copy Markdown
Member
  • Add ABI tests for Int128 covering interesting scenarios

Fixes#72206
(This is WIP as this first PR run is intended only to find out what problems actually exist on our various systems, following that, I will actually write the fix.)

@runfoapprunfoappBot mentioned this pull request Aug 9, 2022
Closed
MichalPetryka
MichalPetryka reviewed Aug 9, 2022
View reviewed changes
Comment threadsrc/tests/Interop/PInvoke/Int128/Int128Native.cpp

struct StructWithInt128
{
int64_t messUpPadding;

@MichalPetrykaMichalPetrykaAug 9, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use int8_t to better validate 32bit platforms that expect 4 byte alignment instead of 8/16 ones?

@davidwrightondavidwrightonAug 9, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't matter too much. The way alignment works in the various architectures we support/are likely to support, there won't be a meaningful difference. However, this is altogether messy enough that we may simply remove the ability to pass Int128 across the p/invoke boundary.

@tannergoodingtannergoodingAug 9, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that while blocking this is fine for .NET 7 given the short timeframe and that its currently busted. This won't be viable longer term. Int128 is an ABI primitive and much like Vector128<T> needs to eventually be supported.

davidwrightonand others added 11 commits August 10, 2022 14:03
@davidwrighton
New test
74935a1
@davidwrighton
Fix auto layout algorithm to compute structure alignment correctly
be730bc
- In particular:
1. The alignment requirement imposed by of a non-primitive, non-enum valuetype field is the alignment of that field
2. The alignment requirement imposed by a primitive is the pointer size of the target platform, unless running on Arm32, in which case if the primitive or enum is 8 bytes in size, the alignment requirement is 8.
- The previous implementation produced an alignment of pointer size, unless running on Arm32 and one of the fields had an alignment requirement of 8 (in which case the alignment requirement computed for the structure would be 8)
In addition, add a test which verifies that the instance field layout test types are actually producing R2R compatible results at runtime.
- This test shows that we have some issues around explicit layout, so I was forced to disable that portion of the test for now.
Fixesdotnet#65281
@davidwrighton
Re-enable disabled test
e599574
@davidwrighton
Remove file that shouldn't be added as part of the new test
3ef8ee4
@trylek
Make a few test types public to silence unassigned field errors
0cdf40b
@davidwrighton
Merge branch 'fix_65281' of github.com:davidwrighton/runtime into fix…
ebb920c
…_65281
@davidwrighton
Update comments and add more testing
174590f
@davidwrighton
Merge branch 'main' of github.com:dotnet/runtime into fix_72206
fe87927
@davidwrighton
First stab at support for proper 128bit integer layout and abi
ffda43d
@davidwrighton
Merge branch 'fix_72206' of github.com:davidwrighton/runtime into fix…
dbc3c0b
…_72206
@davidwrighton
Fix bugs so that at least Windows Arm64 works
d675132
@davidwrightondavidwrighton mentioned this pull request Aug 19, 2022
Open
@davidwrighton

davidwrighton commented Aug 19, 2022

Copy link
Copy Markdown
MemberAuthor

Closing, as this PR isn't really ready for checkin any time soon.

@ghostghost locked as resolved and limited conversation to collaborators Sep 18, 2022
@davidwrighton
davidwrighton deleted the fix_72206 branch April 13, 2023 18:53
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding left review comments
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky will be requested when the pull request is marked ready for reviewMichalStrehovsky is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review
+1 more reviewer
@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@davidwrightondavidwrighton

Labels

area-Interop-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[U]Int128 alignment handling is in the wrong place

4 participants

@davidwrighton@tannergooding@MichalPetryka@trylek