Skip to content

Fix component model aot test - #73734

Merged
LakshanF merged 7 commits into
dotnet:mainfrom
LakshanF:FixComponentModelAotTest
Aug 12, 2022
Merged

Fix component model aot test#73734
LakshanF merged 7 commits into
dotnet:mainfrom
LakshanF:FixComponentModelAotTest

Conversation

@LakshanF

@LakshanFLakshanF commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

Added some requires types to an rd.xml files, disabled some Jit tests and #73605 fixed some additional tests

@ghostghost assigned LakshanFAug 10, 2022
@LakshanF

LakshanF commented Aug 10, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 10, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky
MichalStrehovsky reviewed Aug 11, 2022
View reviewed changes
Comment threadsrc/libraries/System.ComponentModel.TypeConverter/tests/TypeDescriptorTests.cs Outdated
Comment threadsrc/libraries/System.ComponentModel.TypeConverter/tests/InstallerTypeAttributeTests.cs Outdated
Comment threadsrc/libraries/System.ComponentModel.TypeConverter/tests/BindableAttributeTests.cs Outdated
Comment threadsrc/libraries/System.ComponentModel.TypeConverter/tests/default.rd.xml Outdated

@MichalStrehovskyMichalStrehovskyAug 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little bit worried that such broadly applied RD.XML will hide product issues. But also I don't know how much of TypeConverter actually is compatible with trimming and whether it even makes sense to guard trim safety.

Just thought to write down what I think.

@LakshanFLakshanFAug 11, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled 7 test scenarios, all in XTypeDescriptionProviderTests, to get rid of the rd.xml dependency.

@LakshanF
LakshanFforce-pushed the FixComponentModelAotTest branch from cea1e6f to 72ec834CompareAugust 11, 2022 14:22
@LakshanF

LakshanF commented Aug 11, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 11, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovskyMichalStrehovsky mentioned this pull request Aug 12, 2022
Merged
MichalStrehovsky
MichalStrehovsky approved these changes Aug 12, 2022
View reviewed changes

@MichalStrehovskyMichalStrehovsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment threadsrc/libraries/System.ComponentModel.TypeConverter/tests/BindableAttributeTests.cs Outdated
Comment threadsrc/libraries/tests.proj Outdated
LakshanFand others added 2 commits August 12, 2022 04:27
@LakshanF@MichalStrehovsky
Update src/libraries/System.ComponentModel.TypeConverter/tests/Bindab…
67d7c9c
…leAttributeTests.cs
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@LakshanF@MichalStrehovsky
Update src/libraries/tests.proj
a446d9f
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@runfoapprunfoappBot mentioned this pull request Aug 12, 2022
Closed
@LakshanF
LakshanF merged commit b14a213 into dotnet:mainAug 12, 2022
@LakshanF
LakshanF deleted the FixComponentModelAotTest branch August 12, 2022 18:44
@LakshanFLakshanF mentioned this pull request Aug 13, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovskyMichalStrehovskyMichalStrehovsky approved these changes

Assignees

@LakshanFLakshanF

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LakshanF@MichalStrehovsky