Uh oh!
There was an error while loading. Please reload this page.
Avoid unused NetEventSource code - #73868
Merged
Merged
Conversation
ghost
commented
Aug 12, 2022
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #54859
Release assembly sizes: Windows (-10 KB):
Linux:
|
MihaZupan
commented
Aug 12, 2022
MemberAuthor
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MihaZupanforce-pushed
the
eventsource-size-cleanup
branch
from
August 12, 2022 22:54
c14831e to
d38203fCompareMihaZupan
marked this pull request as ready for review
August 14, 2022 18:34
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
CarnaViire
commented
Aug 15, 2022
Member
Will you update the PR soon @MihaZupan ? 😄 |
MemberAuthor
Yes, just waiting for VS to update :) Soon™️ |
MihaZupan
commented
Aug 15, 2022
MemberAuthor
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MemberAuthor
Restarting CI after #73962 Regular CI was already clean. I see no networking outerloop failures now. |
MihaZupan
commented
Aug 15, 2022
MemberAuthor
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#54859
NetEventSource.Common.csfrom the aspnetcore shared folder - completely unusedAssociateandDumpBuffermethods into separate partial files that are optionally included by projects that actually use themNetEventSource.Commonwhere possible (e.g. only used by a single project)IsEnabledchecksRelease assembly sizes:
Windows (-10 KB):
Linux: (-3.5 KB)