') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Warn if runtimeconfig.template.json is used with PublishAot by MichalStrehovsky · Pull Request #73996 · dotnet/runtime · GitHub
Skip to content

Warn if runtimeconfig.template.json is used with PublishAot - #73996

Merged
MichalStrehovsky merged 2 commits into
mainfrom
MichalStrehovsky-patch-4
Aug 16, 2022
Merged

Warn if runtimeconfig.template.json is used with PublishAot#73996
MichalStrehovsky merged 2 commits into
mainfrom
MichalStrehovsky-patch-4

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Aug 16, 2022

Copy link
Copy Markdown
Member

Fixes#72310.

Cc @dotnet/ilc-contrib

jkotas
jkotas reviewed Aug 16, 2022
View reviewed changes
Comment threadsrc/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets Outdated
@MichalStrehovsky@jkotas
Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Nativ…
0a3afc5
…e.Publish.targets
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@MichalStrehovsky

MichalStrehovsky commented Aug 16, 2022

Copy link
Copy Markdown
MemberAuthor

Relevant pipelines are green.

@MichalStrehovsky
MichalStrehovsky merged commit adc2b68 into mainAug 16, 2022
@MichalStrehovsky
MichalStrehovsky deleted the MichalStrehovsky-patch-4 branch August 16, 2022 12:16
@carlossanlop

carlossanlop commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

@MichalStrehovsky@jkotas is it ok to have this change in 7.0? Since we had to delay the snap for a full day, this commit will end up getting included in the RC1 snap. Letting you know in case you want to do something about it.

@MichalStrehovsky

MichalStrehovsky commented Aug 17, 2022

Copy link
Copy Markdown
MemberAuthor

@MichalStrehovsky@jkotas is it ok to have this change in 7.0? Since we had to delay the snap for a full day, this commit will end up getting included in the RC1 snap. Letting you know in case you want to do something about it.

Yes, all my PRs from yesterday were taking advantage of the moved deadline. I've fixed several papercut-level issues that I'm happy to see fixed for 7.0.

@MichalStrehovskyMichalStrehovsky mentioned this pull request Aug 18, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

runtimeconfig.template support

3 participants

@MichalStrehovsky@carlossanlop@jkotas