Skip to content

perf pipeline: Switch to node 14.x - #74017

Merged
radical merged 7 commits into
dotnet:mainfrom
radical:fix-perf-node
Aug 17, 2022
Merged

perf pipeline: Switch to node 14.x#74017
radical merged 7 commits into
dotnet:mainfrom
radical:fix-perf-node

Conversation

@radical

@radicalradical commented Aug 16, 2022

Copy link
Copy Markdown
Member
  • Switch to node 14.x instead of 18.x, because the latter doesn't seem
    to be compatible with ubuntu 18.x:
    node: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.28' not found (required by node)`

  • remove the existing nodejs package before installing a new
    one, because these machines are shared, and would get affected by
    installations performed by other runs.

  • Fix the case where pre-requisites would fail to install, but then helix would exit with exit code 0, and it would "look" as if everything went fine. This was happening because we set _commandExitCode=1, but helix sets this itself based on $?. So, to fix this we exit with (exit 1), and helix should be able to pick that up, thus causing the whole job to fail, as expected

  • Install node, and jsvu only for the wasm jobs, as they are not needed by others

- Switch to node 14.x instead of 18.x, because the latter doesn't seem
to be compatible with ubuntu 18.x:
`node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)`
- Also, remove the existing `nodejs` package before installing a new
one, because these machines are shared, and would get affected by
installations performed by other runs.
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Switch to node 14.x instead of 18.x, because the latter doesn't seem
    to be compatible with ubuntu 18.x:
    node: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.28' not found (required by node)`

  • Also, remove the existing nodejs package before installing a new
    one, because these machines are shared, and would get affected by
    installations performed by other runs.

Author:radical
Assignees:-
Labels:

arch-wasm, area-Infrastructure-mono

Milestone:-

@radical

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm-perf

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm-perf

Comment threadeng/pipelines/coreclr/templates/run-performance-job.yml
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines failed to run 1 pipeline(s).

@radical

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm-perf

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This allows cases which don't care about this, to continue working,
because they won't set `$PERF_PREREQS_INSTALL_FAILED`, and default to
continuing with the job.
@radical

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm-perf

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm-perf

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

Copy link
Copy Markdown
MemberAuthor

@DrewScoggins I have a run from this in dotnet-runtime-perf - 20220817.1 . Does that look good? There are some failures on the wasm jobs, but those are related to recent ILLinker changes. I'll fix those.
The other jobs seem to be running too, but I checked only with some random sampling.

Comment threadeng/testing/performance/microbenchmarks.proj Outdated
@DrewScoggins

Copy link
Copy Markdown
Member

Just the one other comment, other than that LGTM.

Comment threadeng/testing/performance/microbenchmarks.proj Outdated
@radical

Copy link
Copy Markdown
MemberAuthor

Opened dotnet/performance#2563, and #74104 for the new failures.

@radical

Copy link
Copy Markdown
MemberAuthor

And #74088 .

Any objections to merging this right away to unblock the pipeline, since the changes are strictly in performance only files?

@radical
radical merged commit a250bfe into dotnet:mainAug 17, 2022
@radical
radical deleted the fix-perf-node branch August 17, 2022 18:09
@radical

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0-rc1

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2877411794

@ghostghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@radical@DrewScoggins