Uh oh!
There was an error while loading. Please reload this page.
[Ppc64le] bug fixes - #74131
Conversation
…/runtime into ppc64le_bug_fixes
ghost
commented
Aug 18, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
carlossanlop
commented
Aug 18, 2022
@alhad-deshpande RC1 changes need a fix in main first. Was this done already? If not, please close this PR, send a PR to main first, then you can backport it with the help of the bot (ping me and I can help you). |
Oh I see the @akoeplinger@lewing can you please manually review this PR, since it's not a direct backport? |
carlossanlop
commented
Aug 18, 2022
There were failures in |
akoeplinger
commented
Aug 18, 2022
The failures are unrelated. |
carlossanlop
commented
Aug 18, 2022
Thanks for the sign-off @akoeplinger. Now I just need approval from @lewing. I am pausing merges right now, in favor of getting the 7-rc1->7 PR merged without any more changes (the bot autocommits anything merged to rc1, and restarts the CI). |
carlossanlop
commented
Aug 19, 2022
The 7.0-rc1 -> 7.0 PR was merged, so now we're unblocked to merge this. |
@carlossanlop@lewing@akoeplinger The PR 73616 was for memory thunking and those changes are already there in RC1 branch. Can you please merge PR 74058 into main so that RC1 branch is not ahead of main? |
akoeplinger
commented
Aug 19, 2022
@alhad-deshpande I merged #74058, thanks! |
alhad-deshpande
commented
Aug 24, 2022
@rzikm@akoeplinger |
akoeplinger
commented
Aug 24, 2022
@alhad-deshpande yeah it was inadvertently mentioned in the PR description of that PR, no worries. |
alhad-deshpande
commented
Aug 24, 2022
@akoeplinger |
Yes, I mistakenly created the PR against different base and it tagged lots of people for review and lots of PRs 🤦 |
This PR fixes below things: