Skip to content

[wasm] Reduce allocation when options are passed to fetch - #74142

Merged
maraf merged 1 commit into
dotnet:mainfrom
maraf:WasmHttpReduceAllocations
Aug 19, 2022
Merged

[wasm] Reduce allocation when options are passed to fetch#74142
maraf merged 1 commit into
dotnet:mainfrom
maraf:WasmHttpReduceAllocations

Conversation

@maraf

Copy link
Copy Markdown
Member

We can skip creating a list of options and than converting to array, because we can calculate in advance number of options being used in the HTTP call.

Note: The same doesn't apply for headers, because we don't know number of values for each header.

@marafmaraf added arch-wasm WebAssembly architecture area-System.Net.Http labels Aug 18, 2022
@marafmaraf self-assigned this Aug 18, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

We can skip creating a list of options and than converting to array, because we can calculate in advance number of options being used in the HTTP call.

Note: The same doesn't apply for headers, because we don't know number of values for each header.

Author:maraf
Assignees:maraf
Labels:

arch-wasm, area-System.Net.Http

Milestone:-

@maraf

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@maraf
maraf merged commit a820ee3 into dotnet:mainAug 19, 2022
@maraf
maraf deleted the WasmHttpReduceAllocations branch August 19, 2022 09:34
@maraf

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0-rc1

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2888490989

@karelzkarelz added this to the 8.0.0 milestone Aug 22, 2022
@ghostghost locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-System.Net.Http

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@maraf@pavelsavara@karelz