Skip to content

[wasm] Use new javascript API in tests and samples - #74153

Merged
maraf merged 6 commits into
dotnet:mainfrom
maraf:WasmJsApiPart2
Aug 22, 2022
Merged

[wasm] Use new javascript API in tests and samples#74153
maraf merged 6 commits into
dotnet:mainfrom
maraf:WasmJsApiPart2

Conversation

@maraf

@marafmaraf commented Aug 18, 2022•
edited by pavelsavara
Loading

Copy link
Copy Markdown
Member
  • Replace createDotnetRuntime with new dotnet builder API in sapmles and tests.
  • Add guard in withApplicationArgumentsFromQuery for window object.

Contributes to #72990

@marafmaraf added arch-wasm WebAssembly architecture area-Build-mono labels Aug 18, 2022
@marafmaraf self-assigned this Aug 18, 2022
@ghost

ghost commented Aug 18, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Replace createDotnetRuntime with new dotnet builder API in sapmles and tests.
  • Add guard in withApplicationArgumentsFromQuery for window object.
Author:maraf
Assignees:maraf
Labels:

arch-wasm, area-Build-mono

Milestone:-

@maraf

maraf commented Aug 18, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Aug 18, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara
pavelsavara reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/mono/sample/wasm/browser-bench/frame-main.js Outdated
pavelsavara
pavelsavara reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/mono/sample/wasm/browser-bench/main.js Outdated
pavelsavara
pavelsavara reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/mono/sample/wasm/browser-nextjs/components/deepThought.js
pavelsavara
pavelsavara reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/mono/sample/wasm/browser-nextjs/components/deepThought.js Outdated
pavelsavara
pavelsavara reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/mono/sample/wasm/browser-profile/README.md Outdated
pavelsavara
pavelsavara reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/mono/sample/wasm/browser-profile/main.js Outdated
pavelsavara
pavelsavara reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/mono/sample/wasm/browser-threads/main.js
pavelsavara
pavelsavara reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/mono/sample/wasm/browser/main.js
pavelsavara
pavelsavara reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/mono/sample/wasm/console-node-ts/main.ts Outdated
pavelsavara
pavelsavara reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/tests/FunctionalTests/WebAssembly/Browser/HotReload/main.js Outdated
@marafmaraf changed the title [wasm] Use mew javascript API in tests and samples[wasm] Use new javascript API in tests and samplesAug 18, 2022
@maraf

maraf commented Aug 19, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Aug 19, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@maraf
maraf merged commit 8cf96d9 into dotnet:mainAug 22, 2022
@maraf
maraf deleted the WasmJsApiPart2 branch August 22, 2022 14:47
@ghostghost locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@marafmaraf

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maraf@pavelsavara