Skip to content

Omit the JS sync context if threads are not enabled - #74167

Merged
kg merged 2 commits into
dotnet:mainfrom
kg:wasm-sync-context-linking
Aug 19, 2022
Merged

Omit the JS sync context if threads are not enabled#74167
kg merged 2 commits into
dotnet:mainfrom
kg:wasm-sync-context-linking

Conversation

@kg

@kgkg commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@kgkg added the arch-wasm WebAssembly architecture label Aug 18, 2022
@ghostghost assigned kgAug 18, 2022
@kg
kg requested a review from lambdageekAugust 18, 2022 18:35
@ghost

ghost commented Aug 18, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:kg
Assignees:-
Labels:

arch-wasm

Milestone:-

lambdageek
lambdageek reviewed Aug 18, 2022
View reviewed changes

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think FEATURE_WASM_THREADS is defined for non-CoreLib libraries by default - it's something we added by hand to the .csproj

also in .ts we can add some constant folding to encourage rollup to drop all the conditionals

Comment thread...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Comment threadsrc/mono/wasm/runtime/managed-exports.ts
@lewinglewing added this to the 7.0.0 milestone Aug 19, 2022
@lambdageek

lambdageek commented Aug 19, 2022

Copy link
Copy Markdown
Member

/azp backport to release/7.0-rc1

@azure-pipelines

azure-pipelinesBot commented Aug 19, 2022

Copy link
Copy Markdown
Command 'backport' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@maraf

maraf commented Aug 19, 2022

Copy link
Copy Markdown
Member

/backport to release/7.0-rc1

@github-actions

github-actionsBot commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2889118587

@github-actionsgithub-actionsBot mentioned this pull request Aug 19, 2022
Merged
@kg

kg commented Aug 19, 2022

Copy link
Copy Markdown
ContributorAuthor

Verified that the threads sample works correctly now with @lambdageek's msbuild fix (thanks!)

@kg
kg merged commit 801ca3d into dotnet:mainAug 19, 2022
@ghostghost locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@kgkg

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@kg@lambdageek@maraf@lewing