Skip to content

Disable ConnectWithRevocation_WithCallback test - #74168

Merged
rzikm merged 2 commits into
dotnet:mainfrom
rzikm:74034-disable-test
Aug 22, 2022
Merged

Disable ConnectWithRevocation_WithCallback test#74168
rzikm merged 2 commits into
dotnet:mainfrom
rzikm:74034-disable-test

Conversation

@rzikm

@rzikmrzikm commented Aug 18, 2022

Copy link
Copy Markdown
Member

Contributes to #74034.

@ghostghost assigned rzikmAug 18, 2022
@ghost

ghost commented Aug 18, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #74034.

Author:rzikm
Assignees:-
Labels:

area-System.Net.Security

Milestone:-

@rzikm
rzikm requested a review from a teamAugust 18, 2022 18:55
CarnaViire
CarnaViire approved these changes Aug 18, 2022
View reviewed changes

@CarnaViireCarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

CarnaViire
CarnaViire requested changes Aug 18, 2022
View reviewed changes

@CarnaViireCarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note Jeremy's comment on the issue:

I only see the failures occurring on OSX, so it should only be disabled on OSX, not all Unixes. (The Linuxes are passing stably)

@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 18, 2022
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 21, 2022
@danmoseley

danmoseley commented Aug 21, 2022

Copy link
Copy Markdown
Contributor

I edited to OSX so validation could rerun. note that doesn't include iOS and tvOS, not sure whether those are relevant.

@danmoseley

danmoseley commented Aug 21, 2022

Copy link
Copy Markdown
Contributor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Aug 21, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rzikm

rzikm commented Aug 22, 2022

Copy link
Copy Markdown
MemberAuthor

I edited to OSX so validation could rerun. note that doesn't include iOS and tvOS, not sure whether those are relevant.

I am not aware of any failures on those, so it either works there or is disabled by some other means.

@rzikm

rzikm commented Aug 22, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime

@rzikm

rzikm commented Aug 22, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Aug 22, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

azure-pipelinesBot commented Aug 22, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
rzikm requested a review from CarnaViireAugust 22, 2022 10:03
@rzikm

rzikm commented Aug 22, 2022

Copy link
Copy Markdown
MemberAuthor

CI failures are weird, but build succeeded and the test itself is actually not outerloop so any failures are not result of this change.

@rzikm
rzikm merged commit bd7e60a into dotnet:mainAug 22, 2022
@karelzkarelz added this to the 8.0.0 milestone Aug 23, 2022
@karelzkarelz mentioned this pull request Aug 24, 2022
Closed
@rzikm

rzikm commented Aug 24, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

github-actionsBot commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2917382995

@github-actionsgithub-actionsBot mentioned this pull request Aug 24, 2022
Merged
@karelzkarelz mentioned this pull request Aug 25, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@CarnaViireCarnaViireCarnaViire approved these changes
+1 more reviewer
@danmoseleydanmoseleydanmoseley left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@rzikmrzikm

Labels

area-System.Net.Security

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rzikm@danmoseley@CarnaViire@karelz