Skip to content

Clean up EH routines - #74270

Merged
AntonLapounov merged 2 commits into
dotnet:mainfrom
AntonLapounov:CleanUpEHRoutines
Aug 20, 2022
Merged

Clean up EH routines#74270
AntonLapounov merged 2 commits into
dotnet:mainfrom
AntonLapounov:CleanUpEHRoutines

Conversation

@AntonLapounov

@AntonLapounovAntonLapounov commented Aug 19, 2022

Copy link
Copy Markdown
Contributor
  • Use the standard name and type for the second argument of exception handler routines: ULONG… MemoryStackFp -> PVOID pEstablisherFrame.
  • Remove the unused pOriginalContext argument of the FixupDispatcherContext function — it was needed for Itanium only.
  • Remove the unused pEstablisherFrame and pThread arguments of the HandleManagedFault function — only ShouldHandleManagedFault needs them. For now, pretend HandleManagedFault can still return to the caller.
  • Fix comments.

@ghostghost added the area-ExceptionHandling-coreclr only use for closed issues label Aug 19, 2022
janvorli
janvorli approved these changes Aug 19, 2022
View reviewed changes

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

noahfalk
noahfalk approved these changes Aug 19, 2022
View reviewed changes

@noahfalknoahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahfalk

noahfalk commented Aug 19, 2022

Copy link
Copy Markdown
Member

cc @hoyosjs@mikelle-rogers@mikem8361

@AntonLapounov
AntonLapounov merged commit bb2f8e5 into dotnet:mainAug 20, 2022
@AntonLapounov
AntonLapounov deleted the CleanUpEHRoutines branch August 20, 2022 06:00
@janvorlijanvorli mentioned this pull request Aug 25, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalknoahfalknoahfalk approved these changes
@janvorlijanvorlijanvorli approved these changes

Assignees

@AntonLapounovAntonLapounov

Labels

area-ExceptionHandling-coreclronly use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AntonLapounov@noahfalk@janvorli