Uh oh!
There was an error while loading. Please reload this page.
Change signature for diagnostic binaries - #74322
Merged
Merged
Conversation
Add signing with special signature to DAC and DBI.
ghost
commented
Aug 22, 2022
Tagging subscribers to this area: @tommcdon Issue Details
Use a signing infrastructure orthogonal to microbuild to use other certs for diagnostic binaries. cc: @dotnet/dotnet-diag @leculver
|
MemberAuthor
hoyosjsforce-pushed
the
juhoyosa/dac-signing-rc1
branch
from
August 22, 2022 07:18
975ec67 to
ab5bf51Comparehoyosjs
commented
Aug 22, 2022
MemberAuthor
/backport to release/7.0-rc1 |
Contributor
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2901995280 |
hoyosjs
commented
Aug 22, 2022
MemberAuthor
Failure is #73688 |
noahfalk
approved these changes
Aug 22, 2022
noahfalk
left a comment
Member
There was a problem hiding this comment.
LGTM
I'm not an expert with these build files, but it all looked reasonable. I assume we'll be manually validating after the build that the binaries got signed appropriately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a signing infrastructure orthogonal to microbuild to use other certs for diagnostic binaries.
cc: @dotnet/dotnet-diag @leculver