Fix write barriers in NativeAOT

[AntonLapounov]

For ARM64, use unsigned address comparisons in write barriers. In the INSERT_CHECKED_WRITE_BARRIER_CORE macro use the ccmp instruction to optimize for the case when the destination belongs to the heap.

For all architectures, make sure to exclude the g_GCShadowEnd, g_ephemeral_high, and g_highest_address upper bounds in the corresponding range checks. That is the current behavior on x64 except for g_GCShadowEnd.

Fixes#72645.

[VSadov]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[VSadov]

I am running a scenario that used to fail ~50% with this fix and there are no failures after 10 iterations. This issue was definitely responsible for most failures.

[mangod9]

so looks like this fix is specific for NativeAOT, but vanilla crossgen2 arm64 failures need further investigation?

[VSadov]

Sadly there were still quite a few failures when i left it run overnight. About 30 core dumps out of 108 rebuilds.
I think this fix helped, but there is something else.

[VSadov]

LGTM. Thanks!!

[VSadov]

so looks like this fix is specific for NativeAOT, but vanilla crossgen2 arm64 failures need further investigation?

yes, this change would have no effect on CoreCLR

[AntonLapounov]

/backport to release/7.0-rc1

[github-actions]

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2906418073

[github-actions]

@AntonLapounov backporting to release/7.0-rc1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[AntonLapounov]

About 30 core dumps out of 108 rebuilds.

Did you use Michal's repro or a different one?

[VSadov]

Did you use #72645 (comment) or a different one?

no, I just build a subset or coreclr in a loop, which uses the currently built crossgen2 to build other stuff.

[AntonLapounov]

/backport to release/7.0

[github-actions]

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2914545828