Skip to content

Enable Console Logging test in NativeAOT - #74381

Merged
eerhardt merged 2 commits into
dotnet:mainfrom
eerhardt:EnableConsoleTest
Aug 26, 2022
Merged

Enable Console Logging test in NativeAOT#74381
eerhardt merged 2 commits into
dotnet:mainfrom
eerhardt:EnableConsoleTest

Conversation

@eerhardt

@eerhardteerhardt commented Aug 22, 2022

Copy link
Copy Markdown
Member

Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled appears to be passing for me in NativeAOT on both Windows and Linux.

Contributes to #73436

@eerhardt
Enable Console Logging test in NativeAOT
090f52f
Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled appears to be passing for me in NativeAOT on both Windows and Linux.
Contributes to dotnet#73436
@ghost

ghost commented Aug 22, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Log_WritingScopes_LogsWithCorrectColorsWhenColorEnabled appears to be passing for me in NativeAOT on both Windows and Linux.

Contributes to #73436

Author:eerhardt
Assignees:-
Labels:

area-Extensions-Logging

Milestone:-

@ghostghost assigned eerhardtAug 22, 2022
@eerhardt

eerhardt commented Aug 22, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 22, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt

eerhardt commented Aug 23, 2022

Copy link
Copy Markdown
MemberAuthor

@MichalStrehovsky@LakshanF - how do I tell if the test in question ran? I don't see it failing on any legs, but I'm also not sure it passed on all the NativeAOT legs either.

@MichalStrehovskyMichalStrehovsky mentioned this pull request Aug 23, 2022
Closed
@MichalStrehovsky

MichalStrehovsky commented Aug 23, 2022

Copy link
Copy Markdown
Member

@MichalStrehovsky@LakshanF - how do I tell if the test in question ran? I don't see it failing on any legs, but I'm also not sure it passed on all the NativeAOT legs either.

I think it's good. I spot checked one of the helix logs - https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-74381-merge-67c3cd974086489fa0/Microsoft.Extensions.Logging.Console.Tests/1/console.cb457c28.log?helixlogtype=result.

@eerhardt

eerhardt commented Aug 23, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Aug 23, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt
eerhardt merged commit 4937707 into dotnet:mainAug 26, 2022
@eerhardt
eerhardt deleted the EnableConsoleTest branch August 26, 2022 21:53
@ghostghost locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekghtarekghtarekgh approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky
+1 more reviewer
@LakshanFLakshanFLakshanF approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eerhardteerhardt

Labels

area-Extensions-Logging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eerhardt@MichalStrehovsky@LakshanF@tarekgh