Uh oh!
There was an error while loading. Please reload this page.
Fix issues found in recent Int128 ABI change - #74386
Merged
Merged
Conversation
tannergooding
approved these changes
Aug 22, 2022
jkoritzinsky
approved these changes
Aug 22, 2022
AaronRobinsonMSFT
approved these changes
Aug 22, 2022
akoeplinger
commented
Aug 23, 2022
Member
@davidwrighton I've seen this failing in 7.0-rc1 too, do you plan on backporting the fix? |
davidwrighton
commented
Aug 23, 2022
MemberAuthor
@akoeplinger I plan to fix this in 7.0, but not port to 7.0-rc1 unless there is some specific ask to do so. |
davidwrighton
commented
Aug 23, 2022
MemberAuthor
/backport to release/7.0 |
Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2914908267 |
akoeplinger
commented
Aug 23, 2022
Member
That's fine by me, I just saw it failing in 7.0-rc1 as part of Test Monitor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#74318