Skip to content

Expose JsonSerializer.IsReadOnly and MakeReadOnly() APIs. - #74431

Merged
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:jsonserializeroptions-lock
Aug 24, 2022
Merged

Expose JsonSerializer.IsReadOnly and MakeReadOnly() APIs.#74431
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:jsonserializeroptions-lock

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Aug 23, 2022

Copy link
Copy Markdown
Member

Fix#54482.

@ghost

ghost commented Aug 23, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eiriktsarpaliseiriktsarpalis added this to the 8.0.0 milestone Aug 23, 2022
@ghost

ghost commented Aug 23, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #54482.

Author:eiriktsarpalis
Assignees:-
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone:-

krwq
krwq approved these changes Aug 24, 2022
View reviewed changes

@krwqkrwq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some small comments - I'll only ask to change the docs to not use word indempotent remaining comments fix as you see fit

@eiriktsarpalis
eiriktsarpalis merged commit 4b14c92 into dotnet:mainAug 24, 2022
@eiriktsarpalis
eiriktsarpalis deleted the jsonserializeroptions-lock branch August 24, 2022 14:06
@ghostghost locked as resolved and limited conversation to collaborators Sep 23, 2022
@jeffhandleyjeffhandley added the blog-candidate Completed PRs that are candidate topics for blog post coverage label Mar 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krwqkrwqkrwq approved these changes
@layomialayomiaAwaiting requested review from layomia

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.Jsonblog-candidateCompleted PRs that are candidate topics for blog post coveragenew-api-needs-documentation

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Provide a public api to "lock" a JsonSerializerOptions

3 participants

@eiriktsarpalis@krwq@jeffhandley