Uh oh!
There was an error while loading. Please reload this page.
Implement proper File System detection for Apple OSes - #74493
Merged
Conversation
ghost
commented
Aug 24, 2022
Tagging subscribers to this area: @dotnet/area-system-io Issue Detailsfixes #69852 it's a draft until CI ensures me that my assumptions were right
|
lambdageek
commented
Aug 24, 2022
Member
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adamsitnik
marked this pull request as ready for review
August 24, 2022 22:09
jozkee
approved these changes
Aug 25, 2022
adamsitnik
commented
Aug 25, 2022
MemberAuthor
Perf LGTM: BenchmarkDotNet=v0.13.1.1823-nightly, OS=macOS Monterey 12.3.1 (21E258) [Darwin 21.4.0]
Intel Core i7-5557U CPU 3.10GHz (Broadwell), 1 CPU, 4 logical and 2 physical cores
.NET SDK=7.0.100-rc.2.22424.12
[Host] : .NET 7.0.0 (7.0.22.42212), X64 RyuJIT
Job-HMRXXT : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT
Job-EKKFRV : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT
LaunchCount=9
|
adamsitnik
commented
Aug 25, 2022
MemberAuthor
Failures are unrelated (#74170, helix deadletters for NativeAOT, timeouts) |
adamsitnik
commented
Aug 25, 2022
MemberAuthor
/backport to release/7.0 |
Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2925323033 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#69852
fixes#72786
it's a draft until CI ensures me that my assumptions were right