Uh oh!
There was an error while loading. Please reload this page.
[wasm][debugger] Fix chinese character in project name - #74516
Conversation
ghost
commented
Aug 24, 2022
Tagging subscribers to this area: @thaystg Issue DetailsThe test case does not simulate the real case from blazor, but I added it anyway. From blaze we receive from the loaded_files variable file names like this: In the debugger-tests in the mono-config.json, the file name is like this, we add and search with this name, so we don't need the UnescapeDataString.
|
| continue; | ||
| try | ||
| { | ||
| string decodedFileName = Uri.UnescapeDataString(file_name); |
There was a problem hiding this comment.
Without this we get an error on CI:
The command ""C:\Users\itomkowicz\source\repos\runtime-fork\.packages\microsoft.diasymreader.pdb2pdb\1.1.0-beta2-19575-01\tools\Pdb2Pdb.exe" "C:\Users\itomkowicz\source\repos\runtime-fork\artifacts\bin\debugger-test\Debug\wasm\debugger-test-special-char-in-path.dll" /out "C:\Users\itomkowicz\source\repos\runtime-fork\artifacts\SymStore\Debug\debugger-test-special-char-in-path\net6.0\x64\debugger-test-special-char-in-path.pdb" /srcsvrvar SRC_INDEX=public" exited with code -1.
There was a problem hiding this comment.
Any idea what would cause this? And details before that line?
There was a problem hiding this comment.
Pdb2Pdb.exe does not support special characteres in path, as far as I remember.
There was a problem hiding this comment.
Ok, we can add a comment for that here. And if there is any supporting link with more info, then add that.
radical
commented
Aug 24, 2022
Can we test this case against other ways of loading assemblies?
|
Renaming variable as suggested by @radical
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…h-ㄨ/debugger-test-chinese-char-in-path-ㄨ.csproj
thaystg
commented
Aug 29, 2022
@lewing Can I backport? |
thaystg
commented
Aug 30, 2022
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2957101497 |
The test case does not simulate the real case from blazor, but I added it anyway.
From blaze we receive from the loaded_files variable file names like this:
http://localhost:5168/_framework/%E3%84%A8U1U2U3.Shared.dll
Then we need to convert to: http://localhost:5168/_framework/ㄨU1U2U3.Shared.dll to find it in our assemblies by name.
In the debugger-tests in the mono-config.json, the file name is like this, we add and search with this name, so we don't need the UnescapeDataString.