Delete some unnecessary code - #74527

Merged
kunalspathak merged 3 commits into
dotnet:mainfrom
SingleAccretion:No-Obj-Folding
Sep 13, 2022
Merged

Delete some unnecessary code#74527
kunalspathak merged 3 commits into
dotnet:mainfrom
SingleAccretion:No-Obj-Folding

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Aug 24, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Three commits:

  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.

Diffs.

@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Aug 24, 2022
@ghost

ghost commented Aug 24, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Three commits:

  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Author:SingleAccretion
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@SingleAccretion
Remove "OBJ(LCL_VAR_ADDR)" folding from putarg lowering
3a9f933
This was originally put in place to allow the corresponding codegen
changes to be tested. Now that we have more than adequate coverage
from the front-end transformations, we can simply delete the code.
@SingleAccretion
Delete dead OBJ handling in BuildPutArgReg
146d259
We don't expect any OBJs here.
@SingleAccretion
SingleAccretion marked this pull request as ready for review August 25, 2022 14:03
@SingleAccretion

SingleAccretion commented Aug 25, 2022

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

@JulieLeeMSFTJulieLeeMSFT added this to the 8.0.0 milestone Aug 25, 2022
@AndyAyersMS

AndyAyersMS commented Sep 12, 2022

Copy link
Copy Markdown
Member

@kunalspathak can you review?

@kunalspathak

kunalspathak commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.

I am not much familiar with this code lately. Can you elaborate in PR comments why explicit simplification is not needed now?

@SingleAccretion

SingleAccretion commented Sep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Why is explicit simplification is not needed now?

Essentially, we are now folding this pattern in local morph, and so don't need the additional checks. Eventually, almost all such checks will be deleted from the codebase; this is a start.

SingleAccretion
SingleAccretion commented Sep 13, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/morphblock.cpp
{
if (m_dst->OperIs(GT_OBJ))
{
GenTreeLclVar* lclVar = m_comp->fgMorphTryFoldObjAsLclVar(m_dst->AsObj());

@SingleAccretionSingleAccretionSep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71584.

Comment threadsrc/coreclr/jit/lsrabuild.cpp

// First, handle the GT_OBJ case, which loads into the arg register
// (so we don't set the use to prefer that register for the source address).
if (op1->OperIs(GT_OBJ))

@SingleAccretionSingleAccretionSep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code.

Comment threadsrc/coreclr/jit/lowerxarch.cpp
#endif // !TARGET_X86
}

if (src->OperIs(GT_OBJ) && src->AsObj()->Addr()->OperIsLocalAddr())

@SingleAccretionSingleAccretionSep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #70960 and #70779.

Comment threadsrc/coreclr/jit/lowerarmarch.cpp
// STRUCT args (FIELD_LIST / OBJ / LCL_VAR / LCL_FLD) will always be contained.
MakeSrcContained(putArgNode, src);

// TODO-ADDR: always perform this transformation in local morph and delete this code.

@SingleAccretionSingleAccretionSep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71598 and #71328.

@kunalspathak

kunalspathak commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Great...thank you. I am not able to access the diff...what does it look like?

@SingleAccretion

SingleAccretion commented Sep 13, 2022

Copy link
Copy Markdown
ContributorAuthor

what does it look like?

There are no diffs outside of coreclr_tests. In tests, we have:

  1. On all non-ARM platforms: 4 minor regressions in tests that test Call(*(Struct*)&doubleVal);-like code.
  2. On ARM: couple large improvements because some huge structs now go down the OBJ(LCL_FLD_ADDR) path, which is more optimal for them (reversal of Support PUTARG_SPLIT(STRUCT LCL_VAR/LCL_FLD) on ARM/64 #70861 (comment), essentially).

kunalspathak
kunalspathak approved these changes Sep 13, 2022
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak
kunalspathak merged commit 2500b6e into dotnet:mainSep 13, 2022
@SingleAccretion
SingleAccretion deleted the No-Obj-Folding branch September 13, 2022 18:21
@ghostghost locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion@AndyAyersMS@kunalspathak@JulieLeeMSFT
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Delete some unnecessary code - #74527
Merged
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Sep 13, 2022
Merged
Delete some unnecessary code#74527
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Aug 24, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Diffs.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Aug 24, 2022
@ghost
ghost
commented
Aug 24, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@SingleAccretion
Remove "OBJ(LCL_VAR_ADDR)" folding from putarg lowering
3a9f933
This was originally put in place to allow the corresponding codegen
changes to be tested. Now that we have more than adequate coverage
from the front-end transformations, we can simply delete the code.
@SingleAccretion
Delete dead OBJ handling in BuildPutArgReg
146d259
We don't expect any OBJs here.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
August 25, 2022 14:03
@SingleAccretion
SingleAccretion
commented
Aug 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added this to the 8.0.0 milestone
Aug 25, 2022
@AndyAyersMS
AndyAyersMS
commented
Sep 12, 2022

Copy link


Copy Markdown

Member
@kunalspathak can you review?
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
I am not much familiar with this code lately. Can you elaborate in PR comments why explicit simplification is not needed now?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Why is explicit simplification is not needed now?
Essentially, we are now folding this pattern in local morph, and so don't need the additional checks. Eventually, almost all such checks will be deleted from the codebase; this is a start.
SingleAccretion
SingleAccretion
commented
Sep 13, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/morphblock.cpp
 {
 if (m_dst->OperIs(GT_OBJ))
 {
 GenTreeLclVar* lclVar = m_comp->fgMorphTryFoldObjAsLclVar(m_dst->AsObj());
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71584.
Comment threadsrc/coreclr/jit/lsrabuild.cpp

 // First, handle the GT_OBJ case, which loads into the arg register
 // (so we don't set the use to prefer that register for the source address).
 if (op1->OperIs(GT_OBJ))
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code.
Comment threadsrc/coreclr/jit/lowerxarch.cpp
#endif // !TARGET_X86
 }

 if (src->OperIs(GT_OBJ) && src->AsObj()->Addr()->OperIsLocalAddr())
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #70960 and #70779.
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
 // STRUCT args (FIELD_LIST / OBJ / LCL_VAR / LCL_FLD) will always be contained.
 MakeSrcContained(putArgNode, src);

 // TODO-ADDR: always perform this transformation in local morph and delete this code.
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71598 and #71328.
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
Great...thank you. I am not able to access the diff...what does it look like?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
what does it look like?
There are no diffs outside of coreclr_tests. In tests, we have:
  1. On all non-ARM platforms: 4 minor regressions in tests that test Call(*(Struct*)&doubleVal);-like code.
  2. On ARM: couple large improvements because some huge structs now go down the OBJ(LCL_FLD_ADDR) path, which is more optimal for them (reversal of Support PUTARG_SPLIT(STRUCT LCL_VAR/LCL_FLD) on ARM/64 #70861 (comment), essentially).
kunalspathak
kunalspathak
approved these changes
Sep 13, 2022
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kunalspathak
kunalspathak
merged commit 2500b6e
into
dotnet:mainSep 13, 2022
@SingleAccretion
SingleAccretion
deleted the

No-Obj-Folding

branch
September 13, 2022 18:21
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion@AndyAyersMS@kunalspathak@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete some unnecessary code - #74527
Merged
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Sep 13, 2022
Merged
Delete some unnecessary code#74527
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Aug 24, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Diffs.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Aug 24, 2022
@ghost
ghost
commented
Aug 24, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@SingleAccretion
Remove "OBJ(LCL_VAR_ADDR)" folding from putarg lowering
3a9f933
This was originally put in place to allow the corresponding codegen
changes to be tested. Now that we have more than adequate coverage
from the front-end transformations, we can simply delete the code.
@SingleAccretion
Delete dead OBJ handling in BuildPutArgReg
146d259
We don't expect any OBJs here.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
August 25, 2022 14:03
@SingleAccretion
SingleAccretion
commented
Aug 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added this to the 8.0.0 milestone
Aug 25, 2022
@AndyAyersMS
AndyAyersMS
commented
Sep 12, 2022

Copy link


Copy Markdown

Member
@kunalspathak can you review?
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
I am not much familiar with this code lately. Can you elaborate in PR comments why explicit simplification is not needed now?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Why is explicit simplification is not needed now?
Essentially, we are now folding this pattern in local morph, and so don't need the additional checks. Eventually, almost all such checks will be deleted from the codebase; this is a start.
SingleAccretion
SingleAccretion
commented
Sep 13, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/morphblock.cpp
 {
 if (m_dst->OperIs(GT_OBJ))
 {
 GenTreeLclVar* lclVar = m_comp->fgMorphTryFoldObjAsLclVar(m_dst->AsObj());
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71584.
Comment threadsrc/coreclr/jit/lsrabuild.cpp

 // First, handle the GT_OBJ case, which loads into the arg register
 // (so we don't set the use to prefer that register for the source address).
 if (op1->OperIs(GT_OBJ))
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code.
Comment threadsrc/coreclr/jit/lowerxarch.cpp
#endif // !TARGET_X86
 }

 if (src->OperIs(GT_OBJ) && src->AsObj()->Addr()->OperIsLocalAddr())
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #70960 and #70779.
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
 // STRUCT args (FIELD_LIST / OBJ / LCL_VAR / LCL_FLD) will always be contained.
 MakeSrcContained(putArgNode, src);

 // TODO-ADDR: always perform this transformation in local morph and delete this code.
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71598 and #71328.
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
Great...thank you. I am not able to access the diff...what does it look like?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
what does it look like?
There are no diffs outside of coreclr_tests. In tests, we have:
  1. On all non-ARM platforms: 4 minor regressions in tests that test Call(*(Struct*)&doubleVal);-like code.
  2. On ARM: couple large improvements because some huge structs now go down the OBJ(LCL_FLD_ADDR) path, which is more optimal for them (reversal of Support PUTARG_SPLIT(STRUCT LCL_VAR/LCL_FLD) on ARM/64 #70861 (comment), essentially).
kunalspathak
kunalspathak
approved these changes
Sep 13, 2022
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kunalspathak
kunalspathak
merged commit 2500b6e
into
dotnet:mainSep 13, 2022
@SingleAccretion
SingleAccretion
deleted the

No-Obj-Folding

branch
September 13, 2022 18:21
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion@AndyAyersMS@kunalspathak@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete some unnecessary code - #74527
Merged
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Sep 13, 2022
Merged
Delete some unnecessary code#74527
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Aug 24, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Diffs.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Aug 24, 2022
@ghost
ghost
commented
Aug 24, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@SingleAccretion
Remove "OBJ(LCL_VAR_ADDR)" folding from putarg lowering
3a9f933
This was originally put in place to allow the corresponding codegen
changes to be tested. Now that we have more than adequate coverage
from the front-end transformations, we can simply delete the code.
@SingleAccretion
Delete dead OBJ handling in BuildPutArgReg
146d259
We don't expect any OBJs here.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
August 25, 2022 14:03
@SingleAccretion
SingleAccretion
commented
Aug 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added this to the 8.0.0 milestone
Aug 25, 2022
@AndyAyersMS
AndyAyersMS
commented
Sep 12, 2022

Copy link


Copy Markdown

Member
@kunalspathak can you review?
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
I am not much familiar with this code lately. Can you elaborate in PR comments why explicit simplification is not needed now?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Why is explicit simplification is not needed now?
Essentially, we are now folding this pattern in local morph, and so don't need the additional checks. Eventually, almost all such checks will be deleted from the codebase; this is a start.
SingleAccretion
SingleAccretion
commented
Sep 13, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/morphblock.cpp
 {
 if (m_dst->OperIs(GT_OBJ))
 {
 GenTreeLclVar* lclVar = m_comp->fgMorphTryFoldObjAsLclVar(m_dst->AsObj());
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71584.
Comment threadsrc/coreclr/jit/lsrabuild.cpp

 // First, handle the GT_OBJ case, which loads into the arg register
 // (so we don't set the use to prefer that register for the source address).
 if (op1->OperIs(GT_OBJ))
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code.
Comment threadsrc/coreclr/jit/lowerxarch.cpp
#endif // !TARGET_X86
 }

 if (src->OperIs(GT_OBJ) && src->AsObj()->Addr()->OperIsLocalAddr())
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #70960 and #70779.
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
 // STRUCT args (FIELD_LIST / OBJ / LCL_VAR / LCL_FLD) will always be contained.
 MakeSrcContained(putArgNode, src);

 // TODO-ADDR: always perform this transformation in local morph and delete this code.
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71598 and #71328.
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
Great...thank you. I am not able to access the diff...what does it look like?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
what does it look like?
There are no diffs outside of coreclr_tests. In tests, we have:
  1. On all non-ARM platforms: 4 minor regressions in tests that test Call(*(Struct*)&doubleVal);-like code.
  2. On ARM: couple large improvements because some huge structs now go down the OBJ(LCL_FLD_ADDR) path, which is more optimal for them (reversal of Support PUTARG_SPLIT(STRUCT LCL_VAR/LCL_FLD) on ARM/64 #70861 (comment), essentially).
kunalspathak
kunalspathak
approved these changes
Sep 13, 2022
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kunalspathak
kunalspathak
merged commit 2500b6e
into
dotnet:mainSep 13, 2022
@SingleAccretion
SingleAccretion
deleted the

No-Obj-Folding

branch
September 13, 2022 18:21
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion@AndyAyersMS@kunalspathak@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Delete some unnecessary code - #74527
Merged
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Sep 13, 2022
Merged
Delete some unnecessary code#74527
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Aug 24, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Diffs.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Aug 24, 2022
@ghost
ghost
commented
Aug 24, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@SingleAccretion
Remove "OBJ(LCL_VAR_ADDR)" folding from putarg lowering
3a9f933
This was originally put in place to allow the corresponding codegen
changes to be tested. Now that we have more than adequate coverage
from the front-end transformations, we can simply delete the code.
@SingleAccretion
Delete dead OBJ handling in BuildPutArgReg
146d259
We don't expect any OBJs here.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
August 25, 2022 14:03
@SingleAccretion
SingleAccretion
commented
Aug 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added this to the 8.0.0 milestone
Aug 25, 2022
@AndyAyersMS
AndyAyersMS
commented
Sep 12, 2022

Copy link


Copy Markdown

Member
@kunalspathak can you review?
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
I am not much familiar with this code lately. Can you elaborate in PR comments why explicit simplification is not needed now?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Why is explicit simplification is not needed now?
Essentially, we are now folding this pattern in local morph, and so don't need the additional checks. Eventually, almost all such checks will be deleted from the codebase; this is a start.
SingleAccretion
SingleAccretion
commented
Sep 13, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/morphblock.cpp
 {
 if (m_dst->OperIs(GT_OBJ))
 {
 GenTreeLclVar* lclVar = m_comp->fgMorphTryFoldObjAsLclVar(m_dst->AsObj());
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71584.
Comment threadsrc/coreclr/jit/lsrabuild.cpp

 // First, handle the GT_OBJ case, which loads into the arg register
 // (so we don't set the use to prefer that register for the source address).
 if (op1->OperIs(GT_OBJ))
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code.
Comment threadsrc/coreclr/jit/lowerxarch.cpp
#endif // !TARGET_X86
 }

 if (src->OperIs(GT_OBJ) && src->AsObj()->Addr()->OperIsLocalAddr())
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #70960 and #70779.
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
 // STRUCT args (FIELD_LIST / OBJ / LCL_VAR / LCL_FLD) will always be contained.
 MakeSrcContained(putArgNode, src);

 // TODO-ADDR: always perform this transformation in local morph and delete this code.
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71598 and #71328.
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
Great...thank you. I am not able to access the diff...what does it look like?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
what does it look like?
There are no diffs outside of coreclr_tests. In tests, we have:
  1. On all non-ARM platforms: 4 minor regressions in tests that test Call(*(Struct*)&doubleVal);-like code.
  2. On ARM: couple large improvements because some huge structs now go down the OBJ(LCL_FLD_ADDR) path, which is more optimal for them (reversal of Support PUTARG_SPLIT(STRUCT LCL_VAR/LCL_FLD) on ARM/64 #70861 (comment), essentially).
kunalspathak
kunalspathak
approved these changes
Sep 13, 2022
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kunalspathak
kunalspathak
merged commit 2500b6e
into
dotnet:mainSep 13, 2022
@SingleAccretion
SingleAccretion
deleted the

No-Obj-Folding

branch
September 13, 2022 18:21
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion@AndyAyersMS@kunalspathak@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete some unnecessary code - #74527
Merged
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Sep 13, 2022
Merged
Delete some unnecessary code#74527
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Aug 24, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Diffs.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Aug 24, 2022
@ghost
ghost
commented
Aug 24, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@SingleAccretion
Remove "OBJ(LCL_VAR_ADDR)" folding from putarg lowering
3a9f933
This was originally put in place to allow the corresponding codegen
changes to be tested. Now that we have more than adequate coverage
from the front-end transformations, we can simply delete the code.
@SingleAccretion
Delete dead OBJ handling in BuildPutArgReg
146d259
We don't expect any OBJs here.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
August 25, 2022 14:03
@SingleAccretion
SingleAccretion
commented
Aug 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added this to the 8.0.0 milestone
Aug 25, 2022
@AndyAyersMS
AndyAyersMS
commented
Sep 12, 2022

Copy link


Copy Markdown

Member
@kunalspathak can you review?
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
I am not much familiar with this code lately. Can you elaborate in PR comments why explicit simplification is not needed now?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Why is explicit simplification is not needed now?
Essentially, we are now folding this pattern in local morph, and so don't need the additional checks. Eventually, almost all such checks will be deleted from the codebase; this is a start.
SingleAccretion
SingleAccretion
commented
Sep 13, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/morphblock.cpp
 {
 if (m_dst->OperIs(GT_OBJ))
 {
 GenTreeLclVar* lclVar = m_comp->fgMorphTryFoldObjAsLclVar(m_dst->AsObj());
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71584.
Comment threadsrc/coreclr/jit/lsrabuild.cpp

 // First, handle the GT_OBJ case, which loads into the arg register
 // (so we don't set the use to prefer that register for the source address).
 if (op1->OperIs(GT_OBJ))
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code.
Comment threadsrc/coreclr/jit/lowerxarch.cpp
#endif // !TARGET_X86
 }

 if (src->OperIs(GT_OBJ) && src->AsObj()->Addr()->OperIsLocalAddr())
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #70960 and #70779.
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
 // STRUCT args (FIELD_LIST / OBJ / LCL_VAR / LCL_FLD) will always be contained.
 MakeSrcContained(putArgNode, src);

 // TODO-ADDR: always perform this transformation in local morph and delete this code.
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71598 and #71328.
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
Great...thank you. I am not able to access the diff...what does it look like?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
what does it look like?
There are no diffs outside of coreclr_tests. In tests, we have:
  1. On all non-ARM platforms: 4 minor regressions in tests that test Call(*(Struct*)&doubleVal);-like code.
  2. On ARM: couple large improvements because some huge structs now go down the OBJ(LCL_FLD_ADDR) path, which is more optimal for them (reversal of Support PUTARG_SPLIT(STRUCT LCL_VAR/LCL_FLD) on ARM/64 #70861 (comment), essentially).
kunalspathak
kunalspathak
approved these changes
Sep 13, 2022
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kunalspathak
kunalspathak
merged commit 2500b6e
into
dotnet:mainSep 13, 2022
@SingleAccretion
SingleAccretion
deleted the

No-Obj-Folding

branch
September 13, 2022 18:21
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion@AndyAyersMS@kunalspathak@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete some unnecessary code - #74527
Merged
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Sep 13, 2022
Merged
Delete some unnecessary code#74527
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Aug 24, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Diffs.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Aug 24, 2022
@ghost
ghost
commented
Aug 24, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@SingleAccretion
Remove "OBJ(LCL_VAR_ADDR)" folding from putarg lowering
3a9f933
This was originally put in place to allow the corresponding codegen
changes to be tested. Now that we have more than adequate coverage
from the front-end transformations, we can simply delete the code.
@SingleAccretion
Delete dead OBJ handling in BuildPutArgReg
146d259
We don't expect any OBJs here.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
August 25, 2022 14:03
@SingleAccretion
SingleAccretion
commented
Aug 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added this to the 8.0.0 milestone
Aug 25, 2022
@AndyAyersMS
AndyAyersMS
commented
Sep 12, 2022

Copy link


Copy Markdown

Member
@kunalspathak can you review?
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
I am not much familiar with this code lately. Can you elaborate in PR comments why explicit simplification is not needed now?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Why is explicit simplification is not needed now?
Essentially, we are now folding this pattern in local morph, and so don't need the additional checks. Eventually, almost all such checks will be deleted from the codebase; this is a start.
SingleAccretion
SingleAccretion
commented
Sep 13, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/morphblock.cpp
 {
 if (m_dst->OperIs(GT_OBJ))
 {
 GenTreeLclVar* lclVar = m_comp->fgMorphTryFoldObjAsLclVar(m_dst->AsObj());
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71584.
Comment threadsrc/coreclr/jit/lsrabuild.cpp

 // First, handle the GT_OBJ case, which loads into the arg register
 // (so we don't set the use to prefer that register for the source address).
 if (op1->OperIs(GT_OBJ))
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code.
Comment threadsrc/coreclr/jit/lowerxarch.cpp
#endif // !TARGET_X86
 }

 if (src->OperIs(GT_OBJ) && src->AsObj()->Addr()->OperIsLocalAddr())
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #70960 and #70779.
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
 // STRUCT args (FIELD_LIST / OBJ / LCL_VAR / LCL_FLD) will always be contained.
 MakeSrcContained(putArgNode, src);

 // TODO-ADDR: always perform this transformation in local morph and delete this code.
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71598 and #71328.
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
Great...thank you. I am not able to access the diff...what does it look like?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
what does it look like?
There are no diffs outside of coreclr_tests. In tests, we have:
  1. On all non-ARM platforms: 4 minor regressions in tests that test Call(*(Struct*)&doubleVal);-like code.
  2. On ARM: couple large improvements because some huge structs now go down the OBJ(LCL_FLD_ADDR) path, which is more optimal for them (reversal of Support PUTARG_SPLIT(STRUCT LCL_VAR/LCL_FLD) on ARM/64 #70861 (comment), essentially).
kunalspathak
kunalspathak
approved these changes
Sep 13, 2022
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kunalspathak
kunalspathak
merged commit 2500b6e
into
dotnet:mainSep 13, 2022
@SingleAccretion
SingleAccretion
deleted the

No-Obj-Folding

branch
September 13, 2022 18:21
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion@AndyAyersMS@kunalspathak@JulieLeeMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Delete some unnecessary code - #74527
Merged
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Sep 13, 2022
Merged
Delete some unnecessary code#74527
kunalspathak merged 3 commits into
dotnet:mainfrom 
SingleAccretion:No-Obj-Folding
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Aug 24, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Diffs.
@ghostghost
added

area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
labels
Aug 24, 2022
@ghost
ghost
commented
Aug 24, 2022

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
Issue Details
Three commits:
  1. No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
  2. No need to explicitly fold things anymore. A couple small regressions in exotic test code.
  3. Dead code removal. No diffs.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@SingleAccretion
Remove "OBJ(LCL_VAR_ADDR)" folding from putarg lowering
3a9f933
This was originally put in place to allow the corresponding codegen
changes to be tested. Now that we have more than adequate coverage
from the front-end transformations, we can simply delete the code.
@SingleAccretion
Delete dead OBJ handling in BuildPutArgReg
146d259
We don't expect any OBJs here.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
August 25, 2022 14:03
@SingleAccretion
SingleAccretion
commented
Aug 25, 2022

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
@JulieLeeMSFTJulieLeeMSFT
added this to the 8.0.0 milestone
Aug 25, 2022
@AndyAyersMS
AndyAyersMS
commented
Sep 12, 2022

Copy link


Copy Markdown

Member
@kunalspathak can you review?
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
No need to explicitly simplify OBJ(ADDR(LCL_VAR)) anymore. No diffs.
I am not much familiar with this code lately. Can you elaborate in PR comments why explicit simplification is not needed now?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Why is explicit simplification is not needed now?
Essentially, we are now folding this pattern in local morph, and so don't need the additional checks. Eventually, almost all such checks will be deleted from the codebase; this is a start.
SingleAccretion
SingleAccretion
commented
Sep 13, 2022
View reviewed changes
Comment threadsrc/coreclr/jit/morphblock.cpp
 {
 if (m_dst->OperIs(GT_OBJ))
 {
 GenTreeLclVar* lclVar = m_comp->fgMorphTryFoldObjAsLclVar(m_dst->AsObj());
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71584.
Comment threadsrc/coreclr/jit/lsrabuild.cpp

 // First, handle the GT_OBJ case, which loads into the arg register
 // (so we don't set the use to prefer that register for the source address).
 if (op1->OperIs(GT_OBJ))
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code.
Comment threadsrc/coreclr/jit/lowerxarch.cpp
#endif // !TARGET_X86
 }

 if (src->OperIs(GT_OBJ) && src->AsObj()->Addr()->OperIsLocalAddr())
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #70960 and #70779.
Comment threadsrc/coreclr/jit/lowerarmarch.cpp
 // STRUCT args (FIELD_LIST / OBJ / LCL_VAR / LCL_FLD) will always be contained.
 MakeSrcContained(putArgNode, src);

 // TODO-ADDR: always perform this transformation in local morph and delete this code.
@SingleAccretionSingleAccretionSep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed after #71598 and #71328.
@kunalspathak
kunalspathak
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
Great...thank you. I am not able to access the diff...what does it look like?
@SingleAccretion
SingleAccretion
commented
Sep 13, 2022

Copy link


Copy Markdown

ContributorAuthor
what does it look like?
There are no diffs outside of coreclr_tests. In tests, we have:
  1. On all non-ARM platforms: 4 minor regressions in tests that test Call(*(Struct*)&doubleVal);-like code.
  2. On ARM: couple large improvements because some huge structs now go down the OBJ(LCL_FLD_ADDR) path, which is more optimal for them (reversal of Support PUTARG_SPLIT(STRUCT LCL_VAR/LCL_FLD) on ARM/64 #70861 (comment), essentially).
kunalspathak
kunalspathak
approved these changes
Sep 13, 2022
View reviewed changes
@kunalspathakkunalspathak
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kunalspathak
kunalspathak
merged commit 2500b6e
into
dotnet:mainSep 13, 2022
@SingleAccretion
SingleAccretion
deleted the

No-Obj-Folding

branch
September 13, 2022 18:21
@ghostghost
locked as resolved and limited conversation to collaborators
Oct 13, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion@AndyAyersMS@kunalspathak@JulieLeeMSFT