Uh oh!
There was an error while loading. Please reload this page.
[release/7.0-rc1] Add NuGet package for System.Runtime.Serialization.Schema - #74597
Merged
carlossanlop merged 1 commit intoAug 25, 2022
Merged
Conversation
System.Runtime.Serialization.Schema isn't getting a NuGet package created for it because it doesn't set IsPackable=true.
ghost
commented
Aug 25, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
carlossanlop
requested review from
HongGit, StephenMolloy, danmoseley, eerhardt and mmitcheAugust 25, 2022 17:17
StephenMolloy
approved these changes
Aug 25, 2022
mmitche
approved these changes
Aug 25, 2022
eerhardt
approved these changes
Aug 25, 2022
mmitche
commented
Aug 25, 2022
Member
Merge when ready and we'll get this in if we can. |
carlossanlop
commented
Aug 25, 2022
Contributor
The libraries allconfigurations leg is green. This is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #74533 to release/7.0-rc1
/cc @carlossanlop@eerhardt
Customer Impact
System.Runtime.Serialization.Schema isn't getting a NuGet package created for it because it doesn't set IsPackable=true.
Testing
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.