Uh oh!
There was an error while loading. Please reload this page.
[release/7.0-rc1] [MONO] Make mono_marshal_ilgen_init a public MONO_API function again - #74660
Closed
github-actions[bot] wants to merge 3 commits into
Closed
[release/7.0-rc1] [MONO] Make mono_marshal_ilgen_init a public MONO_API function again#74660github-actions[bot] wants to merge 3 commits into
github-actions[bot] wants to merge 3 commits into
Conversation
github-actionsBot
requested review from
lambdageek, marek-safar, thaystg and vargaz
as code ownersAugust 26, 2022 16:17
lewing
approved these changes
Aug 26, 2022
lewing
commented
Aug 26, 2022
Member
We have a workaround in dotnet/macios#15788 so if that lands this can be retargeted to |
dalexsoto
approved these changes
Aug 26, 2022
dalexsoto
commented
Aug 26, 2022
Member
@lewing not sure what will be faster, our CI started going 🍌s today :( so I would say if you can keep the train going on this one as a fail safe might be better |
lewing
commented
Aug 26, 2022
Member
I'm not stopping it but taking a new runtime package will put schedules at risk |
github-actionsBotforce-pushed
the
backport/pr-74658-to-release/7.0-rc1
branch
from
August 26, 2022 18:17
697be58 to
2045c58Comparecarlossanlop
commented
Aug 26, 2022
Contributor
@mmitche do we still have runway to get this merged to RC1? |
lewing
commented
Aug 26, 2022
Member
can't merge this as is, it breaks wasm. alternate fix staged in #74675 while we keep working on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #74658 to release/7.0-rc1
/cc @lewing@naricc
Customer Impact
Testing
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.