Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Fix signature for 64-bit delegate profiling helper - #74743
Merged
Conversation
I missed updating the signature of the 64-bit variant here when the vtable and delegate profiling helpers were originally split up. Fix#74295
Add some testing.
This needs some work so disable it for now.
ghost
commented
Aug 29, 2022
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #74500 to release/7.0 /cc @jakobbotsch Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
jeffschwMSFT
approved these changes
Aug 29, 2022
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. Please get a code review.
EgorBo
approved these changes
Aug 29, 2022
carlossanlop
commented
Aug 29, 2022
Contributor
Approved. Signed off. CI green. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #74500 to release/7.0
/cc @jakobbotsch
Customer Impact
PGO data collection using 64-bit counters (
DOTNET_JitCollect64BitCounts=1) does not work correctly. The symptom is segfault/access violations when PGO with 64-bit counters is enabled for code involving delegate calls.This is a 7.0 regression from #68703.
Testing
This PR adds randomized testing of this feature to the PGO runs.
Risk
Low.