Skip to content

[SocketException]: New Constructor with string? for SocketException - #74744

Merged
liveans merged 8 commits into
dotnet:mainfrom
liveans:api-implementation/add-constructor-socket-exception-69266
Sep 7, 2022
Merged

[SocketException]: New Constructor with string? for SocketException#74744
liveans merged 8 commits into
dotnet:mainfrom
liveans:api-implementation/add-constructor-socket-exception-69266

Conversation

@liveans

@liveansliveans commented Aug 29, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#69266 and #37150.

@ghost

ghost commented Aug 29, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Aug 29, 2022
@ghost

ghost commented Aug 29, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #69266.

Author:liveans
Assignees:-
Labels:

area-System.Net, new-api-needs-documentation

Milestone:-

@stephentoub

stephentoub commented Aug 29, 2022

Copy link
Copy Markdown
Member

Thanks, @liveans.

Can you please also add tests?

Also, part of the work for this is removing the ExtendedSocketException type and replacing usage of it with this new constructor (that removal is one of the things motivating the addition of this constructor).

@liveans

liveans commented Aug 29, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks, @liveans.

Can you please also add tests?

Yes, I'll add the necessary tests!

Also, part of the work for this is removing the ExtendedSocketException type and replacing usage of it with this new constructor (that removal is one of the things motivating the addition of this constructor).

Alright! I'll do this as well.

antonfirsov
antonfirsov reviewed Aug 29, 2022
View reviewed changes

@antonfirsovantonfirsov left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests and/or try to address #37150 using the new constructor?

Edit: Haven't noticed Stephen's update.

Comment threadsrc/libraries/System.Net.Primitives/src/System/Net/SocketException.cs Outdated
Comment threadsrc/libraries/System.Net.Primitives/src/System/Net/SocketException.cs Outdated
@liveans

liveans commented Aug 29, 2022

Copy link
Copy Markdown
ContributorAuthor

Can we add some tests and/or try to address #37150 using the new constructor?

Yes! I'll take a look at it.

liveansand others added 2 commits August 29, 2022 16:07
antonfirsov
antonfirsov reviewed Aug 30, 2022
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/Internals/SocketExceptionFactory.cs Outdated
This was referenced Aug 30, 2022
Closed
Open
@liveansliveans removed the community-contribution Indicates that the PR has been added by a community member label Sep 2, 2022
antonfirsov
antonfirsov reviewed Sep 2, 2022
View reviewed changes

@antonfirsovantonfirsov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks on tests.

Comment threadsrc/libraries/System.Net.Primitives/tests/FunctionalTests/SocketExceptionTest.cs Outdated
Comment threadsrc/libraries/System.Net.Primitives/tests/FunctionalTests/SocketExceptionTest.cs Outdated
Comment threadsrc/libraries/System.Net.Primitives/tests/FunctionalTests/SocketExceptionTest.cs Outdated
Comment threadsrc/libraries/System.Net.Primitives/tests/FunctionalTests/SocketExceptionTest.cs Outdated
antonfirsov
antonfirsov reviewed Sep 2, 2022
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/Sockets/SocketExceptionFactory.Unix.cs Outdated
@antonfirsov

antonfirsov commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Sep 5, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@liveans

liveans commented Sep 5, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Sep 5, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

stephentoub
stephentoub reviewed Sep 6, 2022
View reviewed changes
Comment threadsrc/libraries/System.Net.Primitives/tests/FunctionalTests/SocketExceptionTest.cs Outdated
stephentoub
stephentoub approved these changes Sep 6, 2022
View reviewed changes

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liveansliveans linked an issue Sep 6, 2022 that may be closed by this pull request
System.Net.Internals.SocketExceptionFactory+ExtendedSocketException #37150
Closed
@liveans

liveans commented Sep 6, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Sep 6, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@liveans

liveans commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Outerloop failures are #74468

@liveans
liveans merged commit e485583 into dotnet:mainSep 7, 2022
@ghostghost locked as resolved and limited conversation to collaborators Oct 7, 2022
@karelzkarelz added this to the 8.0.0 milestone Mar 22, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
+1 more reviewer
@antonfirsovantonfirsovantonfirsov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Netnew-api-needs-documentation

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Add constructor with string for SocketException System.Net.Internals.SocketExceptionFactory+ExtendedSocketException

4 participants

@liveans@stephentoub@antonfirsov@karelz