Skip to content

Unload MsQuic after checking for QUIC support to free resources.#74749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzikm merged 3 commits into from
Sep 1, 2022
Merged

Unload MsQuic after checking for QUIC support to free resources. #74749

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fee1c6d
Unload MsQuic after checking for QUIC support to free resources.
rzikm Aug 29, 2022
bf47ac0
Unload MsQuic unconditionally
rzikm Aug 31, 2022
162c331
Code review feedback
rzikm Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 59 additions & 24 deletions src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Runtime.InteropServices;
using Microsoft.Quic;
Expand DownExpand Up@@ -47,7 +48,8 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)
}
}

internal static MsQuicApi Api { get; } = null!;
private static readonly Lazy<MsQuicApi> _api = new Lazy<MsQuicApi>(AllocateMsQuicApi);
internal static MsQuicApi Api => _api.Value;

internal static bool IsQuicSupported { get; }

Expand All@@ -58,29 +60,21 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)

static MsQuicApi()
{
IntPtr msQuicHandle;
if (!NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) &&
!NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle))
if (!TryLoadMsQuic(out IntPtr msQuicHandle))
{
return;
}

try
{
if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
{
return;
}

QUIC_API_TABLE* apiTable = null;
delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &apiTable)))
if (!TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
{
return;
}

try
{
// Check version
int arraySize = 4;
uint* libVersion = stackalloc uint[arraySize];
uint size = (uint)arraySize * sizeof(uint);
Expand All@@ -99,7 +93,7 @@ static MsQuicApi()
return;
}

// Assume SChannel is being used on windows and query for the actual provider from the library
// Assume SChannel is being used on windows and query for the actual provider from the library if querying is supported
QUIC_TLS_PROVIDER provider = OperatingSystem.IsWindows() ? QUIC_TLS_PROVIDER.SCHANNEL : QUIC_TLS_PROVIDER.OPENSSL;
size = sizeof(QUIC_TLS_PROVIDER);
apiTable->GetParam(null, QUIC_PARAM_GLOBAL_TLS_PROVIDER, &size, &provider);
Expand All@@ -122,26 +116,67 @@ static MsQuicApi()
Tls13ClientMayBeDisabled = IsTls13Disabled(isServer: false);
}

Api = new MsQuicApi(apiTable);
IsQuicSupported = true;
}
finally
{
if (!IsQuicSupported && NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
{
// Gracefully close the API table
((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
}
// Gracefully close the API table to free resources. The API table will be allocated lazily again if needed
bool closed = TryCloseMsQuic(msQuicHandle, apiTable);
Debug.Assert(closed, "Failed to close MsQuic");
}

}
finally
{
if (!IsQuicSupported)
{
NativeLibrary.Free(msQuicHandle);
}
// Unload the library, we will load it again when we actually use QUIC
NativeLibrary.Free(msQuicHandle);
}
}

private static MsQuicApi AllocateMsQuicApi()
{
Debug.Assert(IsQuicSupported);

if (TryLoadMsQuic(out IntPtr msQuicHandle) &&
TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
{
return new MsQuicApi(apiTable);
}

throw new Exception("Failed to create MsQuicApi instance");
}

private static bool TryLoadMsQuic(out IntPtr msQuicHandle) =>
NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) ||
NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle);

private static bool TryOpenMsQuic(IntPtr msQuicHandle, out QUIC_API_TABLE* apiTable)
{
apiTable = null;
if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
{
return false;
}

QUIC_API_TABLE* table = null;
delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &table)))
{
return false;
}

apiTable = table;
return true;
}

private static bool TryCloseMsQuic(IntPtr msQuicHandle, QUIC_API_TABLE* apiTable)
{
if (NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
{
((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
return true;
}

return false;
}

private static bool IsWindowsVersionSupported() => OperatingSystem.IsWindowsVersionAtLeast(MinWindowsVersion.Major,
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Unload MsQuic after checking for QUIC support to free resources. by rzikm · Pull Request #74749 · dotnet/runtime · GitHub
Skip to content
Unload MsQuic after checking for QUIC support to free resources.#74749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rzikm
merged 3 commits into

from

Sep 1, 2022
 Merged


Unload MsQuic after checking for QUIC support to free resources.
#74749
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
fee1c6d

Unload MsQuic after checking for QUIC support to free resources.


rzikm Aug 29, 2022
bf47ac0

Unload MsQuic unconditionally


rzikm Aug 31, 2022
162c331

Code review feedback


rzikm Sep 1, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


83 changes: 59 additions & 24 deletions
src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Runtime.InteropServices;
using Microsoft.Quic;
Expand DownExpand Up@@ -47,7 +48,8 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)
 }
 }

 internal static MsQuicApi Api { get; } = null!;
 private static readonly Lazy<MsQuicApi> _api = new Lazy<MsQuicApi>(AllocateMsQuicApi);
 internal static MsQuicApi Api => _api.Value;

 internal static bool IsQuicSupported { get; }

Expand All@@ -58,29 +60,21 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)

 static MsQuicApi()
 {
 IntPtr msQuicHandle;
 if (!NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) &&
 !NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle))
 if (!TryLoadMsQuic(out IntPtr msQuicHandle))
 {
 return;
 }

 try
 {
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return;
 }

 QUIC_API_TABLE* apiTable = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &apiTable)))
 if (!TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return;
 }

 try
 {
 // Check version
 int arraySize = 4;
 uint* libVersion = stackalloc uint[arraySize];
 uint size = (uint)arraySize * sizeof(uint);
Expand All@@ -99,7 +93,7 @@ static MsQuicApi()
 return;
 }

 // Assume SChannel is being used on windows and query for the actual provider from the library
 // Assume SChannel is being used on windows and query for the actual provider from the library if querying is supported
 QUIC_TLS_PROVIDER provider = OperatingSystem.IsWindows() ? QUIC_TLS_PROVIDER.SCHANNEL : QUIC_TLS_PROVIDER.OPENSSL;
 size = sizeof(QUIC_TLS_PROVIDER);
 apiTable->GetParam(null, QUIC_PARAM_GLOBAL_TLS_PROVIDER, &size, &provider);
Expand All@@ -122,26 +116,67 @@ static MsQuicApi()
 Tls13ClientMayBeDisabled = IsTls13Disabled(isServer: false);
 }

 Api = new MsQuicApi(apiTable);
 IsQuicSupported = true;
 }
 finally
 {
 if (!IsQuicSupported && NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 // Gracefully close the API table
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 }
 // Gracefully close the API table to free resources. The API table will be allocated lazily again if needed
 bool closed = TryCloseMsQuic(msQuicHandle, apiTable);
 Debug.Assert(closed, "Failed to close MsQuic");
 }

 }
 finally
 {
 if (!IsQuicSupported)
 {
 NativeLibrary.Free(msQuicHandle);
 }
 // Unload the library, we will load it again when we actually use QUIC
 NativeLibrary.Free(msQuicHandle);
 }
 }

 private static MsQuicApi AllocateMsQuicApi()
 {
 Debug.Assert(IsQuicSupported);

 if (TryLoadMsQuic(out IntPtr msQuicHandle) &&
 TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return new MsQuicApi(apiTable);
 }

 throw new Exception("Failed to create MsQuicApi instance");
 }

 private static bool TryLoadMsQuic(out IntPtr msQuicHandle) =>
 NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) ||
 NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle);

 private static bool TryOpenMsQuic(IntPtr msQuicHandle, out QUIC_API_TABLE* apiTable)
 {
 apiTable = null;
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return false;
 }

 QUIC_API_TABLE* table = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &table)))
 {
 return false;
 }

 apiTable = table;
 return true;
 }

 private static bool TryCloseMsQuic(IntPtr msQuicHandle, QUIC_API_TABLE* apiTable)
 {
 if (NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 return true;
 }

 return false;
 }

 private static bool IsWindowsVersionSupported() => OperatingSystem.IsWindowsVersionAtLeast(MinWindowsVersion.Major,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Unload MsQuic after checking for QUIC support to free resources. by rzikm · Pull Request #74749 · dotnet/runtime · GitHub
Skip to content
Unload MsQuic after checking for QUIC support to free resources.#74749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rzikm
merged 3 commits into

from

Sep 1, 2022
 Merged


Unload MsQuic after checking for QUIC support to free resources.
#74749
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
fee1c6d

Unload MsQuic after checking for QUIC support to free resources.


rzikm Aug 29, 2022
bf47ac0

Unload MsQuic unconditionally


rzikm Aug 31, 2022
162c331

Code review feedback


rzikm Sep 1, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


83 changes: 59 additions & 24 deletions
src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Runtime.InteropServices;
using Microsoft.Quic;
Expand DownExpand Up@@ -47,7 +48,8 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)
 }
 }

 internal static MsQuicApi Api { get; } = null!;
 private static readonly Lazy<MsQuicApi> _api = new Lazy<MsQuicApi>(AllocateMsQuicApi);
 internal static MsQuicApi Api => _api.Value;

 internal static bool IsQuicSupported { get; }

Expand All@@ -58,29 +60,21 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)

 static MsQuicApi()
 {
 IntPtr msQuicHandle;
 if (!NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) &&
 !NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle))
 if (!TryLoadMsQuic(out IntPtr msQuicHandle))
 {
 return;
 }

 try
 {
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return;
 }

 QUIC_API_TABLE* apiTable = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &apiTable)))
 if (!TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return;
 }

 try
 {
 // Check version
 int arraySize = 4;
 uint* libVersion = stackalloc uint[arraySize];
 uint size = (uint)arraySize * sizeof(uint);
Expand All@@ -99,7 +93,7 @@ static MsQuicApi()
 return;
 }

 // Assume SChannel is being used on windows and query for the actual provider from the library
 // Assume SChannel is being used on windows and query for the actual provider from the library if querying is supported
 QUIC_TLS_PROVIDER provider = OperatingSystem.IsWindows() ? QUIC_TLS_PROVIDER.SCHANNEL : QUIC_TLS_PROVIDER.OPENSSL;
 size = sizeof(QUIC_TLS_PROVIDER);
 apiTable->GetParam(null, QUIC_PARAM_GLOBAL_TLS_PROVIDER, &size, &provider);
Expand All@@ -122,26 +116,67 @@ static MsQuicApi()
 Tls13ClientMayBeDisabled = IsTls13Disabled(isServer: false);
 }

 Api = new MsQuicApi(apiTable);
 IsQuicSupported = true;
 }
 finally
 {
 if (!IsQuicSupported && NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 // Gracefully close the API table
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 }
 // Gracefully close the API table to free resources. The API table will be allocated lazily again if needed
 bool closed = TryCloseMsQuic(msQuicHandle, apiTable);
 Debug.Assert(closed, "Failed to close MsQuic");
 }

 }
 finally
 {
 if (!IsQuicSupported)
 {
 NativeLibrary.Free(msQuicHandle);
 }
 // Unload the library, we will load it again when we actually use QUIC
 NativeLibrary.Free(msQuicHandle);
 }
 }

 private static MsQuicApi AllocateMsQuicApi()
 {
 Debug.Assert(IsQuicSupported);

 if (TryLoadMsQuic(out IntPtr msQuicHandle) &&
 TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return new MsQuicApi(apiTable);
 }

 throw new Exception("Failed to create MsQuicApi instance");
 }

 private static bool TryLoadMsQuic(out IntPtr msQuicHandle) =>
 NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) ||
 NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle);

 private static bool TryOpenMsQuic(IntPtr msQuicHandle, out QUIC_API_TABLE* apiTable)
 {
 apiTable = null;
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return false;
 }

 QUIC_API_TABLE* table = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &table)))
 {
 return false;
 }

 apiTable = table;
 return true;
 }

 private static bool TryCloseMsQuic(IntPtr msQuicHandle, QUIC_API_TABLE* apiTable)
 {
 if (NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 return true;
 }

 return false;
 }

 private static bool IsWindowsVersionSupported() => OperatingSystem.IsWindowsVersionAtLeast(MinWindowsVersion.Major,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Unload MsQuic after checking for QUIC support to free resources. by rzikm · Pull Request #74749 · dotnet/runtime · GitHub
Skip to content
Unload MsQuic after checking for QUIC support to free resources.#74749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rzikm
merged 3 commits into

from

Sep 1, 2022
 Merged


Unload MsQuic after checking for QUIC support to free resources.
#74749
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
fee1c6d

Unload MsQuic after checking for QUIC support to free resources.


rzikm Aug 29, 2022
bf47ac0

Unload MsQuic unconditionally


rzikm Aug 31, 2022
162c331

Code review feedback


rzikm Sep 1, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


83 changes: 59 additions & 24 deletions
src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Runtime.InteropServices;
using Microsoft.Quic;
Expand DownExpand Up@@ -47,7 +48,8 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)
 }
 }

 internal static MsQuicApi Api { get; } = null!;
 private static readonly Lazy<MsQuicApi> _api = new Lazy<MsQuicApi>(AllocateMsQuicApi);
 internal static MsQuicApi Api => _api.Value;

 internal static bool IsQuicSupported { get; }

Expand All@@ -58,29 +60,21 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)

 static MsQuicApi()
 {
 IntPtr msQuicHandle;
 if (!NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) &&
 !NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle))
 if (!TryLoadMsQuic(out IntPtr msQuicHandle))
 {
 return;
 }

 try
 {
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return;
 }

 QUIC_API_TABLE* apiTable = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &apiTable)))
 if (!TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return;
 }

 try
 {
 // Check version
 int arraySize = 4;
 uint* libVersion = stackalloc uint[arraySize];
 uint size = (uint)arraySize * sizeof(uint);
Expand All@@ -99,7 +93,7 @@ static MsQuicApi()
 return;
 }

 // Assume SChannel is being used on windows and query for the actual provider from the library
 // Assume SChannel is being used on windows and query for the actual provider from the library if querying is supported
 QUIC_TLS_PROVIDER provider = OperatingSystem.IsWindows() ? QUIC_TLS_PROVIDER.SCHANNEL : QUIC_TLS_PROVIDER.OPENSSL;
 size = sizeof(QUIC_TLS_PROVIDER);
 apiTable->GetParam(null, QUIC_PARAM_GLOBAL_TLS_PROVIDER, &size, &provider);
Expand All@@ -122,26 +116,67 @@ static MsQuicApi()
 Tls13ClientMayBeDisabled = IsTls13Disabled(isServer: false);
 }

 Api = new MsQuicApi(apiTable);
 IsQuicSupported = true;
 }
 finally
 {
 if (!IsQuicSupported && NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 // Gracefully close the API table
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 }
 // Gracefully close the API table to free resources. The API table will be allocated lazily again if needed
 bool closed = TryCloseMsQuic(msQuicHandle, apiTable);
 Debug.Assert(closed, "Failed to close MsQuic");
 }

 }
 finally
 {
 if (!IsQuicSupported)
 {
 NativeLibrary.Free(msQuicHandle);
 }
 // Unload the library, we will load it again when we actually use QUIC
 NativeLibrary.Free(msQuicHandle);
 }
 }

 private static MsQuicApi AllocateMsQuicApi()
 {
 Debug.Assert(IsQuicSupported);

 if (TryLoadMsQuic(out IntPtr msQuicHandle) &&
 TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return new MsQuicApi(apiTable);
 }

 throw new Exception("Failed to create MsQuicApi instance");
 }

 private static bool TryLoadMsQuic(out IntPtr msQuicHandle) =>
 NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) ||
 NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle);

 private static bool TryOpenMsQuic(IntPtr msQuicHandle, out QUIC_API_TABLE* apiTable)
 {
 apiTable = null;
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return false;
 }

 QUIC_API_TABLE* table = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &table)))
 {
 return false;
 }

 apiTable = table;
 return true;
 }

 private static bool TryCloseMsQuic(IntPtr msQuicHandle, QUIC_API_TABLE* apiTable)
 {
 if (NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 return true;
 }

 return false;
 }

 private static bool IsWindowsVersionSupported() => OperatingSystem.IsWindowsVersionAtLeast(MinWindowsVersion.Major,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Unload MsQuic after checking for QUIC support to free resources. by rzikm · Pull Request #74749 · dotnet/runtime · GitHub
Skip to content
Unload MsQuic after checking for QUIC support to free resources.#74749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rzikm
merged 3 commits into

from

Sep 1, 2022
 Merged


Unload MsQuic after checking for QUIC support to free resources.
#74749
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
fee1c6d

Unload MsQuic after checking for QUIC support to free resources.


rzikm Aug 29, 2022
bf47ac0

Unload MsQuic unconditionally


rzikm Aug 31, 2022
162c331

Code review feedback


rzikm Sep 1, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


83 changes: 59 additions & 24 deletions
src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Runtime.InteropServices;
using Microsoft.Quic;
Expand DownExpand Up@@ -47,7 +48,8 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)
 }
 }

 internal static MsQuicApi Api { get; } = null!;
 private static readonly Lazy<MsQuicApi> _api = new Lazy<MsQuicApi>(AllocateMsQuicApi);
 internal static MsQuicApi Api => _api.Value;

 internal static bool IsQuicSupported { get; }

Expand All@@ -58,29 +60,21 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)

 static MsQuicApi()
 {
 IntPtr msQuicHandle;
 if (!NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) &&
 !NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle))
 if (!TryLoadMsQuic(out IntPtr msQuicHandle))
 {
 return;
 }

 try
 {
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return;
 }

 QUIC_API_TABLE* apiTable = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &apiTable)))
 if (!TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return;
 }

 try
 {
 // Check version
 int arraySize = 4;
 uint* libVersion = stackalloc uint[arraySize];
 uint size = (uint)arraySize * sizeof(uint);
Expand All@@ -99,7 +93,7 @@ static MsQuicApi()
 return;
 }

 // Assume SChannel is being used on windows and query for the actual provider from the library
 // Assume SChannel is being used on windows and query for the actual provider from the library if querying is supported
 QUIC_TLS_PROVIDER provider = OperatingSystem.IsWindows() ? QUIC_TLS_PROVIDER.SCHANNEL : QUIC_TLS_PROVIDER.OPENSSL;
 size = sizeof(QUIC_TLS_PROVIDER);
 apiTable->GetParam(null, QUIC_PARAM_GLOBAL_TLS_PROVIDER, &size, &provider);
Expand All@@ -122,26 +116,67 @@ static MsQuicApi()
 Tls13ClientMayBeDisabled = IsTls13Disabled(isServer: false);
 }

 Api = new MsQuicApi(apiTable);
 IsQuicSupported = true;
 }
 finally
 {
 if (!IsQuicSupported && NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 // Gracefully close the API table
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 }
 // Gracefully close the API table to free resources. The API table will be allocated lazily again if needed
 bool closed = TryCloseMsQuic(msQuicHandle, apiTable);
 Debug.Assert(closed, "Failed to close MsQuic");
 }

 }
 finally
 {
 if (!IsQuicSupported)
 {
 NativeLibrary.Free(msQuicHandle);
 }
 // Unload the library, we will load it again when we actually use QUIC
 NativeLibrary.Free(msQuicHandle);
 }
 }

 private static MsQuicApi AllocateMsQuicApi()
 {
 Debug.Assert(IsQuicSupported);

 if (TryLoadMsQuic(out IntPtr msQuicHandle) &&
 TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return new MsQuicApi(apiTable);
 }

 throw new Exception("Failed to create MsQuicApi instance");
 }

 private static bool TryLoadMsQuic(out IntPtr msQuicHandle) =>
 NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) ||
 NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle);

 private static bool TryOpenMsQuic(IntPtr msQuicHandle, out QUIC_API_TABLE* apiTable)
 {
 apiTable = null;
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return false;
 }

 QUIC_API_TABLE* table = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &table)))
 {
 return false;
 }

 apiTable = table;
 return true;
 }

 private static bool TryCloseMsQuic(IntPtr msQuicHandle, QUIC_API_TABLE* apiTable)
 {
 if (NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 return true;
 }

 return false;
 }

 private static bool IsWindowsVersionSupported() => OperatingSystem.IsWindowsVersionAtLeast(MinWindowsVersion.Major,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Unload MsQuic after checking for QUIC support to free resources. by rzikm · Pull Request #74749 · dotnet/runtime · GitHub
Skip to content
Unload MsQuic after checking for QUIC support to free resources.#74749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rzikm
merged 3 commits into

from

Sep 1, 2022
 Merged


Unload MsQuic after checking for QUIC support to free resources.
#74749
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
fee1c6d

Unload MsQuic after checking for QUIC support to free resources.


rzikm Aug 29, 2022
bf47ac0

Unload MsQuic unconditionally


rzikm Aug 31, 2022
162c331

Code review feedback


rzikm Sep 1, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


83 changes: 59 additions & 24 deletions
src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Runtime.InteropServices;
using Microsoft.Quic;
Expand DownExpand Up@@ -47,7 +48,8 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)
 }
 }

 internal static MsQuicApi Api { get; } = null!;
 private static readonly Lazy<MsQuicApi> _api = new Lazy<MsQuicApi>(AllocateMsQuicApi);
 internal static MsQuicApi Api => _api.Value;

 internal static bool IsQuicSupported { get; }

Expand All@@ -58,29 +60,21 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)

 static MsQuicApi()
 {
 IntPtr msQuicHandle;
 if (!NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) &&
 !NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle))
 if (!TryLoadMsQuic(out IntPtr msQuicHandle))
 {
 return;
 }

 try
 {
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return;
 }

 QUIC_API_TABLE* apiTable = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &apiTable)))
 if (!TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return;
 }

 try
 {
 // Check version
 int arraySize = 4;
 uint* libVersion = stackalloc uint[arraySize];
 uint size = (uint)arraySize * sizeof(uint);
Expand All@@ -99,7 +93,7 @@ static MsQuicApi()
 return;
 }

 // Assume SChannel is being used on windows and query for the actual provider from the library
 // Assume SChannel is being used on windows and query for the actual provider from the library if querying is supported
 QUIC_TLS_PROVIDER provider = OperatingSystem.IsWindows() ? QUIC_TLS_PROVIDER.SCHANNEL : QUIC_TLS_PROVIDER.OPENSSL;
 size = sizeof(QUIC_TLS_PROVIDER);
 apiTable->GetParam(null, QUIC_PARAM_GLOBAL_TLS_PROVIDER, &size, &provider);
Expand All@@ -122,26 +116,67 @@ static MsQuicApi()
 Tls13ClientMayBeDisabled = IsTls13Disabled(isServer: false);
 }

 Api = new MsQuicApi(apiTable);
 IsQuicSupported = true;
 }
 finally
 {
 if (!IsQuicSupported && NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 // Gracefully close the API table
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 }
 // Gracefully close the API table to free resources. The API table will be allocated lazily again if needed
 bool closed = TryCloseMsQuic(msQuicHandle, apiTable);
 Debug.Assert(closed, "Failed to close MsQuic");
 }

 }
 finally
 {
 if (!IsQuicSupported)
 {
 NativeLibrary.Free(msQuicHandle);
 }
 // Unload the library, we will load it again when we actually use QUIC
 NativeLibrary.Free(msQuicHandle);
 }
 }

 private static MsQuicApi AllocateMsQuicApi()
 {
 Debug.Assert(IsQuicSupported);

 if (TryLoadMsQuic(out IntPtr msQuicHandle) &&
 TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return new MsQuicApi(apiTable);
 }

 throw new Exception("Failed to create MsQuicApi instance");
 }

 private static bool TryLoadMsQuic(out IntPtr msQuicHandle) =>
 NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) ||
 NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle);

 private static bool TryOpenMsQuic(IntPtr msQuicHandle, out QUIC_API_TABLE* apiTable)
 {
 apiTable = null;
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return false;
 }

 QUIC_API_TABLE* table = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &table)))
 {
 return false;
 }

 apiTable = table;
 return true;
 }

 private static bool TryCloseMsQuic(IntPtr msQuicHandle, QUIC_API_TABLE* apiTable)
 {
 if (NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 return true;
 }

 return false;
 }

 private static bool IsWindowsVersionSupported() => OperatingSystem.IsWindowsVersionAtLeast(MinWindowsVersion.Major,
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Unload MsQuic after checking for QUIC support to free resources. by rzikm · Pull Request #74749 · dotnet/runtime · GitHub
Skip to content
Unload MsQuic after checking for QUIC support to free resources.#74749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rzikm
merged 3 commits into

from

Sep 1, 2022
 Merged


Unload MsQuic after checking for QUIC support to free resources.
#74749
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
fee1c6d

Unload MsQuic after checking for QUIC support to free resources.


rzikm Aug 29, 2022
bf47ac0

Unload MsQuic unconditionally


rzikm Aug 31, 2022
162c331

Code review feedback


rzikm Sep 1, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


83 changes: 59 additions & 24 deletions
src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicApi.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Runtime.InteropServices;
using Microsoft.Quic;
Expand DownExpand Up@@ -47,7 +48,8 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)
 }
 }

 internal static MsQuicApi Api { get; } = null!;
 private static readonly Lazy<MsQuicApi> _api = new Lazy<MsQuicApi>(AllocateMsQuicApi);
 internal static MsQuicApi Api => _api.Value;

 internal static bool IsQuicSupported { get; }

Expand All@@ -58,29 +60,21 @@ private MsQuicApi(QUIC_API_TABLE* apiTable)

 static MsQuicApi()
 {
 IntPtr msQuicHandle;
 if (!NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) &&
 !NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle))
 if (!TryLoadMsQuic(out IntPtr msQuicHandle))
 {
 return;
 }

 try
 {
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return;
 }

 QUIC_API_TABLE* apiTable = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &apiTable)))
 if (!TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return;
 }

 try
 {
 // Check version
 int arraySize = 4;
 uint* libVersion = stackalloc uint[arraySize];
 uint size = (uint)arraySize * sizeof(uint);
Expand All@@ -99,7 +93,7 @@ static MsQuicApi()
 return;
 }

 // Assume SChannel is being used on windows and query for the actual provider from the library
 // Assume SChannel is being used on windows and query for the actual provider from the library if querying is supported
 QUIC_TLS_PROVIDER provider = OperatingSystem.IsWindows() ? QUIC_TLS_PROVIDER.SCHANNEL : QUIC_TLS_PROVIDER.OPENSSL;
 size = sizeof(QUIC_TLS_PROVIDER);
 apiTable->GetParam(null, QUIC_PARAM_GLOBAL_TLS_PROVIDER, &size, &provider);
Expand All@@ -122,26 +116,67 @@ static MsQuicApi()
 Tls13ClientMayBeDisabled = IsTls13Disabled(isServer: false);
 }

 Api = new MsQuicApi(apiTable);
 IsQuicSupported = true;
 }
 finally
 {
 if (!IsQuicSupported && NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 // Gracefully close the API table
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 }
 // Gracefully close the API table to free resources. The API table will be allocated lazily again if needed
 bool closed = TryCloseMsQuic(msQuicHandle, apiTable);
 Debug.Assert(closed, "Failed to close MsQuic");
 }

 }
 finally
 {
 if (!IsQuicSupported)
 {
 NativeLibrary.Free(msQuicHandle);
 }
 // Unload the library, we will load it again when we actually use QUIC
 NativeLibrary.Free(msQuicHandle);
 }
 }

 private static MsQuicApi AllocateMsQuicApi()
 {
 Debug.Assert(IsQuicSupported);

 if (TryLoadMsQuic(out IntPtr msQuicHandle) &&
 TryOpenMsQuic(msQuicHandle, out QUIC_API_TABLE* apiTable))
 {
 return new MsQuicApi(apiTable);
 }

 throw new Exception("Failed to create MsQuicApi instance");
 }

 private static bool TryLoadMsQuic(out IntPtr msQuicHandle) =>
 NativeLibrary.TryLoad($"{Interop.Libraries.MsQuic}.{MsQuicVersion.Major}", typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle) ||
 NativeLibrary.TryLoad(Interop.Libraries.MsQuic, typeof(MsQuicApi).Assembly, DllImportSearchPath.AssemblyDirectory, out msQuicHandle);

 private static bool TryOpenMsQuic(IntPtr msQuicHandle, out QUIC_API_TABLE* apiTable)
 {
 apiTable = null;
 if (!NativeLibrary.TryGetExport(msQuicHandle, "MsQuicOpenVersion", out IntPtr msQuicOpenVersionAddress))
 {
 return false;
 }

 QUIC_API_TABLE* table = null;
 delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int> msQuicOpenVersion = (delegate* unmanaged[Cdecl]<uint, QUIC_API_TABLE**, int>)msQuicOpenVersionAddress;
 if (StatusFailed(msQuicOpenVersion((uint)MsQuicVersion.Major, &table)))
 {
 return false;
 }

 apiTable = table;
 return true;
 }

 private static bool TryCloseMsQuic(IntPtr msQuicHandle, QUIC_API_TABLE* apiTable)
 {
 if (NativeLibrary.TryGetExport(msQuicHandle, "MsQuicClose", out IntPtr msQuicClose))
 {
 ((delegate* unmanaged[Cdecl]<QUIC_API_TABLE*, void>)msQuicClose)(apiTable);
 return true;
 }

 return false;
 }

 private static bool IsWindowsVersionSupported() => OperatingSystem.IsWindowsVersionAtLeast(MinWindowsVersion.Major,
Expand Down