Skip to content

[ppc64le] Bug fixes - #74800

Merged
carlossanlop merged 1 commit into
dotnet:release/7.0from
alhad-deshpande:release/7.0
Aug 31, 2022
Merged

[ppc64le] Bug fixes#74800
carlossanlop merged 1 commit into
dotnet:release/7.0from
alhad-deshpande:release/7.0

Conversation

@alhad-deshpande

@alhad-deshpandealhad-deshpande commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

This PR is a manual backport for PR 74746 for release/7.0 branch. Please merge it as the original PR has already been merged in main.

@ghostghost added area-VM-meta-mono community-contribution Indicates that the PR has been added by a community member labels Aug 30, 2022
@alhad-deshpande

alhad-deshpande commented Aug 30, 2022

Copy link
Copy Markdown
ContributorAuthor

@akoeplinger
This PR is a manual backport for PR #74746 for release/7.0 branch. Please merge it as the original PR has already been merged in main.

@alhad-deshpande

alhad-deshpande commented Aug 30, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-community

@azure-pipelines

azure-pipelinesBot commented Aug 30, 2022

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 74800 in repo dotnet/runtime

@stephentoub

stephentoub commented Aug 30, 2022

Copy link
Copy Markdown
Member

Are we supporting ppc64le in .NET 7? I'm wondering why such fixes need to be in the release branch.

@akoeplinger

akoeplinger commented Aug 30, 2022

Copy link
Copy Markdown
Member

@stephentoub not from Microsoft's side, the port is maintained by IBM. This helps them carrying fewer patches.

@akoeplinger

akoeplinger commented Aug 30, 2022

Copy link
Copy Markdown
Member

@steveisok please approve

@carlossanlop

carlossanlop commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

@akoeplinger can you please confirm the CI failures aren't related?

@steveisok

steveisok commented Aug 30, 2022•
edited
Loading

Copy link
Copy Markdown
Member

The failures appear to be infra related as each one says it couldn't upload artifacts. In fact, the build analysis tab indicates they were dead lettered. I'll respin just to make sure.

@akoeplinger

akoeplinger commented Aug 30, 2022

Copy link
Copy Markdown
Member

This is only touching PPC64 code so it is impossible to be related to failures on ARM64 jobs. I think this is good to be merged.

@carlossanlop

carlossanlop commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

CI failures verified as unrelated. The re-run showed cancellations/artifacts not uploaded, but no actual test failures.
Approved and signed off.
Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit 65051a0 into dotnet:release/7.0Aug 31, 2022
@ghostghost locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@vargazvargazAwaiting requested review from vargaz

Assignees

No one assigned

Labels

area-VM-meta-monocommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alhad-deshpande@stephentoub@akoeplinger@carlossanlop@steveisok