Skip to content

Disable nullability warnings in JSON source generator - #74801

Merged
krwq merged 2 commits into
dotnet:mainfrom
krwq:json-source-gen-disable-nullable-warnings
Aug 31, 2022
Merged

Disable nullability warnings in JSON source generator#74801
krwq merged 2 commits into
dotnet:mainfrom
krwq:json-source-gen-disable-nullable-warnings

Conversation

@krwq

@krwqkrwq commented Aug 30, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #74652
Fixes: #61734

@ghostghost assigned krwqAug 30, 2022
@ghost

ghost commented Aug 30, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #74652

Author:krwq
Assignees:-
Labels:

area-System.Text.Json

Milestone:-

eiriktsarpalis
eiriktsarpalis reviewed Aug 30, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs
@eiriktsarpalis

eiriktsarpalis commented Aug 30, 2022

Copy link
Copy Markdown
Member

Fixes: #74652

We should probably not close this (or #61734) with this PR since we're merely suppressing warnings -- the underlying problem remains and we probably need to fix it in the future.

eiriktsarpalis
eiriktsarpalis reviewed Aug 30, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs
eiriktsarpalis
eiriktsarpalis approved these changes Aug 30, 2022
View reviewed changes

@eiriktsarpaliseiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krwq
krwq merged commit 6294858 into dotnet:mainAug 31, 2022
@eiriktsarpaliseiriktsarpalis mentioned this pull request Aug 31, 2022
Open
@eiriktsarpalis

eiriktsarpalis commented Aug 31, 2022

Copy link
Copy Markdown
Member

/backport to release/7.0

@github-actions

github-actionsBot commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2962426947

@krwq

krwq commented Aug 31, 2022

Copy link
Copy Markdown
MemberAuthor

You beat me with port as I was trying to find out what syntax that command has 😄

@github-actionsgithub-actionsBot mentioned this pull request Aug 31, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 30, 2022
@eiriktsarpaliseiriktsarpalis added this to the 8.0.0 milestone Jan 31, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes

Assignees

@krwqkrwq

Labels

area-System.Text.Json

Projects

None yet

Milestone

8.0.0

2 participants

@krwq@eiriktsarpalis