Uh oh!
There was an error while loading. Please reload this page.
add ability to set GCName via runtimeconfig. - #74831
Conversation
Uh oh!
There was an error while loading. Please reload this page.
cshung
commented
Aug 30, 2022
@mrsharm, shall we update the behavior of the |
mrsharm
commented
Aug 30, 2022
Sure - will work on this. |
mangod9
commented
Sep 2, 2022
There is a CI issue which is blocking re-running the wasm leg. It had passed on the previous run so this should be good to merge. Please CR. |
mrsharm
left a comment
There was a problem hiding this comment.
LGTM - I'll be following this PR up with updating our GC Configs so that this configuration shows up in our GetConfigurationVariables API.
mangod9
commented
Sep 2, 2022
I plan to backport this to 7, would the API change require porting to 7 as well? |
mrsharm
commented
Sep 2, 2022
Since the change will be a trivial and risk-free one, I think we could add the changes to gcconfig.h in one PR i.e. for the backport, merge the changes from this PR and the one I plan to create (which should be a few lines only). |
Added the new config to |
mangod9
commented
Sep 6, 2022
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3002894605 |
gcname was only enabled via
DOTNET_GCName, this change enables setting it viaSystem.GC.GCNamein runtimeconfig.json.