Skip to content

Hardware intrinsics tests in new style - #74886

Merged
davidwrighton merged 56 commits into
dotnet:mainfrom
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Nov 11, 2022
Merged

Hardware intrinsics tests in new style#74886
davidwrighton merged 56 commits into
dotnet:mainfrom
davidwrighton:HardwareIntrinsicsTestsInNewStyle

Conversation

@davidwrighton

@davidwrightondavidwrighton commented Aug 31, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Port all of the vector tests to the new xunit style specification

  • Test disables need to use the attribute based form
  • All tests are run on all architectures (This wasn't happening in the old system, but hopefully with test striping the need for this has gone away.)
  • The xunit wrapper generator generated methods which are too big for the merged assembly as designed earlier. I've broken that up into chunks of 100 methods each which seems to have solved that problem.
  • The xunit wrapper generator and runner have issues with running this many tests under GCStress, I've implemented a striping scheme to allow these tests to run across more machines when running under GCStress.

@davidwrighton
Convert Arm and General vector intrinsics to new style tests
f0a9246
- Except for General\HwiOp tests
- Also I've found that the Vector128<Single>.Dot test is failing due to floating point precision issues. Adding a fuzzy comparison seems to have fixed that, but I don't know why it isn't failing more often today.
@davidwrighton
Port Hwi tests
a2de0eb
@davidwrighton
Fix missed test templates on arm scenarios
36328e3
@davidwrighton
Port some of the X86 vector tests over
9268e95
@davidwrighton
Remove OutputType from General projects
4c436cb
@davidwrighton
Set BuildAsStandalone more reliably
059b1b8
@davidwrighton
Fix CoreCLRTestLibrary merged build problem
9ec9cc9
@davidwrighton
Hah, the tests actually run
598c1df
@davidwrighton
Finish converting projects that did not yet have BuildAsStandalone set
f2a850d
@davidwrighton
Update all x86 autogenerated tests to build properly and not have con…
b6754c4
…flicts
@davidwrighton
Port handwritten SSE2 tests to new test structure
6e7a01c
- And consolidate them so that they all compile with a single project file
@davidwrighton
Convert SSE2.X64 handwritten test to new system
eea9a83
@davidwrighton
Update Avx1 tests to new world order
0f1f35f
@davidwrighton
Convert handwritten Avx2 tests
874aec9
@davidwrighton
Update AvxVnni tests
3feef7f
@davidwrighton
Port General tests
eee679c
@davidwrighton
Lzcnt tests
df37224
@davidwrighton
Popcnt tests
9e51993
@davidwrighton
Improve global test wrapper
1a98b02
@davidwrighton
X86 regression tests
92a7a06
@davidwrighton
Sse1 tests
f81f562
@davidwrighton
Sse41 tests
1977c40
@davidwrighton
Sse3 tests
fe4d4fc
@davidwrighton
Sse42
f25c2b9
@davidwrighton
X86Base and X86Serialize tests
0bf1736
@davidwrighton
Fix a few minor issues
eee6e4b
@davidwrighton
Fix overlapping names so that the tests can be combined into a very l…
44907ff
…arge merged wrapper
@davidwrighton
Tweak xunit wrapper generator to break tests up into groups of 100 so…
8118819
… that we don't create an excessively large single method
@davidwrighton
Remove hardware intrinsics test groupings as they are no longer relevant
60ec3d7
@build-analysisbuild-analysisBot mentioned this pull request Nov 4, 2022
Closed
2 tasks
@davidwrighton
Move another set of test ActiveIssues to attributes from issues.targets
50a712c
- Fix the ActiveIssue with a conditional member implementation in the test source generator
- Tweak down the number of methods per test gen method again. There's still a LOT of them
@davidwrighton
Merge branch 'main' of github.com:dotnet/runtime into HardwareIntrins…
6b36937
…icsTestsInNewStyle
davidwrighton added a commit to davidwrighton/runtime that referenced this pull request Nov 4, 2022
@davidwrighton
Improve coreclr test infra
869211f
These fixes were built for PR dotnet#74886; however, as that PR is so utterly large an unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
@davidwrightondavidwrighton mentioned this pull request Nov 4, 2022
Merged
@davidwrighton

davidwrighton commented Nov 7, 2022

Copy link
Copy Markdown
MemberAuthor

/azp list

@azure-pipelines

azure-pipelinesBot commented Nov 7, 2022

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@davidwrighton

davidwrighton commented Nov 7, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-androidemulator

@azure-pipelines

azure-pipelinesBot commented Nov 7, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

davidwrighton added a commit that referenced this pull request Nov 8, 2022
@davidwrighton
Improve coreclr test infra (#77929)
939f050
These fixes were built for PR #74886; however, as that PR is so utterly large and unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
- Add some documentation about project files for coreclr tests, as well as some documentation on the command line parameters for merged test runner assemblies
davidwrighton
davidwrighton commented Nov 9, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/zapsig.cpp Outdated
davidwrighton
davidwrighton commented Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperLibrary/TestFilter.cs Outdated
tannergooding
tannergooding reviewed Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/AdvSimd.Arm64/Abs.Vector128.Double.cs
using Xunit;

namespace JIT.HardwareIntrinsics.Arm
namespace JIT.HardwareIntrinsics.Arm._AdvSimd.Arm64

@tannergoodingtannergoodingNov 9, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why the need for the underscore here?

@davidwrightondavidwrightonNov 9, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been quite a while, but I think there was a conflict between a namespace name and class name, and I stuffed in an underscore on the namespace to shut it all up.

tannergooding
tannergooding approved these changes Nov 9, 2022
View reviewed changes

@tannergoodingtannergooding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Fairly mechanical in nature

@davidwrighton

davidwrighton commented Nov 9, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Nov 9, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@davidwrightondavidwrighton mentioned this pull request Nov 10, 2022
Merged
@davidwrighton
davidwrighton merged commit 2095119 into dotnet:mainNov 11, 2022
This was referenced Nov 14, 2022
Open
Merged
@ghostghost locked as resolved and limited conversation to collaborators Dec 12, 2022
@davidwrighton
davidwrighton deleted the HardwareIntrinsicsTestsInNewStyle branch April 13, 2023 18:54
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky

Assignees

@davidwrightondavidwrighton

Labels

area-System.Runtime.Intrinsicstest-enhancementImprovements of test source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@davidwrighton@lambdageek@steveisok@tannergooding@steveharter@dakersnar@buyaa-n
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Hardware intrinsics tests in new style by davidwrighton · Pull Request #74886 · dotnet/runtime · GitHub
Skip to content
Hardware intrinsics tests in new style - #74886
Merged
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Nov 11, 2022
Merged
Hardware intrinsics tests in new style#74886
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Aug 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Port all of the vector tests to the new xunit style specification
  • Test disables need to use the attribute based form
  • All tests are run on all architectures (This wasn't happening in the old system, but hopefully with test striping the need for this has gone away.)
  • The xunit wrapper generator generated methods which are too big for the merged assembly as designed earlier. I've broken that up into chunks of 100 methods each which seems to have solved that problem.
  • The xunit wrapper generator and runner have issues with running this many tests under GCStress, I've implemented a striping scheme to allow these tests to run across more machines when running under GCStress.
@davidwrighton
Convert Arm and General vector intrinsics to new style tests
f0a9246
- Except for General\HwiOp tests
- Also I've found that the Vector128<Single>.Dot test is failing due to floating point precision issues. Adding a fuzzy comparison seems to have fixed that, but I don't know why it isn't failing more often today.
@davidwrighton
Port Hwi tests
a2de0eb
@davidwrighton
Fix missed test templates on arm scenarios
36328e3
@davidwrighton
Port some of the X86 vector tests over
9268e95
@davidwrighton
Remove OutputType from General projects
4c436cb
@davidwrighton
Set BuildAsStandalone more reliably
059b1b8
@davidwrighton
Fix CoreCLRTestLibrary merged build problem
9ec9cc9
@davidwrighton
Hah, the tests actually run
598c1df
@davidwrighton
Finish converting projects that did not yet have BuildAsStandalone set
f2a850d
@davidwrighton
Update all x86 autogenerated tests to build properly and not have con…
b6754c4
…flicts
@davidwrighton
Port handwritten SSE2 tests to new test structure
6e7a01c
- And consolidate them so that they all compile with a single project file
@davidwrighton
Convert SSE2.X64 handwritten test to new system
eea9a83
@davidwrighton
Update Avx1 tests to new world order
0f1f35f
@davidwrighton
Convert handwritten Avx2 tests
874aec9
@davidwrighton
Update AvxVnni tests
3feef7f
@davidwrighton
Port General tests
eee679c
@davidwrighton
Lzcnt tests
df37224
@davidwrighton
Popcnt tests
9e51993
@davidwrighton
Improve global test wrapper
1a98b02
@davidwrighton
X86 regression tests
92a7a06
@davidwrighton
Sse1 tests
f81f562
@davidwrighton
Sse41 tests
1977c40
@davidwrighton
Sse3 tests
fe4d4fc
@davidwrighton
Sse42
f25c2b9
@davidwrighton
X86Base and X86Serialize tests
0bf1736
@davidwrighton
Fix a few minor issues
eee6e4b
@davidwrighton
Fix overlapping names so that the tests can be combined into a very l…
44907ff
…arge merged wrapper
@davidwrighton
Tweak xunit wrapper generator to break tests up into groups of 100 so…
8118819
… that we don't create an excessively large single method
@davidwrighton
Remove hardware intrinsics test groupings as they are no longer relevant
60ec3d7
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 4, 2022

Closed

2 tasks
@davidwrighton
Move another set of test ActiveIssues to attributes from issues.targets
50a712c
- Fix the ActiveIssue with a conditional member implementation in the test source generator
- Tweak down the number of methods per test gen method again. There's still a LOT of them
@davidwrighton
Merge branch 'main' of github.com:dotnet/runtime into HardwareIntrins…
6b36937
…icsTestsInNewStyle
davidwrighton added a commit
to davidwrighton/runtime
that referenced
this pull request
Nov 4, 2022
@davidwrighton
Improve coreclr test infra
869211f
These fixes were built for PR dotnet#74886; however, as that PR is so utterly large an unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
@davidwrightondavidwrighton
mentioned this pull request
Nov 4, 2022
 Merged

@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-androidemulator
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
davidwrighton added a commit
that referenced
this pull request
Nov 8, 2022
@davidwrighton
Improve coreclr test infra (#77929)
939f050
These fixes were built for PR #74886; however, as that PR is so utterly large and unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
- Add some documentation about project files for coreclr tests, as well as some documentation on the command line parameters for merged test runner assemblies
davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/zapsig.cpp
Outdated

davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperLibrary/TestFilter.cs
Outdated

tannergooding
tannergooding
reviewed
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/AdvSimd.Arm64/Abs.Vector128.Double.cs
using Xunit;

namespace JIT.HardwareIntrinsics.Arm
namespace JIT.HardwareIntrinsics.Arm._AdvSimd.Arm64
@tannergoodingtannergoodingNov 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why the need for the underscore here?
@davidwrightondavidwrightonNov 9, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been quite a while, but I think there was a conflict between a namespace name and class name, and I stuffed in an underscore on the namespace to shut it all up.
tannergooding
tannergooding
approved these changes
Nov 9, 2022
View reviewed changes
@tannergoodingtannergooding
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Fairly mechanical in nature
@davidwrighton
davidwrighton
commented
Nov 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Nov 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@davidwrightondavidwrighton
mentioned this pull request
Nov 10, 2022
 Merged

@davidwrighton
davidwrighton
merged commit 2095119
into
dotnet:mainNov 11, 2022

This was referenced Nov 14, 2022

Open

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 12, 2022
@davidwrighton
davidwrighton
deleted the

HardwareIntrinsicsTestsInNewStyle

branch
April 13, 2023 18:54
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky

Assignees

@davidwrightondavidwrighton

Labels

area-System.Runtime.Intrinsicstest-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@davidwrighton@lambdageek@steveisok@tannergooding@steveharter@dakersnar@buyaa-n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Hardware intrinsics tests in new style by davidwrighton · Pull Request #74886 · dotnet/runtime · GitHub
Skip to content
Hardware intrinsics tests in new style - #74886
Merged
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Nov 11, 2022
Merged
Hardware intrinsics tests in new style#74886
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Aug 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Port all of the vector tests to the new xunit style specification
  • Test disables need to use the attribute based form
  • All tests are run on all architectures (This wasn't happening in the old system, but hopefully with test striping the need for this has gone away.)
  • The xunit wrapper generator generated methods which are too big for the merged assembly as designed earlier. I've broken that up into chunks of 100 methods each which seems to have solved that problem.
  • The xunit wrapper generator and runner have issues with running this many tests under GCStress, I've implemented a striping scheme to allow these tests to run across more machines when running under GCStress.
@davidwrighton
Convert Arm and General vector intrinsics to new style tests
f0a9246
- Except for General\HwiOp tests
- Also I've found that the Vector128<Single>.Dot test is failing due to floating point precision issues. Adding a fuzzy comparison seems to have fixed that, but I don't know why it isn't failing more often today.
@davidwrighton
Port Hwi tests
a2de0eb
@davidwrighton
Fix missed test templates on arm scenarios
36328e3
@davidwrighton
Port some of the X86 vector tests over
9268e95
@davidwrighton
Remove OutputType from General projects
4c436cb
@davidwrighton
Set BuildAsStandalone more reliably
059b1b8
@davidwrighton
Fix CoreCLRTestLibrary merged build problem
9ec9cc9
@davidwrighton
Hah, the tests actually run
598c1df
@davidwrighton
Finish converting projects that did not yet have BuildAsStandalone set
f2a850d
@davidwrighton
Update all x86 autogenerated tests to build properly and not have con…
b6754c4
…flicts
@davidwrighton
Port handwritten SSE2 tests to new test structure
6e7a01c
- And consolidate them so that they all compile with a single project file
@davidwrighton
Convert SSE2.X64 handwritten test to new system
eea9a83
@davidwrighton
Update Avx1 tests to new world order
0f1f35f
@davidwrighton
Convert handwritten Avx2 tests
874aec9
@davidwrighton
Update AvxVnni tests
3feef7f
@davidwrighton
Port General tests
eee679c
@davidwrighton
Lzcnt tests
df37224
@davidwrighton
Popcnt tests
9e51993
@davidwrighton
Improve global test wrapper
1a98b02
@davidwrighton
X86 regression tests
92a7a06
@davidwrighton
Sse1 tests
f81f562
@davidwrighton
Sse41 tests
1977c40
@davidwrighton
Sse3 tests
fe4d4fc
@davidwrighton
Sse42
f25c2b9
@davidwrighton
X86Base and X86Serialize tests
0bf1736
@davidwrighton
Fix a few minor issues
eee6e4b
@davidwrighton
Fix overlapping names so that the tests can be combined into a very l…
44907ff
…arge merged wrapper
@davidwrighton
Tweak xunit wrapper generator to break tests up into groups of 100 so…
8118819
… that we don't create an excessively large single method
@davidwrighton
Remove hardware intrinsics test groupings as they are no longer relevant
60ec3d7
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 4, 2022

Closed

2 tasks
@davidwrighton
Move another set of test ActiveIssues to attributes from issues.targets
50a712c
- Fix the ActiveIssue with a conditional member implementation in the test source generator
- Tweak down the number of methods per test gen method again. There's still a LOT of them
@davidwrighton
Merge branch 'main' of github.com:dotnet/runtime into HardwareIntrins…
6b36937
…icsTestsInNewStyle
davidwrighton added a commit
to davidwrighton/runtime
that referenced
this pull request
Nov 4, 2022
@davidwrighton
Improve coreclr test infra
869211f
These fixes were built for PR dotnet#74886; however, as that PR is so utterly large an unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
@davidwrightondavidwrighton
mentioned this pull request
Nov 4, 2022
 Merged

@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-androidemulator
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
davidwrighton added a commit
that referenced
this pull request
Nov 8, 2022
@davidwrighton
Improve coreclr test infra (#77929)
939f050
These fixes were built for PR #74886; however, as that PR is so utterly large and unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
- Add some documentation about project files for coreclr tests, as well as some documentation on the command line parameters for merged test runner assemblies
davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/zapsig.cpp
Outdated

davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperLibrary/TestFilter.cs
Outdated

tannergooding
tannergooding
reviewed
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/AdvSimd.Arm64/Abs.Vector128.Double.cs
using Xunit;

namespace JIT.HardwareIntrinsics.Arm
namespace JIT.HardwareIntrinsics.Arm._AdvSimd.Arm64
@tannergoodingtannergoodingNov 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why the need for the underscore here?
@davidwrightondavidwrightonNov 9, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been quite a while, but I think there was a conflict between a namespace name and class name, and I stuffed in an underscore on the namespace to shut it all up.
tannergooding
tannergooding
approved these changes
Nov 9, 2022
View reviewed changes
@tannergoodingtannergooding
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Fairly mechanical in nature
@davidwrighton
davidwrighton
commented
Nov 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Nov 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@davidwrightondavidwrighton
mentioned this pull request
Nov 10, 2022
 Merged

@davidwrighton
davidwrighton
merged commit 2095119
into
dotnet:mainNov 11, 2022

This was referenced Nov 14, 2022

Open

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 12, 2022
@davidwrighton
davidwrighton
deleted the

HardwareIntrinsicsTestsInNewStyle

branch
April 13, 2023 18:54
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky

Assignees

@davidwrightondavidwrighton

Labels

area-System.Runtime.Intrinsicstest-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@davidwrighton@lambdageek@steveisok@tannergooding@steveharter@dakersnar@buyaa-n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Hardware intrinsics tests in new style by davidwrighton · Pull Request #74886 · dotnet/runtime · GitHub
Skip to content
Hardware intrinsics tests in new style - #74886
Merged
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Nov 11, 2022
Merged
Hardware intrinsics tests in new style#74886
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Aug 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Port all of the vector tests to the new xunit style specification
  • Test disables need to use the attribute based form
  • All tests are run on all architectures (This wasn't happening in the old system, but hopefully with test striping the need for this has gone away.)
  • The xunit wrapper generator generated methods which are too big for the merged assembly as designed earlier. I've broken that up into chunks of 100 methods each which seems to have solved that problem.
  • The xunit wrapper generator and runner have issues with running this many tests under GCStress, I've implemented a striping scheme to allow these tests to run across more machines when running under GCStress.
@davidwrighton
Convert Arm and General vector intrinsics to new style tests
f0a9246
- Except for General\HwiOp tests
- Also I've found that the Vector128<Single>.Dot test is failing due to floating point precision issues. Adding a fuzzy comparison seems to have fixed that, but I don't know why it isn't failing more often today.
@davidwrighton
Port Hwi tests
a2de0eb
@davidwrighton
Fix missed test templates on arm scenarios
36328e3
@davidwrighton
Port some of the X86 vector tests over
9268e95
@davidwrighton
Remove OutputType from General projects
4c436cb
@davidwrighton
Set BuildAsStandalone more reliably
059b1b8
@davidwrighton
Fix CoreCLRTestLibrary merged build problem
9ec9cc9
@davidwrighton
Hah, the tests actually run
598c1df
@davidwrighton
Finish converting projects that did not yet have BuildAsStandalone set
f2a850d
@davidwrighton
Update all x86 autogenerated tests to build properly and not have con…
b6754c4
…flicts
@davidwrighton
Port handwritten SSE2 tests to new test structure
6e7a01c
- And consolidate them so that they all compile with a single project file
@davidwrighton
Convert SSE2.X64 handwritten test to new system
eea9a83
@davidwrighton
Update Avx1 tests to new world order
0f1f35f
@davidwrighton
Convert handwritten Avx2 tests
874aec9
@davidwrighton
Update AvxVnni tests
3feef7f
@davidwrighton
Port General tests
eee679c
@davidwrighton
Lzcnt tests
df37224
@davidwrighton
Popcnt tests
9e51993
@davidwrighton
Improve global test wrapper
1a98b02
@davidwrighton
X86 regression tests
92a7a06
@davidwrighton
Sse1 tests
f81f562
@davidwrighton
Sse41 tests
1977c40
@davidwrighton
Sse3 tests
fe4d4fc
@davidwrighton
Sse42
f25c2b9
@davidwrighton
X86Base and X86Serialize tests
0bf1736
@davidwrighton
Fix a few minor issues
eee6e4b
@davidwrighton
Fix overlapping names so that the tests can be combined into a very l…
44907ff
…arge merged wrapper
@davidwrighton
Tweak xunit wrapper generator to break tests up into groups of 100 so…
8118819
… that we don't create an excessively large single method
@davidwrighton
Remove hardware intrinsics test groupings as they are no longer relevant
60ec3d7
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 4, 2022

Closed

2 tasks
@davidwrighton
Move another set of test ActiveIssues to attributes from issues.targets
50a712c
- Fix the ActiveIssue with a conditional member implementation in the test source generator
- Tweak down the number of methods per test gen method again. There's still a LOT of them
@davidwrighton
Merge branch 'main' of github.com:dotnet/runtime into HardwareIntrins…
6b36937
…icsTestsInNewStyle
davidwrighton added a commit
to davidwrighton/runtime
that referenced
this pull request
Nov 4, 2022
@davidwrighton
Improve coreclr test infra
869211f
These fixes were built for PR dotnet#74886; however, as that PR is so utterly large an unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
@davidwrightondavidwrighton
mentioned this pull request
Nov 4, 2022
 Merged

@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-androidemulator
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
davidwrighton added a commit
that referenced
this pull request
Nov 8, 2022
@davidwrighton
Improve coreclr test infra (#77929)
939f050
These fixes were built for PR #74886; however, as that PR is so utterly large and unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
- Add some documentation about project files for coreclr tests, as well as some documentation on the command line parameters for merged test runner assemblies
davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/zapsig.cpp
Outdated

davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperLibrary/TestFilter.cs
Outdated

tannergooding
tannergooding
reviewed
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/AdvSimd.Arm64/Abs.Vector128.Double.cs
using Xunit;

namespace JIT.HardwareIntrinsics.Arm
namespace JIT.HardwareIntrinsics.Arm._AdvSimd.Arm64
@tannergoodingtannergoodingNov 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why the need for the underscore here?
@davidwrightondavidwrightonNov 9, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been quite a while, but I think there was a conflict between a namespace name and class name, and I stuffed in an underscore on the namespace to shut it all up.
tannergooding
tannergooding
approved these changes
Nov 9, 2022
View reviewed changes
@tannergoodingtannergooding
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Fairly mechanical in nature
@davidwrighton
davidwrighton
commented
Nov 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Nov 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@davidwrightondavidwrighton
mentioned this pull request
Nov 10, 2022
 Merged

@davidwrighton
davidwrighton
merged commit 2095119
into
dotnet:mainNov 11, 2022

This was referenced Nov 14, 2022

Open

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 12, 2022
@davidwrighton
davidwrighton
deleted the

HardwareIntrinsicsTestsInNewStyle

branch
April 13, 2023 18:54
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky

Assignees

@davidwrightondavidwrighton

Labels

area-System.Runtime.Intrinsicstest-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@davidwrighton@lambdageek@steveisok@tannergooding@steveharter@dakersnar@buyaa-n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Hardware intrinsics tests in new style by davidwrighton · Pull Request #74886 · dotnet/runtime · GitHub
Skip to content
Hardware intrinsics tests in new style - #74886
Merged
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Nov 11, 2022
Merged
Hardware intrinsics tests in new style#74886
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Aug 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Port all of the vector tests to the new xunit style specification
  • Test disables need to use the attribute based form
  • All tests are run on all architectures (This wasn't happening in the old system, but hopefully with test striping the need for this has gone away.)
  • The xunit wrapper generator generated methods which are too big for the merged assembly as designed earlier. I've broken that up into chunks of 100 methods each which seems to have solved that problem.
  • The xunit wrapper generator and runner have issues with running this many tests under GCStress, I've implemented a striping scheme to allow these tests to run across more machines when running under GCStress.
@davidwrighton
Convert Arm and General vector intrinsics to new style tests
f0a9246
- Except for General\HwiOp tests
- Also I've found that the Vector128<Single>.Dot test is failing due to floating point precision issues. Adding a fuzzy comparison seems to have fixed that, but I don't know why it isn't failing more often today.
@davidwrighton
Port Hwi tests
a2de0eb
@davidwrighton
Fix missed test templates on arm scenarios
36328e3
@davidwrighton
Port some of the X86 vector tests over
9268e95
@davidwrighton
Remove OutputType from General projects
4c436cb
@davidwrighton
Set BuildAsStandalone more reliably
059b1b8
@davidwrighton
Fix CoreCLRTestLibrary merged build problem
9ec9cc9
@davidwrighton
Hah, the tests actually run
598c1df
@davidwrighton
Finish converting projects that did not yet have BuildAsStandalone set
f2a850d
@davidwrighton
Update all x86 autogenerated tests to build properly and not have con…
b6754c4
…flicts
@davidwrighton
Port handwritten SSE2 tests to new test structure
6e7a01c
- And consolidate them so that they all compile with a single project file
@davidwrighton
Convert SSE2.X64 handwritten test to new system
eea9a83
@davidwrighton
Update Avx1 tests to new world order
0f1f35f
@davidwrighton
Convert handwritten Avx2 tests
874aec9
@davidwrighton
Update AvxVnni tests
3feef7f
@davidwrighton
Port General tests
eee679c
@davidwrighton
Lzcnt tests
df37224
@davidwrighton
Popcnt tests
9e51993
@davidwrighton
Improve global test wrapper
1a98b02
@davidwrighton
X86 regression tests
92a7a06
@davidwrighton
Sse1 tests
f81f562
@davidwrighton
Sse41 tests
1977c40
@davidwrighton
Sse3 tests
fe4d4fc
@davidwrighton
Sse42
f25c2b9
@davidwrighton
X86Base and X86Serialize tests
0bf1736
@davidwrighton
Fix a few minor issues
eee6e4b
@davidwrighton
Fix overlapping names so that the tests can be combined into a very l…
44907ff
…arge merged wrapper
@davidwrighton
Tweak xunit wrapper generator to break tests up into groups of 100 so…
8118819
… that we don't create an excessively large single method
@davidwrighton
Remove hardware intrinsics test groupings as they are no longer relevant
60ec3d7
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 4, 2022

Closed

2 tasks
@davidwrighton
Move another set of test ActiveIssues to attributes from issues.targets
50a712c
- Fix the ActiveIssue with a conditional member implementation in the test source generator
- Tweak down the number of methods per test gen method again. There's still a LOT of them
@davidwrighton
Merge branch 'main' of github.com:dotnet/runtime into HardwareIntrins…
6b36937
…icsTestsInNewStyle
davidwrighton added a commit
to davidwrighton/runtime
that referenced
this pull request
Nov 4, 2022
@davidwrighton
Improve coreclr test infra
869211f
These fixes were built for PR dotnet#74886; however, as that PR is so utterly large an unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
@davidwrightondavidwrighton
mentioned this pull request
Nov 4, 2022
 Merged

@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-androidemulator
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
davidwrighton added a commit
that referenced
this pull request
Nov 8, 2022
@davidwrighton
Improve coreclr test infra (#77929)
939f050
These fixes were built for PR #74886; however, as that PR is so utterly large and unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
- Add some documentation about project files for coreclr tests, as well as some documentation on the command line parameters for merged test runner assemblies
davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/zapsig.cpp
Outdated

davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperLibrary/TestFilter.cs
Outdated

tannergooding
tannergooding
reviewed
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/AdvSimd.Arm64/Abs.Vector128.Double.cs
using Xunit;

namespace JIT.HardwareIntrinsics.Arm
namespace JIT.HardwareIntrinsics.Arm._AdvSimd.Arm64
@tannergoodingtannergoodingNov 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why the need for the underscore here?
@davidwrightondavidwrightonNov 9, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been quite a while, but I think there was a conflict between a namespace name and class name, and I stuffed in an underscore on the namespace to shut it all up.
tannergooding
tannergooding
approved these changes
Nov 9, 2022
View reviewed changes
@tannergoodingtannergooding
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Fairly mechanical in nature
@davidwrighton
davidwrighton
commented
Nov 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Nov 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@davidwrightondavidwrighton
mentioned this pull request
Nov 10, 2022
 Merged

@davidwrighton
davidwrighton
merged commit 2095119
into
dotnet:mainNov 11, 2022

This was referenced Nov 14, 2022

Open

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 12, 2022
@davidwrighton
davidwrighton
deleted the

HardwareIntrinsicsTestsInNewStyle

branch
April 13, 2023 18:54
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky

Assignees

@davidwrightondavidwrighton

Labels

area-System.Runtime.Intrinsicstest-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@davidwrighton@lambdageek@steveisok@tannergooding@steveharter@dakersnar@buyaa-n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Hardware intrinsics tests in new style by davidwrighton · Pull Request #74886 · dotnet/runtime · GitHub
Skip to content
Hardware intrinsics tests in new style - #74886
Merged
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Nov 11, 2022
Merged
Hardware intrinsics tests in new style#74886
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Aug 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Port all of the vector tests to the new xunit style specification
  • Test disables need to use the attribute based form
  • All tests are run on all architectures (This wasn't happening in the old system, but hopefully with test striping the need for this has gone away.)
  • The xunit wrapper generator generated methods which are too big for the merged assembly as designed earlier. I've broken that up into chunks of 100 methods each which seems to have solved that problem.
  • The xunit wrapper generator and runner have issues with running this many tests under GCStress, I've implemented a striping scheme to allow these tests to run across more machines when running under GCStress.
@davidwrighton
Convert Arm and General vector intrinsics to new style tests
f0a9246
- Except for General\HwiOp tests
- Also I've found that the Vector128<Single>.Dot test is failing due to floating point precision issues. Adding a fuzzy comparison seems to have fixed that, but I don't know why it isn't failing more often today.
@davidwrighton
Port Hwi tests
a2de0eb
@davidwrighton
Fix missed test templates on arm scenarios
36328e3
@davidwrighton
Port some of the X86 vector tests over
9268e95
@davidwrighton
Remove OutputType from General projects
4c436cb
@davidwrighton
Set BuildAsStandalone more reliably
059b1b8
@davidwrighton
Fix CoreCLRTestLibrary merged build problem
9ec9cc9
@davidwrighton
Hah, the tests actually run
598c1df
@davidwrighton
Finish converting projects that did not yet have BuildAsStandalone set
f2a850d
@davidwrighton
Update all x86 autogenerated tests to build properly and not have con…
b6754c4
…flicts
@davidwrighton
Port handwritten SSE2 tests to new test structure
6e7a01c
- And consolidate them so that they all compile with a single project file
@davidwrighton
Convert SSE2.X64 handwritten test to new system
eea9a83
@davidwrighton
Update Avx1 tests to new world order
0f1f35f
@davidwrighton
Convert handwritten Avx2 tests
874aec9
@davidwrighton
Update AvxVnni tests
3feef7f
@davidwrighton
Port General tests
eee679c
@davidwrighton
Lzcnt tests
df37224
@davidwrighton
Popcnt tests
9e51993
@davidwrighton
Improve global test wrapper
1a98b02
@davidwrighton
X86 regression tests
92a7a06
@davidwrighton
Sse1 tests
f81f562
@davidwrighton
Sse41 tests
1977c40
@davidwrighton
Sse3 tests
fe4d4fc
@davidwrighton
Sse42
f25c2b9
@davidwrighton
X86Base and X86Serialize tests
0bf1736
@davidwrighton
Fix a few minor issues
eee6e4b
@davidwrighton
Fix overlapping names so that the tests can be combined into a very l…
44907ff
…arge merged wrapper
@davidwrighton
Tweak xunit wrapper generator to break tests up into groups of 100 so…
8118819
… that we don't create an excessively large single method
@davidwrighton
Remove hardware intrinsics test groupings as they are no longer relevant
60ec3d7
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 4, 2022

Closed

2 tasks
@davidwrighton
Move another set of test ActiveIssues to attributes from issues.targets
50a712c
- Fix the ActiveIssue with a conditional member implementation in the test source generator
- Tweak down the number of methods per test gen method again. There's still a LOT of them
@davidwrighton
Merge branch 'main' of github.com:dotnet/runtime into HardwareIntrins…
6b36937
…icsTestsInNewStyle
davidwrighton added a commit
to davidwrighton/runtime
that referenced
this pull request
Nov 4, 2022
@davidwrighton
Improve coreclr test infra
869211f
These fixes were built for PR dotnet#74886; however, as that PR is so utterly large an unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
@davidwrightondavidwrighton
mentioned this pull request
Nov 4, 2022
 Merged

@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-androidemulator
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
davidwrighton added a commit
that referenced
this pull request
Nov 8, 2022
@davidwrighton
Improve coreclr test infra (#77929)
939f050
These fixes were built for PR #74886; however, as that PR is so utterly large and unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
- Add some documentation about project files for coreclr tests, as well as some documentation on the command line parameters for merged test runner assemblies
davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/zapsig.cpp
Outdated

davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperLibrary/TestFilter.cs
Outdated

tannergooding
tannergooding
reviewed
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/AdvSimd.Arm64/Abs.Vector128.Double.cs
using Xunit;

namespace JIT.HardwareIntrinsics.Arm
namespace JIT.HardwareIntrinsics.Arm._AdvSimd.Arm64
@tannergoodingtannergoodingNov 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why the need for the underscore here?
@davidwrightondavidwrightonNov 9, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been quite a while, but I think there was a conflict between a namespace name and class name, and I stuffed in an underscore on the namespace to shut it all up.
tannergooding
tannergooding
approved these changes
Nov 9, 2022
View reviewed changes
@tannergoodingtannergooding
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Fairly mechanical in nature
@davidwrighton
davidwrighton
commented
Nov 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Nov 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@davidwrightondavidwrighton
mentioned this pull request
Nov 10, 2022
 Merged

@davidwrighton
davidwrighton
merged commit 2095119
into
dotnet:mainNov 11, 2022

This was referenced Nov 14, 2022

Open

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 12, 2022
@davidwrighton
davidwrighton
deleted the

HardwareIntrinsicsTestsInNewStyle

branch
April 13, 2023 18:54
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky

Assignees

@davidwrightondavidwrighton

Labels

area-System.Runtime.Intrinsicstest-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@davidwrighton@lambdageek@steveisok@tannergooding@steveharter@dakersnar@buyaa-n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Hardware intrinsics tests in new style by davidwrighton · Pull Request #74886 · dotnet/runtime · GitHub
Skip to content
Hardware intrinsics tests in new style - #74886
Merged
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Nov 11, 2022
Merged
Hardware intrinsics tests in new style#74886
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Aug 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Port all of the vector tests to the new xunit style specification
  • Test disables need to use the attribute based form
  • All tests are run on all architectures (This wasn't happening in the old system, but hopefully with test striping the need for this has gone away.)
  • The xunit wrapper generator generated methods which are too big for the merged assembly as designed earlier. I've broken that up into chunks of 100 methods each which seems to have solved that problem.
  • The xunit wrapper generator and runner have issues with running this many tests under GCStress, I've implemented a striping scheme to allow these tests to run across more machines when running under GCStress.
@davidwrighton
Convert Arm and General vector intrinsics to new style tests
f0a9246
- Except for General\HwiOp tests
- Also I've found that the Vector128<Single>.Dot test is failing due to floating point precision issues. Adding a fuzzy comparison seems to have fixed that, but I don't know why it isn't failing more often today.
@davidwrighton
Port Hwi tests
a2de0eb
@davidwrighton
Fix missed test templates on arm scenarios
36328e3
@davidwrighton
Port some of the X86 vector tests over
9268e95
@davidwrighton
Remove OutputType from General projects
4c436cb
@davidwrighton
Set BuildAsStandalone more reliably
059b1b8
@davidwrighton
Fix CoreCLRTestLibrary merged build problem
9ec9cc9
@davidwrighton
Hah, the tests actually run
598c1df
@davidwrighton
Finish converting projects that did not yet have BuildAsStandalone set
f2a850d
@davidwrighton
Update all x86 autogenerated tests to build properly and not have con…
b6754c4
…flicts
@davidwrighton
Port handwritten SSE2 tests to new test structure
6e7a01c
- And consolidate them so that they all compile with a single project file
@davidwrighton
Convert SSE2.X64 handwritten test to new system
eea9a83
@davidwrighton
Update Avx1 tests to new world order
0f1f35f
@davidwrighton
Convert handwritten Avx2 tests
874aec9
@davidwrighton
Update AvxVnni tests
3feef7f
@davidwrighton
Port General tests
eee679c
@davidwrighton
Lzcnt tests
df37224
@davidwrighton
Popcnt tests
9e51993
@davidwrighton
Improve global test wrapper
1a98b02
@davidwrighton
X86 regression tests
92a7a06
@davidwrighton
Sse1 tests
f81f562
@davidwrighton
Sse41 tests
1977c40
@davidwrighton
Sse3 tests
fe4d4fc
@davidwrighton
Sse42
f25c2b9
@davidwrighton
X86Base and X86Serialize tests
0bf1736
@davidwrighton
Fix a few minor issues
eee6e4b
@davidwrighton
Fix overlapping names so that the tests can be combined into a very l…
44907ff
…arge merged wrapper
@davidwrighton
Tweak xunit wrapper generator to break tests up into groups of 100 so…
8118819
… that we don't create an excessively large single method
@davidwrighton
Remove hardware intrinsics test groupings as they are no longer relevant
60ec3d7
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 4, 2022

Closed

2 tasks
@davidwrighton
Move another set of test ActiveIssues to attributes from issues.targets
50a712c
- Fix the ActiveIssue with a conditional member implementation in the test source generator
- Tweak down the number of methods per test gen method again. There's still a LOT of them
@davidwrighton
Merge branch 'main' of github.com:dotnet/runtime into HardwareIntrins…
6b36937
…icsTestsInNewStyle
davidwrighton added a commit
to davidwrighton/runtime
that referenced
this pull request
Nov 4, 2022
@davidwrighton
Improve coreclr test infra
869211f
These fixes were built for PR dotnet#74886; however, as that PR is so utterly large an unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
@davidwrightondavidwrighton
mentioned this pull request
Nov 4, 2022
 Merged

@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-androidemulator
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
davidwrighton added a commit
that referenced
this pull request
Nov 8, 2022
@davidwrighton
Improve coreclr test infra (#77929)
939f050
These fixes were built for PR #74886; however, as that PR is so utterly large and unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
- Add some documentation about project files for coreclr tests, as well as some documentation on the command line parameters for merged test runner assemblies
davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/zapsig.cpp
Outdated

davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperLibrary/TestFilter.cs
Outdated

tannergooding
tannergooding
reviewed
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/AdvSimd.Arm64/Abs.Vector128.Double.cs
using Xunit;

namespace JIT.HardwareIntrinsics.Arm
namespace JIT.HardwareIntrinsics.Arm._AdvSimd.Arm64
@tannergoodingtannergoodingNov 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why the need for the underscore here?
@davidwrightondavidwrightonNov 9, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been quite a while, but I think there was a conflict between a namespace name and class name, and I stuffed in an underscore on the namespace to shut it all up.
tannergooding
tannergooding
approved these changes
Nov 9, 2022
View reviewed changes
@tannergoodingtannergooding
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Fairly mechanical in nature
@davidwrighton
davidwrighton
commented
Nov 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Nov 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@davidwrightondavidwrighton
mentioned this pull request
Nov 10, 2022
 Merged

@davidwrighton
davidwrighton
merged commit 2095119
into
dotnet:mainNov 11, 2022

This was referenced Nov 14, 2022

Open

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 12, 2022
@davidwrighton
davidwrighton
deleted the

HardwareIntrinsicsTestsInNewStyle

branch
April 13, 2023 18:54
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky

Assignees

@davidwrightondavidwrighton

Labels

area-System.Runtime.Intrinsicstest-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@davidwrighton@lambdageek@steveisok@tannergooding@steveharter@dakersnar@buyaa-n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Hardware intrinsics tests in new style by davidwrighton · Pull Request #74886 · dotnet/runtime · GitHub
Skip to content
Hardware intrinsics tests in new style - #74886
Merged
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Nov 11, 2022
Merged
Hardware intrinsics tests in new style#74886
davidwrighton merged 56 commits into
dotnet:mainfrom 
davidwrighton:HardwareIntrinsicsTestsInNewStyle
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Aug 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Port all of the vector tests to the new xunit style specification
  • Test disables need to use the attribute based form
  • All tests are run on all architectures (This wasn't happening in the old system, but hopefully with test striping the need for this has gone away.)
  • The xunit wrapper generator generated methods which are too big for the merged assembly as designed earlier. I've broken that up into chunks of 100 methods each which seems to have solved that problem.
  • The xunit wrapper generator and runner have issues with running this many tests under GCStress, I've implemented a striping scheme to allow these tests to run across more machines when running under GCStress.
@davidwrighton
Convert Arm and General vector intrinsics to new style tests
f0a9246
- Except for General\HwiOp tests
- Also I've found that the Vector128<Single>.Dot test is failing due to floating point precision issues. Adding a fuzzy comparison seems to have fixed that, but I don't know why it isn't failing more often today.
@davidwrighton
Port Hwi tests
a2de0eb
@davidwrighton
Fix missed test templates on arm scenarios
36328e3
@davidwrighton
Port some of the X86 vector tests over
9268e95
@davidwrighton
Remove OutputType from General projects
4c436cb
@davidwrighton
Set BuildAsStandalone more reliably
059b1b8
@davidwrighton
Fix CoreCLRTestLibrary merged build problem
9ec9cc9
@davidwrighton
Hah, the tests actually run
598c1df
@davidwrighton
Finish converting projects that did not yet have BuildAsStandalone set
f2a850d
@davidwrighton
Update all x86 autogenerated tests to build properly and not have con…
b6754c4
…flicts
@davidwrighton
Port handwritten SSE2 tests to new test structure
6e7a01c
- And consolidate them so that they all compile with a single project file
@davidwrighton
Convert SSE2.X64 handwritten test to new system
eea9a83
@davidwrighton
Update Avx1 tests to new world order
0f1f35f
@davidwrighton
Convert handwritten Avx2 tests
874aec9
@davidwrighton
Update AvxVnni tests
3feef7f
@davidwrighton
Port General tests
eee679c
@davidwrighton
Lzcnt tests
df37224
@davidwrighton
Popcnt tests
9e51993
@davidwrighton
Improve global test wrapper
1a98b02
@davidwrighton
X86 regression tests
92a7a06
@davidwrighton
Sse1 tests
f81f562
@davidwrighton
Sse41 tests
1977c40
@davidwrighton
Sse3 tests
fe4d4fc
@davidwrighton
Sse42
f25c2b9
@davidwrighton
X86Base and X86Serialize tests
0bf1736
@davidwrighton
Fix a few minor issues
eee6e4b
@davidwrighton
Fix overlapping names so that the tests can be combined into a very l…
44907ff
…arge merged wrapper
@davidwrighton
Tweak xunit wrapper generator to break tests up into groups of 100 so…
8118819
… that we don't create an excessively large single method
@davidwrighton
Remove hardware intrinsics test groupings as they are no longer relevant
60ec3d7
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 4, 2022

Closed

2 tasks
@davidwrighton
Move another set of test ActiveIssues to attributes from issues.targets
50a712c
- Fix the ActiveIssue with a conditional member implementation in the test source generator
- Tweak down the number of methods per test gen method again. There's still a LOT of them
@davidwrighton
Merge branch 'main' of github.com:dotnet/runtime into HardwareIntrins…
6b36937
…icsTestsInNewStyle
davidwrighton added a commit
to davidwrighton/runtime
that referenced
this pull request
Nov 4, 2022
@davidwrighton
Improve coreclr test infra
869211f
These fixes were built for PR dotnet#74886; however, as that PR is so utterly large an unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
@davidwrightondavidwrighton
mentioned this pull request
Nov 4, 2022
 Merged

@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp list
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


CI/CD Pipelines for this repository:
@davidwrighton
davidwrighton
commented
Nov 7, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-androidemulator
@azure-pipelines
azure-pipelinesBot
commented
Nov 7, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
davidwrighton added a commit
that referenced
this pull request
Nov 8, 2022
@davidwrighton
Improve coreclr test infra (#77929)
939f050
These fixes were built for PR #74886; however, as that PR is so utterly large and unreviewable, I've pulled out the test infra changes for separate review
Changes
- Increase the number of trampolines in the llvm aot compilation process to 20,000 from 10,000 (This avoids running out of them in some of the hardware intrinsics tests
- Add a concept of striping tests when running under GC stress
- To use this new feature, specify <NumberOfStripesToUseInStress>N</NumberOfStripesToUseInStress> within the merged test assembly. If this value is set, then the tests within that merged test assembly will be run across N different work items instead of 1 when running under any form of GC stress based scenario. At this moment the largest supported value of N is 99
- Emit the testresults.xml file as a file which is exported from the tests. This is useful for debugging testresult.xml parsing failures
- Fix the testresults summary generator to never emit an empty CDATA string. If one is present the parser may fail the parse.
- In the XUnitWrapperGenerator fix the implementation of the Outerloop and ActiveIssue when used with a conditional member.
- Add PlatformDetection.IsMonoLLVMAOT, PlatformDetection.IsMonoLLVMFULLAOT, and PlatformDetection.IsMonoInterpreter boolean properties to the PlatformDetection type for use with the ActiveIssue attribute
- Add some documentation about project files for coreclr tests, as well as some documentation on the command line parameters for merged test runner assemblies
davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/coreclr/vm/zapsig.cpp
Outdated

davidwrighton
davidwrighton
commented
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/Common/XUnitWrapperLibrary/TestFilter.cs
Outdated

tannergooding
tannergooding
reviewed
Nov 9, 2022
View reviewed changes
Comment threadsrc/tests/JIT/HardwareIntrinsics/Arm/AdvSimd.Arm64/Abs.Vector128.Double.cs
using Xunit;

namespace JIT.HardwareIntrinsics.Arm
namespace JIT.HardwareIntrinsics.Arm._AdvSimd.Arm64
@tannergoodingtannergoodingNov 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why the need for the underscore here?
@davidwrightondavidwrightonNov 9, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been quite a while, but I think there was a conflict between a namespace name and class name, and I stuffed in an underscore on the namespace to shut it all up.
tannergooding
tannergooding
approved these changes
Nov 9, 2022
View reviewed changes
@tannergoodingtannergooding
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Fairly mechanical in nature
@davidwrighton
davidwrighton
commented
Nov 9, 2022

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Nov 9, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@davidwrightondavidwrighton
mentioned this pull request
Nov 10, 2022
 Merged

@davidwrighton
davidwrighton
merged commit 2095119
into
dotnet:mainNov 11, 2022

This was referenced Nov 14, 2022

Open

 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 12, 2022
@davidwrighton
davidwrighton
deleted the

HardwareIntrinsicsTestsInNewStyle

branch
April 13, 2023 18:54
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky

Assignees

@davidwrightondavidwrighton

Labels

area-System.Runtime.Intrinsicstest-enhancementImprovements of test source code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@davidwrighton@lambdageek@steveisok@tannergooding@steveharter@dakersnar@buyaa-n