Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Turn in-build signing on - #74941
Merged
Merged
Conversation
ghost
commented
Sep 1, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
mmitche
commented
Sep 1, 2022
MemberAuthor
Test build (with tweaked conditional): https://dev.azure.com/dnceng/internal/_build/results?buildId=1981480&view=results |
carlossanlop
approved these changes
Sep 1, 2022
carlossanlop
left a comment
Contributor
There was a problem hiding this comment.
I assume the CI would show if this failed?
ViktorHofer
approved these changes
Sep 1, 2022
ViktorHofer
commented
Sep 1, 2022
Member
No. The runtime-official.yml pipeline doesn't run publicly on PRs. We will see post-merge if this worked but based on these changes, they should work. |
hoyosjs
approved these changes
Sep 1, 2022
mmitche
commented
Sep 2, 2022
MemberAuthor
mmitche
commented
Sep 2, 2022
MemberAuthor
@carlossanlop can you merge this? org JIT is down so I don't have perms right now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only on in release branches