Uh oh!
There was an error while loading. Please reload this page.
Support hot cold splitting in crossgen2 - #74963
Conversation
52ed3c2 to
05be8ecComparee186ef0 to
bdbab66Compare4ba78a9 to
324b616CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Thanks Andrew, I believe you, Aman and Eugenio have done a great job, overall this looks great to me, I haven't noticed any blocking issues, I have shared a couple of suggestions for local code cleanups and deduplications and I have a few questions regarding bits of code I have a hard time to comprehend but that's about it.
Uh oh!
There was an error while loading. Please reload this page.
trylek
commented
Oct 19, 2022
Please also note that there are some conflicts you'll need to resolve. For lab testing, I suppose we should probably tweak the Crossgen2 pipelines to use the hot-cold code splitting and run the crossgen2 outerloop pipeline with this change. |
I should probably also emphasize that I mostly focused on Crossgen2 and runtime parts of the change, while I think I've been able to mostly follow the intent of the JIT changes, these definitely merit reviewing by a better JIT expert than me. |
324b616 to
7598273Compare
davidwrighton
left a comment
There was a problem hiding this comment.
This generally looks good. I'm looking forward to the tweaks from in response to code review.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Aman Khalid <58230338+amanasifkhalid@users.noreply.github.com> Co-authored-by: Eugenio Peña García <70240915+EugenioPena@users.noreply.github.com>
3a5aed2 to
f17547bCompare
This is a PR created by merging the code from the feature branch on runtimelab.
@amanasifkhalid
@EugenioPena
@dotnet/crossgen-contrib