Skip to content

Update Roslyn compiler build - #75058

Merged
AaronRobinsonMSFT merged 3 commits into
dotnet:mainfrom
cston:update-compiler
Sep 6, 2022
Merged

Update Roslyn compiler build#75058
AaronRobinsonMSFT merged 3 commits into
dotnet:mainfrom
cston:update-compiler

Conversation

@cston

@cstoncston commented Sep 3, 2022

Copy link
Copy Markdown
Contributor

Update to compiler build 4.4.0-3.22431.10 with support for RefSafetyRulesAttribute.

@ghostghost assigned cstonSep 3, 2022
@ghost

ghost commented Sep 3, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@stephentoub

stephentoub commented Sep 3, 2022

Copy link
Copy Markdown
Member

It looks like this is also bringing in dotnet/roslyn#63264 which is causing build failures due to the interop analyzer assembly being referenced multiple times.
cc: @jkoritzinsky, @ViktorHofer

@cston
cston marked this pull request as ready for review September 4, 2022 01:02
@ghost

ghost commented Sep 5, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Update to compiler build 4.4.0-3.22431.10 with support for RefSafetyRulesAttribute.

Author:cston
Assignees:cston
Labels:

area-Infrastructure

Milestone:-

@ViktorHofer

ViktorHofer commented Sep 5, 2022•
edited
Loading

Copy link
Copy Markdown
Member

It looks like this is also bringing in dotnet/roslyn#63264 which is causing build failures due to the interop analyzer assembly being referenced multiple times.

Ack. Will submit a PR to fix the double reference shortly. EDIT: #75083

ViktorHofer added a commit that referenced this pull request Sep 5, 2022
@ViktorHofer
Remove duplicate SourceGeneration generator refs
d1302cc
Unblocks #75058
The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.
@ViktorHoferViktorHofer mentioned this pull request Sep 5, 2022
Merged
ViktorHofer added a commit that referenced this pull request Sep 5, 2022
@ViktorHofer
Remove duplicate SourceGeneration generator refs (#75083)
60be1de
* Remove duplicate SourceGeneration generator refs
Unblocks #75058
The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.
* Update System.Net.Http.csproj
@dotnetdotnet deleted a comment from azure-pipelinesBotSep 5, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotSep 5, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotSep 5, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotSep 5, 2022
github-actionsBot pushed a commit that referenced this pull request Sep 6, 2022
@ViktorHofer
Remove duplicate SourceGeneration generator refs
c68c0ab
Unblocks #75058
The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.
ViktorHofer
ViktorHofer approved these changes Sep 6, 2022
View reviewed changes

@ViktorHoferViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious, will the 7.0-rc1 SDK contain the require compiler bits or do we need a 7.0-rc2 SDK?

@cston
cston requested a review from jaredparSeptember 6, 2022 17:23
@jaredpar

jaredpar commented Sep 6, 2022

Copy link
Copy Markdown
Member

LGTM. Just curious, will the 7.0-rc1 SDK contain the require compiler bits

No.

or do we need a 7.0-rc2 SDK?

The RC2 SDK will have the new bits but they package update effectively shoves the compiler bits into the RC1 SDK.

@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit 538065b into dotnet:mainSep 6, 2022
@cston

cston commented Sep 6, 2022

Copy link
Copy Markdown
ContributorAuthor

/backport to release/7.0

@github-actions

github-actionsBot commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3002694152

@github-actionsgithub-actionsBot mentioned this pull request Sep 6, 2022
Merged
carlossanlop pushed a commit that referenced this pull request Sep 6, 2022
@github-actions@ViktorHofer
[release/7.0] Remove duplicate SourceGeneration generator refs (#75128)
b69e591
* Remove duplicate SourceGeneration generator refs
Unblocks #75058
The listed PR brings in a change in roslyn that errors for duplicate analyzer references. There were only two duplicates in the libraries source projects which are being removed. The actual reference is already brought in via generators.targets.
* Update System.Net.Http.csproj
* Update System.Net.WebSockets.Client.csproj
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
@cston
cston deleted the update-compiler branch September 7, 2022 20:02
@ghostghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@stephentoubstephentoubAwaiting requested review from stephentoub
@jaredparjaredparAwaiting requested review from jaredpar

Assignees

@cstoncston

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cston@stephentoub@ViktorHofer@jaredpar@AaronRobinsonMSFT