') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update Linux/arm, Linux/arm64 cross containers to ones including pip3 by BruceForstall · Pull Request #75167 · dotnet/runtime · GitHub
Skip to content

Update Linux/arm, Linux/arm64 cross containers to ones including pip3 - #75167

Merged
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:UpdateLinuxArmCrossDockerContainers
Sep 8, 2022
Merged

Update Linux/arm, Linux/arm64 cross containers to ones including pip3#75167
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:UpdateLinuxArmCrossDockerContainers

Conversation

@BruceForstall

@BruceForstallBruceForstall commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

@ghost

ghost commented Sep 6, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@BruceForstallBruceForstall mentioned this pull request Sep 6, 2022
Merged
@BruceForstall

BruceForstall commented Sep 6, 2022

Copy link
Copy Markdown
ContributorAuthor

Enables #74961 to upload collections for Linux/arm, Linux/arm64.

@BruceForstall

BruceForstall commented Sep 6, 2022

Copy link
Copy Markdown
ContributorAuthor

@kunalspathak @dotnet/jit-contrib PTAL

@BruceForstallBruceForstall mentioned this pull request Sep 6, 2022
Merged
@BruceForstall

BruceForstall commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Discussion about the failures here is over in dotnet/dotnet-buildtools-prereqs-docker#681

Namely, the docker images named in this PR aren't quite right.

@BruceForstallBruceForstall mentioned this pull request Sep 7, 2022
Closed
am11
am11 reviewed Sep 7, 2022
View reviewed changes

@am11am11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest tags are always published at https://github.com/dotnet/versions/blob/main/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json, you can search for 18.04/cross/arm/ and arm64/ to find the tags.

(we also have Ubuntu 22.04 cross images with llvm 15 final toolchain released today)

@BruceForstall

BruceForstall commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks, @am11. However, it appears the official build which publishes these Docker images did not succeed the last build (it appears it was manually canceled), and that last build is the one with my changes.

@BruceForstall
BruceForstallforce-pushed the UpdateLinuxArmCrossDockerContainers branch from 6ed1cca to 2053ec0CompareSeptember 7, 2022 18:59
BruceForstall added a commit to BruceForstall/runtime that referenced this pull request Sep 7, 2022
@BruceForstall
Enable Linux/arm and Linux/arm64 JIT rolling builds
7eb2141
dotnet#75167 enables this.
@BruceForstallBruceForstall mentioned this pull request Sep 7, 2022
Merged
@BruceForstall

BruceForstall commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Unrelated:

Downloading 'https://dotnet.microsoft.com/download/dotnet/scripts/v1/dotnet-install.sh'
curl: (92) HTTP/2 stream 0 was not closed cleanly: CANCEL (err 8)
Curl failed; dumping some information about dotnet.microsoft.com for later investigation

@BruceForstall

BruceForstall commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

"Libraries Test Run release mono Linux arm64 Debug" failure is #74795

@BruceForstall

BruceForstall commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib Can I get a review on this?

Once this is merged, it should allow the new SuperPMI coreclr tests "run" collection to succeed on Linux/arm and Linux/arm64.

@BruceForstall

BruceForstall commented Sep 8, 2022

Copy link
Copy Markdown
ContributorAuthor

Anyone?

@kunalspathak

kunalspathak commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Curious, where do you get the version 20220907130538-70ed2e8 from?

@BruceForstall

BruceForstall commented Sep 8, 2022

Copy link
Copy Markdown
ContributorAuthor

Curious, where do you get the version 20220907130538-70ed2e8 from?

After a change to https://github.com/dotnet/dotnet-buildtools-prereqs-docker is merged, an internal build happens that updates https://github.com/dotnet/versions/blob/main/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json with the new container IDs.

@BruceForstall
BruceForstall merged commit 5a2d0db into dotnet:mainSep 8, 2022
@BruceForstall
BruceForstall deleted the UpdateLinuxArmCrossDockerContainers branch September 8, 2022 16:42
BruceForstall added a commit that referenced this pull request Sep 8, 2022
@BruceForstall
Enable Linux/arm and Linux/arm64 JIT rolling builds (#75209)
7806541
#75167 enables this.
@ghostghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
+1 more reviewer
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall@kunalspathak@am11@jakobbotsch