Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Swallow ObjectDisposedException when aborting QuicStream from CancellationAction - #75179
Merged
Merged
Conversation
ghost
commented
Sep 7, 2022
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #74634 to release/7.0 /cc @rzikm Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
danmoseley
commented
Sep 7, 2022
Contributor
approved. stability of new feature area. |
karelz
commented
Sep 8, 2022
Member
The PR this depends on (#75192) has been merged into release/7.0. removing the no-merge and blocked labels. |
liveans
approved these changes
Sep 8, 2022
karelz
approved these changes
Sep 8, 2022
Contributor
Approved, signed off, CI is green (failures seem unrelated), and it's unblocked now. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #74634 to release/7.0
Fixes#73688
This change depends on #75192 (which has been already merged into release/7.0).
/cc @rzikm
Customer Impact
In certain situations, aborting QuicStream operations using
CancellationTokenSource.CancelAftermay cause an exception to be thrown inside ValueTask continuation processing code. The end result is crashing the process on unhandled exception. This PR makes sure we catch and swallow the exception.The exception is not a symptom of a deeper problem, since #75192, the race which causes the exception is harmless.
Discovered in HTTP/3 stress runs and also in CI.
Testing
CI functional tests are passing, also verified manually with local changes to make the race more frequent.
Risk
Low, System.Net.Quic is still in preview.