Skip to content

Fix WebProxy Race Condition Issue - #75193

Merged
liveans merged 4 commits into
dotnet:mainfrom
liveans:webproxy-race-condition-fix-75134
Sep 8, 2022
Merged

Fix WebProxy Race Condition Issue#75193
liveans merged 4 commits into
dotnet:mainfrom
liveans:webproxy-race-condition-fix-75134

Conversation

@liveans

@liveansliveans commented Sep 7, 2022•
edited by karelz
Loading

Copy link
Copy Markdown
Contributor

Fixes#75134

@ghostghost added the area-System.Net label Sep 7, 2022
@ghostghost assigned liveansSep 7, 2022
@ghost

ghost commented Sep 7, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #75134.

Author:liveans
Assignees:-
Labels:

area-System.Net

Milestone:-

@liveans
liveans requested review from a team and MihaZupanSeptember 7, 2022 13:38
MihaZupan
MihaZupan approved these changes Sep 7, 2022
View reviewed changes
Comment threadsrc/libraries/System.Net.WebProxy/src/System/Net/WebProxy.cs Outdated
Comment threadsrc/libraries/System.Net.WebProxy/src/System/Net/WebProxy.cs
MihaZupan
MihaZupan reviewed Sep 7, 2022
View reviewed changes
Comment threadsrc/libraries/System.Net.WebProxy/src/System/Net/WebProxy.cs Outdated
Ahmet İbrahim AKSOY@MihaZupan
Update: Review change
2147cd6
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
stephentoub
stephentoub reviewed Sep 7, 2022
View reviewed changes
Comment threadsrc/libraries/System.Net.WebProxy/src/System/Net/WebProxy.cs
Ahmet İbrahim AKSOY@stephentoub
Update: Add comment to volatile field
d54dd0d
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@liveans
liveans merged commit 01d1c8c into dotnet:mainSep 8, 2022
@liveans

liveans commented Sep 8, 2022

Copy link
Copy Markdown
ContributorAuthor

/backport to release/7.0

@github-actions

github-actionsBot commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3013577795

@github-actionsgithub-actionsBot mentioned this pull request Sep 8, 2022
Merged
@liveansliveans mentioned this pull request Sep 8, 2022
Merged
@karelzkarelz mentioned this pull request Sep 9, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 8, 2022
@karelzkarelz added this to the 8.0.0 milestone Mar 22, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MihaZupanMihaZupanMihaZupan approved these changes
@stephentoubstephentoubstephentoub approved these changes

Assignees

@liveansliveans

Labels

area-System.Net

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Edge-case race condition in WebProxy

4 participants

@liveans@stephentoub@MihaZupan@karelz