Skip to content

[release/7.0] Remove wbt manifest hack - #75197

Merged
lewing merged 1 commit into
dotnet:release/7.0from
lewing:remove-wbt-manifest-hack
Sep 7, 2022
Merged

[release/7.0] Remove wbt manifest hack#75197
lewing merged 1 commit into
dotnet:release/7.0from
lewing:remove-wbt-manifest-hack

Conversation

@lewing

@lewinglewing commented Sep 7, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Now that the latest installer has the new manifest names

@ghostghost assigned lewingSep 7, 2022
@lewing
lewing changed the base branch from main to release/7.0September 7, 2022 14:25
@ghost

ghost commented Sep 7, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Sep 7, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:lewing
Assignees:lewing
Labels:

area-Meta, new-api-needs-documentation

Milestone:-

@lambdageeklambdageek mentioned this pull request Sep 7, 2022
Closed
@steveisoksteveisok mentioned this pull request Sep 7, 2022
Merged
@radical

radical commented Sep 7, 2022

Copy link
Copy Markdown
Member

The WBT failure here is due to network issues.

@carlossanlop

carlossanlop commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

The WBT failure here is due to network issues.

Should the failed legs be restarted then? Several failed.

@carlossanlop

carlossanlop commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

@marek-safar can we get an approval please?

jeffschwMSFT
jeffschwMSFT approved these changes Sep 7, 2022
View reviewed changes

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. Thanks for cleaning up this hack

@radical

radical commented Sep 7, 2022

Copy link
Copy Markdown
Member

@carlossanlop this is ready to go

@lewing
lewing merged commit 4f686c2 into dotnet:release/7.0Sep 7, 2022
@lewing
lewing deleted the remove-wbt-manifest-hack branch September 7, 2022 23:16
@ghostghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@lambdageeklambdageeklambdageek approved these changes
@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@thaystgthaystgAwaiting requested review from thaystg
@vargazvargazAwaiting requested review from vargaz
@BrzVladBrzVladAwaiting requested review from BrzVlad
@nariccnariccAwaiting requested review from naricc
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@lewinglewing

Labels

area-Metanew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lewing@radical@carlossanlop@lambdageek@jeffschwMSFT