') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Remove SuperPMI collection of PMI of coreclr tests by BruceForstall · Pull Request #75211 · dotnet/runtime · GitHub
Skip to content

Remove SuperPMI collection of PMI of coreclr tests - #75211

Merged
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:RemoveSpmiCoreClrTestsPmiCollection
Sep 7, 2022
Merged

Remove SuperPMI collection of PMI of coreclr tests#75211
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:RemoveSpmiCoreClrTestsPmiCollection

Conversation

@BruceForstall

@BruceForstallBruceForstall commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

With #74961, we have a collection of a run of CoreCLR tests. That makes the PMI collection of the tests mostly duplicative.

@BruceForstall
Remove SuperPMI collection of PMI of coreclr tests
8825992
With dotnet#74961, we have a collection
of a run of CoreCLR tests. That makes the PMI collection of the tests
mostly duplicative.
@ghostghost added the area-Infrastructure-coreclr Only use for closed issues label Sep 7, 2022
@BruceForstall

BruceForstall commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

@kunalspathak @dotnet/jit-contrib PTAL

@ghost

ghost commented Sep 7, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

With #74961, we have a collection of a run of CoreCLR tests. That makes the PMI collection of the tests mostly duplicative.

Author:BruceForstall
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:-

@BruceForstall
BruceForstall merged commit f1c3302 into dotnet:mainSep 7, 2022
@BruceForstall
BruceForstall deleted the RemoveSpmiCoreClrTestsPmiCollection branch September 7, 2022 20:07
@AndyAyersMS

AndyAyersMS commented Sep 7, 2022

Copy link
Copy Markdown
Member

With #74961, we have a collection of a run of CoreCLR tests. That makes the PMI collection of the tests mostly duplicative.

Did you actually try merging the two collections to see how many were duplicates?

My hunch is that PMI actually has a lot of unique entries that don't show up in the test runs.

@BruceForstall

BruceForstall commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Did you actually try merging the two collections to see how many were duplicates?

My hunch is that PMI actually has a lot of unique entries that don't show up in the test runs.

I didn't try, and yes, I agree there will probably be unique entries, both (1) code unused at runtime, and (2) extra generics instantiations that PMI is able to create that aren't actually used at runtime.

It's easy enough to revert this change (which is why I wanted to do this change separately), if we want to get this back.

@BruceForstall

BruceForstall commented Sep 8, 2022

Copy link
Copy Markdown
ContributorAuthor

I looked at today's spmi collection, did "mcs -dumpMap" on the coreclr_tests pmi (old) and run (new) collections, and filtered to the number of unique function signatures (this ignores different functions with the same signatures, or different JIT flags). "run" has 88288 methods, "PMI" has 56852 methods. So, there are a huge number of diffs. On a quick overview, many are what was expected: PMI has lots of cases of generics with lots of variety of instantiation arguments that aren't seen in "run". Oddly, but not unexpectedly I guess, PMI on x64 has lots of cases of Arm HW intrinsics test cases which don't exist in "run". It does seem like there are some cases in "PMI" that don't exist in "run" because they aren't used, like small accessors that presumably always get inlined in "run".

@BruceForstallBruceForstall mentioned this pull request Sep 29, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstallBruceForstall

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BruceForstall@AndyAyersMS@kunalspathak